WineHQ Bugzilla – Bug 57481 – Prey (2016) X11 fullscreen fails in 9.22

Bugzilla

Last modified: 2024-12-13 21:36:35 UTC

Prey (2016) X11 fullscreen fails in 9.22

Bug 57481 - Prey (2016) X11 fullscreen fails in 9.22


Summary:	Prey (2016) X11 fullscreen fails in 9.22

Status:	CLOSED FIXED

AppDB:	Show Apps affected by this bug
Product:	Wine
Classification:	Unclassified
Component:	-unknown
Version:	9.22
Hardware:	x86-64 Linux

Importance:	P2 normal
Target Milestone:	---
Assigned To:	Mr. Bugs

URL:
Keywords:	regression

Depends on:
Blocks:
	Show dependency tree

Reported:	2024-11-29 16:42 UTC by zlice
Modified:	2024-12-13 21:36 UTC (History)
CC List:	1 user (show)

See Also:
Regression SHA1:
Fixed by SHA1:	c43e8202114a318f82439c74153fcc73b685e8ea
Distribution:	---
Staged patchset:

Attachments
prey-9.22-winedbg (1.57 MB, text/plain) 2024-11-29 16:42 UTC, zlice	Details
iconify-switch-fix (1.67 KB, patch) 2024-11-29 23:20 UTC, zlice	Details \| Diff
View All Add an attachment (back traces, logs, proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description zlice 2024-11-29 16:42:13 UTC

Created attachment 77493 [details]
prey-9.22-winedbg

Wine 9.21 works fine with Prey https://www.gog.com/en/game/prey

Upgrading to 9.22 fullscreen x11drv will not resume after an alt-tab (tried in multiple window managers)

Some 400 lines of

0024:warn:x11drv:window_configure_notify window 0x20062/3a00001, mismatch config (0,0)-(2560,1440)/230, expected (-32000,-32000)-(-31840,-31969)/228

Comment 1 zlice 2024-11-29 19:07:23 UTC

undid some of commits in 9.22


- winex11: Ignore focus changes during WM_STATE transitions. https://gitlab.winehq.org/wine/wine/-/commit/0dc7e4046836595335cd64c92cc132791d78fba4
-  winex11: Avoid updating _NET_WM_STATE on iconic windows. https://gitlab.winehq.org/wine/wine/-/commit/b1dd7da80693e93acd113b42607e9fd0d9caa6f2
-  winex11: Get rid of the now unnecessary mapped field. https://gitlab.winehq.org/wine/wine/-/commit/cba8970150b39c6ca96af69bd3e5f8a19d877394
-  winex11: Get rid of the now unnecessary iconic field. https://gitlab.winehq.org/wine/wine/-/commit/a3841ebc853ff682504d13bcfcb4a1deef186385
- winex11: Remove now unnecessary WindowPosChanged re-entry guards. https://gitlab.winehq.org/wine/wine/-/commit/26f3edd4531a85bf2d873a34eaf3514020bf2ea4


i assume the iconic/mapped (they step on each other) changes are what fixed it, maybe the wmstate focus changes too.

Comment 2 zlice 2024-11-29 23:20:42 UTC

Created attachment 77496 [details]
iconify-switch-fix

The MAKELONG() macro checks for switch-case do not seem to work

Comment 3 Rémi Bernon 2024-12-03 09:18:42 UTC

Thanks for the report, https://gitlab.winehq.org/wine/wine/-/merge_requests/6945 should fix this.

Comment 4 Rémi Bernon 2024-12-09 12:20:09 UTC

Marking as fixed with c43e8202114a318f82439c74153fcc73b685e8ea

Comment 5 Alexandre Julliard 2024-12-13 21:36:35 UTC

Closing bugs fixed in 10.0-rc2.