WineHQ Bugzilla – Bug 57285 – Foxit Reader - maximized view don't work properly

Bugzilla

Last modified: 2024-12-13 21:36:45 UTC

Foxit Reader - maximized view don't work properly

Bug 57285 - Foxit Reader - maximized view don't work properly


Summary:	Foxit Reader - maximized view don't work properly

Status:	CLOSED FIXED

AppDB:	Show Apps affected by this bug
Product:	Wine
Classification:	Unclassified
Component:	winex11.drv
Version:	9.19
Hardware:	x86-64 Linux

Importance:	P2 normal
Target Milestone:	---
Assigned To:	Mr. Bugs

URL:	https://cdn78.foxitsoftware.com/produ...
Keywords:	download, regression

Depends on:
Blocks:
	Show dependency tree

Reported:	2024-10-08 10:50 UTC by AndyF
Modified:	2024-12-13 21:36 UTC (History)
CC List:	3 users (show)

See Also:
Regression SHA1:	b68e82e8e51a066bdcbd66ab8b3e7da003b55a65
Fixed by SHA1:	e237379d98840871daebd05a9bea13a1fa75dec1
Distribution:	Mint
Staged patchset:

Attachments
Foxit maximized (64.05 KB, image/png) 2024-10-08 10:50 UTC, AndyF	Details
possible workaround (4.20 KB, patch) 2024-12-09 14:53 UTC, Rémi Bernon	Details \| Diff
Fix (919 bytes, patch) 2024-12-10 11:39 UTC, Rémi Bernon	Details \| Diff
Show Obsolete (1) View All Add an attachment (back traces, logs, proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description AndyF 2024-10-08 10:50:04 UTC

Created attachment 77227 [details]
Foxit maximized

Foxit Reader works well, until you'll try to maximize his window. Parts (right side) of his window won't be visible. Window seems to be maximized, but rendered with "normal" size.

Everything is fine on stable-branch.

Comment 1 Fabian Maurer 2024-10-08 19:24:42 UTC

Can you link the version you used?

Comment 2 AndyF 2024-10-11 14:38:13 UTC

https://www.foxit.com/de/downloads/#foxit-pdf-reader

I've used latest Windows-Version.

Comment 3 Fabian Maurer 2024-10-11 18:41:43 UTC

Confirming.

Comment 4 AndyF 2024-11-10 07:36:39 UTC

.. issue is still preset with 9.21

Comment 5 Fabian Maurer 2024-11-10 19:51:35 UTC

Please don't change the version after reporting an issue.

Comment 6 AndyF 2024-12-02 08:56:11 UTC

b68e82e8e51a066bdcbd66ab8b3e7da003b55a65 is the first bad commit
commit b68e82e8e51a066bdcbd66ab8b3e7da003b55a65
Author: Rémi Bernon <rbernon@codeweavers.com>
Date:   Wed Jul 17 10:51:20 2024 +0200

    winex11: Reset empty window shape even without a window surface.
    
    And invalidate the window surface shape if any, so that it gets updated
    again in update_surface_region if the window is actually shaped.
    
    Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56972

 dlls/winex11.drv/bitblt.c |  3 ---
 dlls/winex11.drv/window.c | 32 ++++++++++++++++++++------------
 2 files changed, 20 insertions(+), 15 deletions(-)

Comment 7 AndyF 2024-12-07 11:39:30 UTC

Still an issue at 10rc1.

Comment 8 Rémi Bernon 2024-12-09 14:53:28 UTC

Created attachment 77562 [details]
possible workaround

Hi! Thanks for the bug report. It looks like you're using KDE, and fwiw KWin maximized window state is known to be broken (see bug 57465), and has been like that for a long time although it was sometimes working a bit by chance.

Could you try the attached workaround in Wine which I believe could help and confirm if this is the same issue?

Comment 9 AndyF 2024-12-09 18:51:17 UTC

Hi!

I am using Cinnamon (Linux Mint) as Desktop. So it should be a different thing?

Is it possible to download your patch/workaround?
(Maybe it is a silly question - but until yet, I've compiled wine only via github sources).

Regards, Andy

Comment 10 Rémi Bernon 2024-12-09 18:52:54 UTC

Oh okay, I got confused by the looks of it on the screen capture. Well might be different then. I'll have a look.

Comment 11 Rémi Bernon 2024-12-10 11:39:07 UTC

Created attachment 77576 [details]
Fix

This looks like another instance of Mutter-based WM confusing themselves after doing their little dance on _MOTIF_WM_HINTS changes.

The attached patch seems to fix it, although there's no reason for it to other than changing the sequence of events to please the window manager, it could also very well break other WMs, and I'm not sure we want to merge that at this point.

That change was actually part of some other series of WM workarounds I had prepared in https://gitlab.winehq.org/wine/wine/-/merge_requests/6944, also partly helping KWin maximized state confusion.

Comment 12 Rémi Bernon 2024-12-10 14:26:00 UTC

Actually, this issue is also present when not using window manager decorations, and with the virtual desktop. I've opened https://gitlab.winehq.org/wine/wine/-/merge_requests/6990 to fix this independently of the window manager workaround above.

Comment 13 Rémi Bernon 2024-12-10 22:37:24 UTC

The underlying issue has been fixed with e237379d98840871daebd05a9bea13a1fa75dec1, the application should maximize/restore correctly if "Allow the window manager to decorate the windows" is unchecked, or if virtual desktop is enabled in winecfg, so marking this as fixed.

Comment 14 Alexandre Julliard 2024-12-13 21:36:45 UTC

Closing bugs fixed in 10.0-rc2.