added dl link

Hi, i cannot add the author of patch in the CC field, because email-address seems unknown(?). Any one know correct email-address?

Maybe they don't have a bugzilla account?

Maybe we should ping them on the MR? https://gitlab.winehq.org/wine/wine/-/merge_requests/5692

(In reply to Fabian Maurer from comment #3)
> Maybe they don't have a bugzilla account?
> 
> Maybe we should ping them on the MR?
> https://gitlab.winehq.org/wine/wine/-/merge_requests/5692

Thanks, I dropped a note there. Also paste some debug output below, might or might not help to see why it fails ;)

0024:trace:exec:SHELL_execute mask=0x00000540 hwnd=00000000 verb=L"runas" file=L"vs_bootstrapper_d15\\vs_setup_bootstrapper.exe " parm=L"  --env \"_SFX_CAB_EXE_PACKAGE:Z:\\home\\louis\\ramdisk\\vs_Community.exe _SFX_CAB_EXE_ORIGINALWORKINGDIR:Z:\\home\\louis\\sda3\\wine\"" dir=L"C:\\users\\louis\\Temp\\3252d0f1a378a23b87c1ac\\" show=0x00000005 class=not used
0024:fixme:exec:SHELL_execute flags ignored: 0x00000100
0024:trace:exec:ShellExecute_FromContextMenu L"vs_bootstrapper_d15\\vs_setup_bootstrapper.exe "
0024:trace:exec:ShellExecute_GetClassKey ext = L""
0024:trace:exec:ShellExecute_GetClassKey class = (null)
0024:trace:exec:SHELL_execute execute:L"vs_bootstrapper_d15\\vs_setup_bootstrapper.exe ",L"  --env \"_SFX_CAB_EXE_PACKAGE:Z:\\home\\louis\\ramdisk\\vs_Community.exe _SFX_CAB_EXE_ORIGINALWORKINGDIR:Z:\\home\\louis\\sda3\\wine\"",L"C:\\users\\louis\\Temp\\3252d0f1a378a23b87c1ac\\"
0024:trace:exec:SHELL_FindExecutable L"vs_bootstrapper_d15\\vs_setup_bootstrapper.exe "
0024:trace:exec:SHELL_FindExecutable ASDF L"C:\\users\\louis\\Temp\\3252d0f1a378a23b87c1ac\\"
0024:trace:shell:PathFileExistsDefExtW (L"C:\\users\\louis\\Temp\\3252d0f1a378a23b87c1ac\\vs_bootstrapper_d15\\vs_setup_bootstrapper.exe ",191)
0024:trace:shell:PathFileExistsDefExtW (L"vs_bootstrapper_d15\\vs_setup_bootstrapper.exe ",191)
0024:trace:exec:SHELL_FindExecutable Returning SE_ERR_FNF
0024:trace:shell:PathIsDirectoryW (L"vs_bootstrapper_d15\\vs_setup_bootstrapper.exe ")
0024:trace:exec:SHELL_execute retval 2

Adding 'regression' keyword and CC'ing patch author.

I tried follow code path in current shell32, and maybe the troubles is caused by the trailing space in the filepath: "...vs_setup_bootstrapper.exe "

(PathFileExistsDefExtW (L"vs_bootstrapper_d15\\vs_setup_bootstrapper.exe ",191)

If I strip that space manually away with a hack, the installer works again. But that needs some testing first for I guess PathFileExistsDefExtW

Created attachment 76768 [details]
test executable

Attached a small test executable

On windows this will start regedit, on wine it does nothing...

After long search, if I'm correct, the problem is in ShellExecuteW. Source for simple test:

#include <windows.h>
#include <shellapi.h>

int __cdecl main(int argc, CHAR *arg[])
{
    
ShellExecuteW( NULL, L"open", L"regedit.exe ", NULL, NULL, SW_SHOWNORMAL );

}

Wine's ShellExecuteW doesn't like the trailing space, but windows seems to happily execute the app.

I'll see if I can fixup a patch

Created attachment 76791 [details]
patch

Attached patch (+tests) fixes this bug.

Will send later to wine-gitlab for review.

FWIW, it only seems to be normal space characters that are allowed. tab, newline, linefeed, non-breaking space and zero width space don't work.

Created attachment 77425 [details]
updated patch

Updated patch, the previous patch was wrong I think as lpFile is a const wchar, which it was trying to modify.

Hi, thanks for triaging the bug and providing a patch! Can you submit your patch as an MR here: https://gitlab.winehq.org?

It would be nice to get this regression fixed during code freeze. Louis, are you interested in submitting your patch? If not, let us know and we can take care of it.

Fixed with 448fcbc0c60d7228ed52f1f5d90f62be0a58289a.

Closing bugs fixed in 10.0-rc2.