WineHQ Bugzilla – Bug 56119 – Emperor - Rise of the Middle Kingdom: invisible menu buttons

Bugzilla

Last modified: 2024-01-26 17:10:34 UTC

Emperor - Rise of the Middle Kingdom: invisible menu buttons

Bug 56119 - Emperor - Rise of the Middle Kingdom: invisible menu buttons


Summary:	Emperor - Rise of the Middle Kingdom: invisible menu buttons

Status:	CLOSED FIXED

AppDB:	Show Apps affected by this bug
Product:	Wine
Classification:	Unclassified
Component:	d3d
Version:	8.18
Hardware:	x86-64 Linux

Importance:	P2 normal
Target Milestone:	---
Assigned To:	Mr. Bugs

URL:	https://www.gamepressure.com/download...
Keywords:	download, regression

Depends on:
Blocks:
	Show dependency tree

Reported:	2023-12-30 14:41 UTC by Béla Gyebrószki
Modified:	2024-01-26 17:10 UTC (History)
CC List:	1 user (show)

See Also:
Regression SHA1:	ee7d047dd55a4b2338eb2d64f85b7d984b39812f
Fixed by SHA1:	b712d6c8464681ca82f11cf49051401b874814c6
Distribution:	---
Staged patchset:

Attachments
proof... (871 bytes, patch) 2023-12-30 17:12 UTC, Zeb Figura	Details \| Diff
Text without transparency in Egypt 3 (124.07 KB, image/jpeg) 2024-01-05 20:47 UTC, Béla Gyebrószki	Details
View All Add an attachment (back traces, logs, proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Béla Gyebrószki 2023-12-30 14:41:16 UTC

Only the background is drawn in the menus, the menu buttons are invisible in the game Emperor:Rise of the Middle Kingdom (GOG). Can be reproduced in the demo version too.

Pharaoh is another city-building game using the same engine: here the screen remains black when the game gets to the main menu.
Pharaoh demo:
https://archive.org/download/PharaohDemo/PharaohDemo.zip

Reverting commit ee7d047dd55a4b2338eb2d64f85b7d984b39812f
on top of Wine-9.0-rc3 fixes the problem in both games for me.

Plain terminal output doesn't show anything related.

PharaohDemo.zip  (74 M)
md5:474872cf372acbd4312ca0a6caf75434

si_emperor_demo.exe  (128 M)
md5:45052f088f699afb7a0d5e2ecfcb1804

Comment 1 Zeb Figura 2023-12-30 17:12:43 UTC

Created attachment 75789 [details]
proof...

I believe the application is writing to the texture's sysmem outside of Lock() and expecting it to be blitted to the screen. It's been sort of vague knowledge that DDraw Applications Do This Kind Of Thing, but no specific one was mentioned and no tests ever validated it.

The offending texture (I was able to narrow it down to exactly one which causes the invisible buttons when a separate draw texture is used) is locked, then the entire texture is cleared, then blitted from and to.

Proof of this hypothesis is that if we replace the texture's sysmem during the clear, with the attached patch, the menu is invisible even with the offending commit reverted.

Comment 2 Béla Gyebrószki 2024-01-05 13:01:07 UTC

I came across another game where commit ee7d047 causes issues.
In the adventure game 'The Egyptian Prophecy: The Fate of Ramses' text (dialogues, in-game encyclopedia) is hardly readable because it is displayed on a bright cyan background without transparency.
No demo version exists, but the game is available on Steam:
https://store.steampowered.com/app/302160/The_Egyptian_Prophecy_The_Fate_of_Ramses/

Comment 3 Zeb Figura 2024-01-05 13:24:08 UTC

I sent <https://gitlab.winehq.org/wine/wine/-/merge_requests/4781> for this.

Comment 4 Béla Gyebrószki 2024-01-05 13:36:35 UTC

(In reply to Zeb Figura from comment #3)
> I sent <https://gitlab.winehq.org/wine/wine/-/merge_requests/4781> for this.

Indeed it fixes the problem in Emperor and in the Pharaoh games.
However, it doesn't help the Egyptian Prophecy game. That looks like a different issue. Do you want me to open a new bug report for that, once your MR4781 merged in ?

Comment 5 Zeb Figura 2024-01-05 15:29:34 UTC

(In reply to Béla Gyebrószki from comment #4)
> (In reply to Zeb Figura from comment #3)
> > I sent <https://gitlab.winehq.org/wine/wine/-/merge_requests/4781> for this.
> 
> Indeed it fixes the problem in Emperor and in the Pharaoh games.
> However, it doesn't help the Egyptian Prophecy game. That looks like a
> different issue. Do you want me to open a new bug report for that, once your
> MR4781 merged in ?

You can go ahead and create a bug report for it now. Thanks for testing!

Comment 6 Zeb Figura 2024-01-05 15:30:07 UTC

I installed the game, but it crashes inside gameoverlayrenderer on startup. Did you use any workarounds?

Comment 7 Béla Gyebrószki 2024-01-05 20:47:05 UTC

Created attachment 75834 [details]
Text without transparency in Egypt 3

(In reply to Zeb Figura from comment #6)
> I installed the game, but it crashes inside gameoverlayrenderer on startup.
> Did you use any workarounds?

The game can be launched directly with the Egypt3.exe executable (without Steam running).
Once in the main menu select <Documentary Database>.

Comment 8 Béla Gyebrószki 2024-01-17 22:27:22 UTC

Regarding the games Emperor and Pharaoh this bug is fixed by
commit b712d6c8464681ca82f11cf49051401b874814c6.

wine-9.0-54-g1932c3a2516

Comment 9 Alexandre Julliard 2024-01-26 17:10:34 UTC

Closing bugs fixed in 9.1.