WineHQ Bugzilla – Bug 35612 – jscript:activex fails if the user does not have sufficient privileges

Bugzilla

Last modified: 2014-02-20 12:37:59 UTC

jscript:activex fails if the user does not have sufficient privileges

Bug 35612 - jscript:activex fails if the user does not have sufficient privileges


Summary:	jscript:activex fails if the user does not have sufficient privileges

Status:	CLOSED FIXED

AppDB:	Show Apps affected by this bug
Product:	Wine
Classification:	Unclassified
Component:	jscript
Version:	1.7.12
Hardware:	x86 Windows

Importance:	P2 normal
Target Milestone:	---
Assigned To:	Mr. Bugs

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree

Reported:	2014-02-17 11:38 UTC by François Gouget
Modified:	2014-02-20 12:37 UTC (History)
CC List:	1 user (show)

See Also:
Regression SHA1:
Fixed by SHA1:	cd22e8c223bc3cd55ff86aa4da03c3d8b6fb3e41
Distribution:	---
Staged patchset:

Attachments
Add an attachment (back traces, logs, proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description François Gouget 2014-02-17 11:38:56 UTC

If the user does not have elevated privileges, then we get 81 test failures. This can be seen in the fg-win7u64-1spie9-adm, fg-win7u64-spie9-usr VM results and also happens on my Windows 8.1 Acer laptop (fg-acer64-w81-t32 and 	fg-acer64-w81-t64). See:

http://test.winehq.org/data/tests/jscript:activex.html

Mostly it seems to be the IActiveScriptParse::ParseScriptText() calls that are failing with all the other failures being natural consequences of that. So I'm only showing the ParseScriptText failures below:

activex.c:828: Test failed: ParseScriptText failed: 800a01ad
activex.c:955: Test failed: ParseScriptText failed: 800a01ad
activex.c:1006: Test failed: ParseScriptText failed: 800a01ad
activex.c:1023: Test failed: ParseScriptText failed: 800a01ad
activex.c:1056: Test failed: ParseScriptText failed: 800a01ad


I suspect the issue is that without elevated privileges we cannot register/install our Wine.Test ActiveX object. I would expect to get failures a bit earlier though.

Probably the solution is to include the is_process_limited() function and skip the tests at some point if it returns TRUE.

Comment 1 François Gouget 2014-02-17 11:40:55 UTC

vbscript:createobj seems to have a very similar problem:

createobj.c:787: Test failed: ParseScriptText failed: 800a01ad
createobj.c:877: Test failed: ParseScriptText failed: 800a01ad
createobj.c:931: Test failed: ParseScriptText failed: 800a01ad
createobj.c:948: Test failed: ParseScriptText failed: 800a01ad

Comment 2 Jacek Caban 2014-02-17 11:55:23 UTC

We should skip tests if register_activex fails, but we weren't checking its result. I've sent a patch:

http://source.winehq.org/patches/data/102561

Comment 3 Jacek Caban 2014-02-18 04:35:37 UTC

Fixed in Git:

http://source.winehq.org/git/wine.git/commit/cd22e8c223bc3cd55ff86aa4da03c3d8b6fb3e41

I also sent similar patches for vbscript and wscript:

http://source.winehq.org/patches/data/102582
http://source.winehq.org/patches/data/102583

Comment 4 Alexandre Julliard 2014-02-20 12:37:59 UTC

Closing bugs fixed in 1.7.13.