WineHQ Bugzilla – Bug 35584 – wine can no longer execute rm.com (DOS application)

Bugzilla

Last modified: 2014-02-20 12:37:10 UTC

wine can no longer execute rm.com (DOS application)

Bug 35584 - wine can no longer execute rm.com (DOS application)


Summary:	wine can no longer execute rm.com (DOS application)

Status:	CLOSED FIXED

AppDB:	Show Apps affected by this bug
Product:	Wine
Classification:	Unclassified
Component:	kernel32
Version:	1.7.6
Hardware:	x86 Linux

Importance:	P2 normal
Target Milestone:	---
Assigned To:	Mr. Bugs

URL:	ftp://ftp.pl.freebsd.org/vol/rzm1/sim...
Keywords:	download, regression, source

Depends on:
Blocks:	17181
	Show dependency tree

Reported:	2014-02-11 18:13 UTC by Austin English
Modified:	2014-02-20 12:37 UTC (History)
CC List:	0 users

See Also:
Regression SHA1:	1e78c99388c61d353cf60787eac6415328f54560
Fixed by SHA1:	7066ce0b1e22bc490bd791fd948bbbb3a1400bc9
Distribution:	---
Staged patchset:

Attachments
Add an attachment (back traces, logs, proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Austin English 2014-02-11 18:13:48 UTC

I noticed this while looking at bug 17181.

austin@aw25 ~/rm $ wine RM.COM /s testdir
err:process:get_process_cpu L"winevdm.exe" uses unsupported architecture (0000)
wine: Bad EXE format for Z:\home\austin\rm\RM.COM.

that is a regression, introduced by:
1e78c99388c61d353cf60787eac6415328f54560 is the first bad commit
commit 1e78c99388c61d353cf60787eac6415328f54560
Author: Alexandre Julliard <julliard@winehq.org>
Date:   Fri Nov 22 12:32:48 2013 +0100

    kernel32: Validate the architecture of newly created processes on the server side.

before that, wine would launch the application (via dosbox). Now, it prints that error and exits.

This lets it proceed and return to bug 17181:
diff --git a/dlls/kernel32/process.c b/dlls/kernel32/process.c
index bf113d6..58f8924 100644
--- a/dlls/kernel32/process.c
+++ b/dlls/kernel32/process.c
@@ -1815,6 +1815,7 @@ static int get_process_cpu( const WCHAR *filename, const struct binary_info *bin
 {
     switch (binary_info->arch)
     {
+    case IMAGE_FILE_MACHINE_UNKNOWN:     return 0;
     case IMAGE_FILE_MACHINE_I386:    return CPU_x86;
     case IMAGE_FILE_MACHINE_AMD64:   return CPU_x86_64;
     case IMAGE_FILE_MACHINE_POWERPC: return CPU_POWERPC;

austin@aw25 ~/oldbugs/17181 $ shasum ma_rm14.zip 
c706746c4dd10d1e4a737941ca93338f328db523  ma_rm14.zip
austin@aw25 ~/oldbugs/17181 $ du -h ma_rm14.zip 
16K	ma_rm14.zip

Comment 1 Austin English 2014-02-12 14:20:45 UTC

Fixed by https://source.winehq.org/git/wine.git/commitdiff/7066ce0b1e22bc490bd791fd948bbbb3a1400bc9

Comment 2 Alexandre Julliard 2014-02-20 12:37:10 UTC

Closing bugs fixed in 1.7.13.