WineHQ Bugzilla – Bug 35509 – ProPresenter 4.x (.NET 3.5 WPF app) installer needs WshShortcut_put_IconLocation

Bugzilla

Last modified: 2015-03-10 13:14:50 UTC

ProPresenter 4.x (.NET 3.5 WPF app) installer needs WshShortcut_put_IconLocation

Bug 35509 - ProPresenter 4.x (.NET 3.5 WPF app) installer needs WshShortcut_put_IconLocation


Summary:	ProPresenter 4.x (.NET 3.5 WPF app) installer needs WshShortcut_put_IconLocation

Status:	CLOSED FIXED

AppDB:	Show Apps affected by this bug
Product:	Wine
Classification:	Unclassified
Component:	wshom.ocx
Version:	1.7.11
Hardware:	x86 Linux

Importance:	P2 normal
Target Milestone:	---
Assigned To:	Mr. Bugs

URL:	http://web.archive.org/web/2010100617...
Keywords:	dotnet, download, Installer

Depends on:
Blocks:
	Show dependency tree

Reported:	2014-02-04 15:50 UTC by Anastasius Focht
Modified:	2015-03-10 13:14 UTC (History)
CC List:	0 users

See Also:
Regression SHA1:
Fixed by SHA1:	9239b8603768a97bff26888e08c7aef5c99dcea5
Distribution:	---
Staged patchset:

Attachments
Add an attachment (back traces, logs, proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Anastasius Focht 2014-02-04 15:50:48 UTC

Hello folks,

as the summary says ...

Prerequisite: 'winetricks -q dotnet35sp1'

--- snip ---
...
fixme:wshom:WshShortcut_put_IconLocation (0x34453b0)->(L"C:\\windows\\system32\\shell32.dll, 165"): stub
An exception occurred in the OnAfterInstall event handler of ProPresenter.SetupHelper.InstallerHelper.
System.NotImplementedException: The method or operation is not implemented.
err:msi:custom_get_thread_return Invalid Return Code -1
err:msi:ITERATE_Actions Execution halted, action L"_F8C4A53C_EE52_4DB2_A68B_BEC2DA560710.install" returned 1603
err:msi:ITERATE_Actions Execution halted, action L"ExecuteAction" returned 1603
--- snip ---

Source: http://source.winehq.org/git/wine.git/blob/f608c5d2ae7ee0dc82fbf2bae9ae82b7f8dbe5ee:/dlls/wshom.ocx/shell.c#l459

--- snip ---
459 static HRESULT WINAPI WshShortcut_put_IconLocation(IWshShortcut *iface, BSTR IconPath)
460 {
461     WshShortcut *This = impl_from_IWshShortcut(iface);
462     FIXME("(%p)->(%s): stub\n", This, debugstr_w(IconPath));
463     return E_NOTIMPL;
464 }
--- snip ---

'winetricks wsh57' works around.

$ sha1sum ProPresenter_Windows_4.0.0.1.zip 
f226375be25f41b9fba76b6a7f3b5acb7e01812b  ProPresenter_Windows_4.0.0.1.zip

$ du -sh ProPresenter_Windows_4.0.0.1.zip
123M	ProPresenter_Windows_4.0.0.1.zip

$ wine --version
wine-1.7.11-237-g00aeadc

Regards

Comment 1 Nikolay Sivov 2014-02-04 23:06:31 UTC

This one needs some trivial extra work on passed string, I'll take a look later.

Comment 2 Anastasius Focht 2014-02-10 13:38:13 UTC

Hello folks,

this is fixed by commit http://source.winehq.org/git/wine.git/commitdiff/9239b8603768a97bff26888e08c7aef5c99dcea5

--- snip ---
$ WINEDEBUG=+wshom wine ./setup.exe
...
trace:wshom:WshShortcut_put_TargetPath (0x345cef0)->(L"C:\\Windows\\System32\\msiexec.exe")
trace:wshom:WshShortcut_put_WorkingDirectory (0x345cef0)->(L"C:\\Windows\\System32\\")
trace:wshom:WshShortcut_put_Arguments (0x345cef0)->(L"/x {89C66246-747F-413C-8F60-2C05CBDE6216}")
trace:wshom:WshShortcut_put_Description (0x345cef0)->(L"Launch Uninstall")
trace:wshom:WshShortcut_put_WindowStyle (0x345cef0)->(1)
trace:wshom:WshShortcut_put_IconLocation (0x345cef0)->(L"C:\\windows\\system32\\shell32.dll, 165")
trace:wshom:WshShortcut_Save (0x345cef0)
...
--- snip ---

Thanks Nikolay

Regards

Comment 3 Alexandre Julliard 2014-02-20 12:37:59 UTC

Closing bugs fixed in 1.7.13.