WineHQ Bugzilla – Bug 35485 – Tab control is keeping pressed with TCM_SETCURSEL wParam:-1

Bugzilla

Last modified: 2014-02-20 12:37:48 UTC

Tab control is keeping pressed with TCM_SETCURSEL wParam:-1

Bug 35485 - Tab control is keeping pressed with TCM_SETCURSEL wParam:-1


Summary:	Tab control is keeping pressed with TCM_SETCURSEL wParam:-1

Status:	CLOSED FIXED

AppDB:	Show Apps affected by this bug
Product:	Wine
Classification:	Unclassified
Component:	comctl32
Version:	1.4.1
Hardware:	x86 Linux

Importance:	P2 normal
Target Milestone:	---
Assigned To:	Mr. Bugs

URL:
Keywords:	download, source

Depends on:
Blocks:
	Show dependency tree

Reported:	2014-02-01 07:14 UTC by s.wanabe
Modified:	2014-02-20 12:37 UTC (History)
CC List:	0 users

See Also:
Regression SHA1:
Fixed by SHA1:	0e73e478ff3f8ee46fc18b1f1bf211b0dec80a2a
Distribution:	---
Staged patchset:

Attachments
patch (2.81 KB, patch) 2014-02-08 10:13 UTC, Nikolay Sivov	Details \| Diff
View All Add an attachment (back traces, logs, proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description s.wanabe 2014-02-01 07:14:18 UTC

When Wine is recieved TCM_SETCURSEL with wParam == -1,
dwState of current pressed tab is kept TCIS_BUTTONPRESSED.
I have confirmed this with wine-1.4.1 and master branch 82b38139, on ubuntu 13.10.

  TAB_GetItem(infoPtr, prevItem)->dwState &= ~TCIS_BUTTONPRESSED;

This is a line in TAB_SetCurSel().
I guess this process is needed also when wParam == -1, isn't this?

Effects example:

xyzzy editor
(Stable English version) http://xyzzy.s53.xrea.com/english/archive/
(Stable Japanese version) http://www.jsdlab.co.jp/~kamei/
(Developing Japanese version) https://github.com/xyzzy-022/xyzzy

To reproduce the issue:

1. Run xyzzy.exe on Wine
2. Type [ALT] v q b to show buffer-tab
3. Type [ESC] x new-file to create new buffer-tab
4. Click "*scratch*" tab to Select the buffer
5. Same as 3. (Type [ESC] x new-file to create new buffer-tab)
6. Make sure of unselectable buffer-tabs

Xyzzy send TCM_SETCURSEL with -1 in above 5.

Comment 1 Ken Sharp 2014-02-01 08:31:31 UTC

Have you tried with Wine 1.7.11? 1.4.1 is ancient.

Comment 2 s.wanabe 2014-02-01 08:56:18 UTC

Thank you to comment!

I have tried master branch 82b38139, it is most recently version.
http://source.winehq.org/git/wine.git/commit/82b38139eb21a6898e4621eb7405e99189c09b18
And just now I tried with Wine 1.7.11 from launchpad, but the result is same.

Comment 3 Nikolay Sivov 2014-02-03 22:10:17 UTC

So did you verify that native comctl32 fixes this problem?

Comment 4 Nikolay Sivov 2014-02-08 09:41:40 UTC

Yes, this makes sense. I'll add a test for that and send with a fix next week.

Comment 5 Nikolay Sivov 2014-02-08 10:13:56 UTC

Created attachment 47467 [details]
patch

Here's a fix for this problem, feel free to test it and report any issues.

Comment 6 s.wanabe 2014-02-08 22:36:19 UTC

I've confirmed that xyzzy editor works fine as same as Windows Environment (Windows 7 Home Premium) on Wine (master branch) with the patch.
I can't find any issues. 

Thanks a lot!

Comment 7 Nikolay Sivov 2014-02-10 13:11:20 UTC

Fixed with 0e73e478ff3f8ee46fc18b1f1bf211b0dec80a2a.

Comment 8 Alexandre Julliard 2014-02-20 12:37:48 UTC

Closing bugs fixed in 1.7.13.