WineHQ Bugzilla – Bug 35055 – Incorrect SourceDir used for product update.

Bugzilla

Last modified: 2014-01-17 13:58:33 UTC

Incorrect SourceDir used for product update.

Bug 35055 - Incorrect SourceDir used for product update.


Summary:	Incorrect SourceDir used for product update.

Status:	CLOSED FIXED

AppDB:	Show Apps affected by this bug
Product:	Wine
Classification:	Unclassified
Component:	msi
Version:	1.7.7
Hardware:	x86 Linux

Importance:	P2 normal
Target Milestone:	---
Assigned To:	Mr. Bugs

URL:
Keywords:	regression

Depends on:
Blocks:
	Show dependency tree

Reported:	2013-12-05 12:33 UTC by Sergey Guralnik
Modified:	2014-01-17 13:58 UTC (History)
CC List:	1 user (show)

See Also:
Regression SHA1:	dd305c3700c1b5b0de41b87558930e08ba88bd68
Fixed by SHA1:	290d8a0f44a6c6fa46785b7e6db66ecb7fd99ea7
Distribution:	---
Staged patchset:

Attachments
Add an attachment (back traces, logs, proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Sergey Guralnik 2013-12-05 12:33:57 UTC

There are two versions of some product, Lets name they as "old" and "new". There is an ability of upgrade old version to new by simple running of new version installer. Windows handles this scenario pretty fine, but under wine updating doesn't happen.
I've tried to investigate this problem and got next results.
* Old version is installed by MsiInstallProduct(old_package_path, "") (installed to clean prefix)
* New version is installed above old by MsiInstallProduct(new_package_path), "REINSTALL=ALL REINSTALLMODE=vamus")
* During new version installing, i've caught call to msi_set_sourcedir_props(), that set SourceDir to old_package_path, that obviously is incorrect.
As result we have "updating" from old version to old, that seems like nothingh has changed.

Also it seems as regression, that introduced by
http://source.winehq.org/git/wine.git/commitdiff/dd305c3700c1b5b0de41b87558930e08ba88bd68

Comment 1 Sergey Guralnik 2013-12-05 12:53:43 UTC

(In reply to comment #0)
> Also it seems as regression, that introduced by
> http://source.winehq.org/git/wine.git/commitdiff/dd305c3700c1b5b0de41b87558930e08ba88bd68

Adding author to CC.
P.S. Maybe msi_set_sourcedir_props() should have some version checks before fetching SourceDir from registry?

Comment 2 Hans Leidekker 2013-12-05 13:27:53 UTC

(In reply to comment #1)
> (In reply to comment #0)
> > Also it seems as regression, that introduced by
> > http://source.winehq.org/git/wine.git/commitdiff/dd305c3700c1b5b0de41b87558930e08ba88bd68
> 
> Adding author to CC.
> P.S. Maybe msi_set_sourcedir_props() should have some version checks before
> fetching SourceDir from registry?

Have you confirmed that reverting the patch fixes your bug? It fixes the case where a product is patched, which normally means that the product version is incremented. So a version check is probably not sufficient.

Comment 3 Sergey Guralnik 2013-12-06 00:39:06 UTC

(In reply to comment #2)
> Have you confirmed that reverting the patch fixes your bug? It fixes the case
> where a product is patched, which normally means that the product version is
> incremented. So a version check is probably not sufficient.

Yes, bug disappears after reverting. Maybe you have some another ideas related to SourceDir setting? Probably there should be some additional conditions for using registered value.

Comment 4 Hans Leidekker 2013-12-06 03:54:38 UTC

(In reply to comment #3)
> (In reply to comment #2)
> > Have you confirmed that reverting the patch fixes your bug? It fixes the case
> > where a product is patched, which normally means that the product version is
> > incremented. So a version check is probably not sufficient.
> 
> Yes, bug disappears after reverting. Maybe you have some another ideas related
> to SourceDir setting? Probably there should be some additional conditions for
> using registered value.

I'm not sure, I would need to investigate.

Comment 5 Hans Leidekker 2014-01-06 03:45:42 UTC

Should be fixed by 290d8a0f44a6c6fa46785b7e6db66ecb7fd99ea7.

Comment 6 Sergey Guralnik 2014-01-08 03:00:16 UTC

(In reply to comment #5)
> Should be fixed by 290d8a0f44a6c6fa46785b7e6db66ecb7fd99ea7.

It works fine again. Thank you!

Comment 7 Alexandre Julliard 2014-01-17 13:58:33 UTC

Closing bugs fixed in 1.7.11.