WineHQ
Bug Tracking Database – Bug 35030

 Bugzilla

 

Last modified: 2015-09-03 23:18:27 UTC  

Steam Client update from Dec. 3, 2013 breaks Wine (Steam Client/Service crash after update, login fails)

Bug 35030 - Steam Client update from Dec. 3, 2013 breaks Wine (Steam Client/Service crash after update, login fails)
Steam Client update from Dec. 3, 2013 breaks Wine (Steam Client/Service crash...
Status: CLOSED FIXED
AppDB: Show Apps affected by this bug
Product: Wine
Classification: Unclassified
Component: ntdll
1.7.7
x86-64 Linux
: P2 normal
: ---
Assigned To: Mr. Bugs
http://media.steampowered.com/client/...
: download
: 35046 35047 35048 35050 35051 35074 35086 35091 35099 35148 35154 35183 35271 35295 35299 35654 39202 (view as bug list)
Depends on:
Blocks:
  Show dependency tree
 
Reported: 2013-12-01 12:59 UTC by Le Gluon du Net
Modified: 2015-09-03 23:18 UTC (History)
25 users (show)

See Also:
Regression SHA1:
Fixed by SHA1: fd65b0a1c3f5f981cc110ca9e6a0edb6323e1296
Distribution: ---
Staged patchset:


Attachments
crash log (4.86 KB, text/plain)
2013-12-01 12:59 UTC, Le Gluon du Net
Details
Still crashes, reloads not working (12.29 KB, text/plain)
2013-12-06 01:44 UTC, Justin la plante
Details
this is what the error says. (11.26 KB, text/plain)
2014-01-03 18:57 UTC, sovejohn
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Le Gluon du Net 2013-12-01 12:59:09 UTC
Created attachment 46692 [details]
crash log

Hello,

when I launch Steam install program, it crashes at the end of the install, then continue with downloading the whole client. It is not an important crash because it doesn't stop the install. I joined the log of the crash.

Thank you for your help.

Config:
Ubuntu 13.10 
wine 1.7.7 32 bits
AMD radeon 7850 with Ubuntu Catalyst drivers 13.101 version
Processor Intel i5-3570 3,4 Ghz
Comment 1 Anastasius Focht 2013-12-01 13:29:09 UTC
Hello folks,

confirming.

It's not the installer crashing but the post-install part, the startup of Steam client service.

--- snip ---
...
002f:Starting process L"C:\\Program Files\\Steam\\bin\\SteamService.exe" (entryproc=0x43d6fa) 
...
002f:Call advapi32.RegCreateKeyExA(80000002,0045f478 "SYSTEM\\CurrentControlSet\\Services\\EventLog\\Application\\Steam Client Service",00000000,00000000,00000000,00020006,00000000,0033fca0,00000000) ret=00407fe3
002f:Ret  advapi32.RegCreateKeyExA() retval=00000000 ret=00407fe3
002f:Call KERNEL32.GetModuleFileNameA(00000000,0033fa9c,00000200) ret=00408022
002f:Ret  KERNEL32.GetModuleFileNameA() retval=0000002b ret=00408022
002f:Call KERNEL32.lstrlenA(0033fa9c "C:\\Program Files\\Steam\\bin\\SteamService.exe") ret=0040802f
002f:Ret  KERNEL32.lstrlenA() retval=0000002b ret=0040802f
002f:Call advapi32.RegSetValueExA(0000003c,0045f424 "EventMessageFile",00000000,00000002,0033fa9c,0000002c) ret=0040804d
002f:Ret  advapi32.RegSetValueExA() retval=00000000 ret=0040804d
002f:Call advapi32.RegSetValueExA(0000003c,0045f3ec "TypesSupported",00000000,00000004,0033fc9c,00000004) ret=00408097
002f:Ret  advapi32.RegSetValueExA() retval=00000000 ret=00408097
002f:Call advapi32.RegCloseKey(0000003c) ret=004080cf
002f:Ret  advapi32.RegCloseKey() retval=00000000 ret=004080cf
002f:Call advapi32.RegCreateKeyExA(80000002,0045b2f4 "Software\\Valve\\Steam",00000000,00000000,00000000,000f003f,00000000,0033fdb0,00000000) ret=00408118
002f:Ret  advapi32.RegCreateKeyExA() retval=00000000 ret=00408118
002f:Call advapi32.OpenProcessToken(ffffffff,00000020,0033fc94) ret=0040a8d9
002f:Ret  advapi32.OpenProcessToken() retval=00000001 ret=0040a8d9
002f:Call advapi32.LookupPrivilegeValueA(00000000,004601d4,0033fc04) ret=0040a824
002f:Ret  advapi32.LookupPrivilegeValueA() retval=00000001 ret=0040a824
002f:Call advapi32.AdjustTokenPrivileges(00000044,00000000,0033fbf4,00000010,0033fbe4,00000000) ret=0040a86e
002f:trace:seh:raise_exception code=c0000005 flags=0 addr=0x7bc5bc1c ip=7bc5bc1c tid=002f
002f:trace:seh:raise_exception  info[0]=00000001
002f:trace:seh:raise_exception  info[1]=00000000
002f:trace:seh:raise_exception  eax=00000000 ebx=7bccf000 ecx=00000000 edx=00000004 esi=0033fb80 edi=0033fb98
002f:trace:seh:raise_exception  ebp=0033fb18 esp=0033fa50 cs=0023 ds=002b es=002b fs=0063 gs=006b flags=00010206
002f:trace:seh:call_stack_handlers calling handler at 0x43e230 code=c0000005 flags=0 
--- snip ---

MSDN: http://msdn.microsoft.com/en-us/library/windows/desktop/aa375202%28v=vs.85%29.aspx

--- quote ---
OOL WINAPI AdjustTokenPrivileges(
  _In_       HANDLE TokenHandle,
  _In_       BOOL DisableAllPrivileges,
  _In_opt_   PTOKEN_PRIVILEGES NewState,
  _In_       DWORD BufferLength,
  _Out_opt_  PTOKEN_PRIVILEGES PreviousState,
  _Out_opt_  PDWORD ReturnLength
);

...
PreviousState [out, optional]

    A pointer to a buffer that the function fills with a TOKEN_PRIVILEGES structure that contains the previous state of any privileges that the function modifies. That is, if a privilege has been modified by this function, the privilege and its previous state are contained in the TOKEN_PRIVILEGES structure referenced by PreviousState. If the PrivilegeCount member of TOKEN_PRIVILEGES is zero, then no privileges have been changed by this function. This parameter can be NULL.

    If you specify a buffer that is too small to receive the complete list of modified privileges, the function fails and does not adjust any privileges. In this case, the function sets the variable pointed to by the ReturnLength parameter to the number of bytes required to hold the complete list of modified privileges.
ReturnLength [out, optional]

    A pointer to a variable that receives the required size, in bytes, of the buffer pointed to by the PreviousState parameter. This parameter can be NULL if PreviousState is NULL.
--- quote ---

I checked the service binary code and "ReturnLength" is really hard-coded to NULL while "PreviousState" is non-NULL (stack var).

Another case of MSDN not really telling the truth.

Source: http://source.winehq.org/git/wine.git/blob/eef5e45ee6aae7029ec3ec0565fbbdc2ee29b59f:/dlls/ntdll/nt.c#l197

--- snip ---
197 NTSTATUS WINAPI NtAdjustPrivilegesToken(
...
204 {
...
210     SERVER_START_REQ( adjust_token_privileges )
211     {
...
224         if (PreviousState)
225         {
226             *ReturnLength = reply->len + FIELD_OFFSET( TOKEN_PRIVILEGES, Privileges );
227             PreviousState->PrivilegeCount = reply->len / sizeof(LUID_AND_ATTRIBUTES);
228         }
229     }
230     SERVER_END_REQ;
231
232     return ret;
233 }
--- snip ---

$ sha1sum SteamSetup.exe 
f2dd1ab2a96bd5b961bbc504458d5c53f242926c  SteamSetup.exe

$ du -sh SteamSetup.exe 
1.1M	SteamSetup.exe

$ wine --version
wine-1.7.7-230-g2507330

Regards
Comment 2 Nikolay Sivov 2013-12-01 23:16:29 UTC
Ok, I'll do some tests for that.
Comment 3 Anastasius Focht 2013-12-02 14:58:32 UTC
Hello folks,

this is fixed by commit http://source.winehq.org/git/wine.git/commit/fd65b0a1c3f5f981cc110ca9e6a0edb6323e1296

Thanks Nikolay

--- snip ---
...
002f:Call advapi32.OpenProcessToken(ffffffff,00000020,0033fc94) ret=0040a8d9
002f:Ret  advapi32.OpenProcessToken() retval=00000001 ret=0040a8d9
002f:Call advapi32.LookupPrivilegeValueA(00000000,004601d4,0033fc04) ret=0040a824
002f:Ret  advapi32.LookupPrivilegeValueA() retval=00000001 ret=0040a824
002f:Call advapi32.AdjustTokenPrivileges(00000044,00000000,0033fbf4,00000010,0033fbe4,00000000) ret=0040a86e
002f:Ret  advapi32.AdjustTokenPrivileges() retval=00000000 ret=0040a86e
002f:Call advapi32.ConvertStringSidToSidA(0045fd6c,0033fc90) ret=0040a908
002f:Ret  advapi32.ConvertStringSidToSidA() retval=00000001 ret=0040a908
002f:Call advapi32.ConvertStringSidToSidA(004601e8,0033fc8c) ret=0040a916
002f:Ret  advapi32.ConvertStringSidToSidA() retval=00000001 ret=0040a916
002f:Call advapi32.SetEntriesInAclA(00000002,0033fc20,00000000,0033fc88) ret=0040a977
002f:Ret  advapi32.SetEntriesInAclA() retval=00000000 ret=0040a977
002f:Call advapi32.SetNamedSecurityInfoA(0045f590 "MACHINE\\SOFTWARE\\Valve\\Steam",00000004,00000004,00000000,00000000,0012cc88,00000000) ret=0040a992
002f:Ret  advapi32.SetNamedSecurityInfoA() retval=00000000 ret=0040a992 
--- snip ---

Regards
Comment 4 Anastasius Focht 2013-12-03 16:38:54 UTC
*** Bug 35046 has been marked as a duplicate of this bug. ***
Comment 5 Bruno Jesus 2013-12-03 17:58:23 UTC
*** Bug 35047 has been marked as a duplicate of this bug. ***
Comment 6 Anastasius Focht 2013-12-04 04:36:00 UTC
*** Bug 35048 has been marked as a duplicate of this bug. ***
Comment 7 Anastasius Focht 2013-12-04 04:47:04 UTC
Hello folks,

refining summary in hope it will avoid more duplicates...

Regards
Comment 8 Anastasius Focht 2013-12-04 04:51:21 UTC
Hello folks,

commit fd65b0a1c3f5f981cc110ca9e6a0edb6323e1296 should also be considered for cherry pick into stable branch if another 1.6.x happens before 1.8

Regards
Comment 9 Anastasius Focht 2013-12-04 06:08:36 UTC
Well, considering this rather unusual API usage breaks all existing Wine versions I'm still undecided whether this can be attributed to laziness or foul play.
MSDN is quite clear about it ...

Regards
Comment 10 babaei 2013-12-04 14:02:41 UTC
I built the latest version of Wine from the git repository with this patch (wine-1.7.7-160-g58d96f7), and I'm still experiencing a failure of the latest version of Steam to load. It was working well yesterday prior to the latest Steam update.

I tested fresh installing Steam from the executable to a new WINEPREFIX using wine-1.7.7-160-g58d96f7 and it still failed to load after the Steam Guard step.

With both 1.7.7 and wine-1.7.7-160-g58d96f7, it successfully loads into offline mode and shows the following version information:
Steam Client Application
Built: Dec 3 2013, at 18:36:49
Steam API: v012
Steam package versions: 1386125885/1386125885

I've posted details including a trace here. I can generate more specific debugging information if it could help.
http://appdb.winehq.org/commentview.php?iAppId=1163&iVersionId=19444&iThreadId=88676
Comment 11 Anastasius Focht 2013-12-04 14:14:37 UTC
Hello babaei,

the log from your link shows you have not built from 'pure' Wine GIT source tree.
You have several unsupported patches applied.

If you can still reproduce with 'pure' Wine create a new bug.
The original breaking issue from Dec. 03 client update has been identified and fixed -> bug closed.
Please refrain from continuing this bug with unrelated issues.

FYI: Several people can run Steam Dec. 03 update without problems in online mode.

Regards
Comment 12 babaei 2013-12-04 15:06:27 UTC
I can assure you that I built my system directly from the git repository without modifications and ran it directly from the source tree. I will open a new bug, but I don't want it to be flagged as a duplicate of this one.

I commented on this bug report because, in addition to not wanting to be flagged as a duplicate, I was still experiencing "Steam Client update from Dec. 3, 2013 breaks Wine" in spite of the fix.
Comment 13 Anastasius Focht 2013-12-04 15:23:21 UTC
Hello babaei,

well then this pulseaudio thingy must be my imagination ...

--- quote ---
Even with the release version of 1.7.7, I never saw it fail with a page fault (like in the linked bug).
--- quote ---

Which basically means your system is somehow borked (broken WINEPREFIX, host issues).
Every Wine version that received the Dec. 03 Steam Client update should crash the same way in 'online' mode.

To reiterate: any further bug reports at this time, stating "steam is broken" or "it still doesn't work" will definitely confuse _lots_ of people that are currently seeking help in many forums/mailing lists/entertainment websites.

Your problem seems to be an isolated issue.
There is #winehq IRC channel on freenode so join and we might work this one out without creating further confusion.

Regards
Comment 14 babaei 2013-12-04 16:11:54 UTC
*** Bug 35050 has been marked as a duplicate of this bug. ***
Comment 15 Anastasius Focht 2013-12-05 01:54:45 UTC
*** Bug 35051 has been marked as a duplicate of this bug. ***
Comment 16 Oleg 2013-12-05 11:58:45 UTC
Hello. 

Tell me please. Bug already fixed. Fix patch commited into main branch.
So. Does that fix (patch) will be included into 1.7.8 release?

Thanks. 
Oleg.
Comment 17 Bruno Jesus 2013-12-05 12:00:47 UTC
(In reply to comment #16)
> Tell me please. Bug already fixed. Fix patch commited into main branch.
> So. Does that fix (patch) will be included into 1.7.8 release?

Yes.
Comment 18 Oleg 2013-12-05 12:18:30 UTC
> Yes.

Thanks for your answer. 

p.s. I interested because I don't do dev team "string freeze" before release or no.

Thanks.
Oleg.
Comment 19 Justin la plante 2013-12-06 01:44:14 UTC
Created attachment 46752 [details]
Still crashes, reloads not working

Wine is still crashing after steam loads.  my previous report may have contained the first crash report which actually isnt a crash.  This is the second report which comes up after steam actually crashes.  I am attempting to load an older version of wine but ive been through several system re-installs to try and remedy the crash and nothing changes.
Comment 20 Nikolay Sivov 2013-12-06 01:55:54 UTC
(In reply to comment #19)
> Created attachment 46752 [details]
> Still crashes, reloads not working
> 
> Wine is still crashing after steam loads.  my previous report may have
> contained the first crash report which actually isnt a crash.  This is the
> second report which comes up after steam actually crashes.  I am attempting to
> load an older version of wine but ive been through several system re-installs
> to try and remedy the crash and nothing changes.

Why are you using old wine build (1.4.1)? Fix is only present in current dev branch, and will be included in release 1.7.8 (expected today). It makes no sense to try with older versions.
Comment 21 Alexandre Julliard 2013-12-06 13:44:38 UTC
Closing bugs fixed in 1.7.8.
Comment 22 Anastasius Focht 2013-12-07 11:20:22 UTC
*** Bug 35074 has been marked as a duplicate of this bug. ***
Comment 23 roland 2013-12-07 12:07:19 UTC
i was updated this morning to 1.7.8. still doesn't work
in peace
roland
Comment 24 Anastasius Focht 2013-12-07 12:24:14 UTC
Hello roland ,

--- quote ---
i was updated this morning to 1.7.8. still doesn't work in peace
roland
--- quote ---

there were already several occasions where people claimed "after the update steam still doesn't work for me", absolutely convinced they made no mistake - and in the end it turned out not being Wine's fault.

To all people who are inclined to post/comment here:

If the upgrade to Wine 1.7.8 didn't resolve the Steam problem, please go to WineHQ user support forums (http://forum.winehq.org/) and get help there.
Bugzilla is not meant for end user support.

Thanks.

Regards
Comment 25 Anastasius Focht 2013-12-08 16:24:13 UTC
*** Bug 35086 has been marked as a duplicate of this bug. ***
Comment 26 DenTaKu 2013-12-09 01:06:55 UTC
WIne 1.7.8 fixed this isuue (Steam starts again) - but now audio stutters in all games! :-(
Comment 27 Nikolay Sivov 2013-12-09 04:01:09 UTC
*** Bug 35091 has been marked as a duplicate of this bug. ***
Comment 28 Bruno Jesus 2013-12-09 09:55:18 UTC
*** Bug 35099 has been marked as a duplicate of this bug. ***
Comment 29 Matt 2013-12-15 00:39:27 UTC
Wine 1.7.8 is not fixing this bug for me.  I have frequent authentication failure hangs.  When I first install steam I can get in but can not download any games or verify the game cache.

After I log out of steam,  logging in again causes steam to fail during authentication.

Interestingly I get the same error prior to the 1.7.8 fix,
[1215/013422:ERROR:resource_bundle.cc(417)] Failed to load C:\Program Files (x86)\Steam\bin\chrome.pak
Some features may not be available.
fixme:iphlpapi:NotifyAddrChange (Handle 0x5e7d4d8, overlapped 0x5c974b0): stub
fixme:winsock:WSALookupServiceBeginW (0x5e7d5d8 0x00000ff0 0x5e7d620) Stub!
[1215/013422:ERROR:network_change_notifier_win.cc(126)] WSALookupServiceBegin failed with: 8


Just as a sanity check
wine --version
wine-1.7.8
Comment 30 Nikolay Sivov 2013-12-17 02:10:29 UTC
*** Bug 35148 has been marked as a duplicate of this bug. ***
Comment 31 Bruno Jesus 2013-12-18 04:52:23 UTC
*** Bug 35154 has been marked as a duplicate of this bug. ***
Comment 32 Bruno Jesus 2013-12-19 21:02:24 UTC
*** Bug 35183 has been marked as a duplicate of this bug. ***
Comment 33 Mark Eoberts 2013-12-30 00:07:17 UTC
(In reply to comment #20)
> (In reply to comment #19)
> > Created attachment 46752 [details]
> > Still crashes, reloads not working
> > 
> > Wine is still crashing after steam loads.  my previous report may have
> > contained the first crash report which actually isnt a crash.  This is the
> > second report which comes up after steam actually crashes.  I am attempting to
> > load an older version of wine but ive been through several system re-installs
> > to try and remedy the crash and nothing changes.
> 
> Why are you using old wine build (1.4.1)? Fix is only present in current dev
> branch, and will be included in release 1.7.8 (expected today). It makes no
> sense to try with older versions.

Wine 1.4.1 is the version that Ubuntu installs. Even after adding the ppa source lists, Ubuntu doesn't seem to update to newer versions of Wine. I'm using Ubuntu 13:10 and it still lists my version of Wine as 1.4.1. You may have found a solution to the problem, but The 12/03 update still has my version of Steam kiboshed. 

Mark
Comment 34 Ken Thomases 2013-12-30 00:08:47 UTC
*** Bug 35271 has been marked as a duplicate of this bug. ***
Comment 35 Scott Ritchie 2014-01-01 22:13:39 UTC
You need to install wine1.6 / wine1.7 packages after adding the PPA, it won't replace the wine1.4 package.
Comment 36 Anastasius Focht 2014-01-02 10:43:25 UTC
*** Bug 35295 has been marked as a duplicate of this bug. ***
Comment 37 Béla Gyebrószki 2014-01-02 23:36:45 UTC
*** Bug 35299 has been marked as a duplicate of this bug. ***
Comment 38 sovejohn 2014-01-03 18:57:34 UTC
Created attachment 47093 [details]
this is what the error says.

i have no clue what any of this means and it says on here that this was fixed but for me its not.
Comment 39 sovejohn 2014-01-03 19:03:03 UTC
this error keeps happining to me everytime i want to log into steam through wine. it gives me the login screen and after giving it my pass, steam sends me an email with a code to enter because apparently im useing a new computer. but after entering the code wine says somethings having serious issues and steam then closes. im not good with computers so i have absolutly no clue whats happining.anyone have any advice for me?
Comment 40 Anastasius Focht 2014-01-03 19:31:26 UTC
Hello sovejohn,

you need to upgrade to Wine 1.7.8 or newer.
If you don't know how to do that, please go to WineHQ user support forums (http://forum.winehq.org/) and get help there.

Bugzilla is not meant for end user support.

Thanks.

Regards
Comment 41 triangle400 2014-01-09 18:00:24 UTC
Ok, take 2...

I was going to post something about the bug, that i do get still, but i realised i'm using wine 1.6.1. I have something to look into before i get deeper into that. The fact remains that the "how to" on this bug mainly links here and here it mainly says to figure it out yourself...

TLDR, please elaborate in the "how to" on this bug as this does not contain user friendly instructions.
Comment 42 Austin English 2014-01-09 23:56:20 UTC
(In reply to comment #41)
> Ok, take 2...
> 
> I was going to post something about the bug, that i do get still, but i
> realised i'm using wine 1.6.1. I have something to look into before i get
> deeper into that. The fact remains that the "how to" on this bug mainly
> links here and here it mainly says to figure it out yourself...
> 
> TLDR, please elaborate in the "how to" on this bug as this does not contain
> user friendly instructions.

As it says in comment #40, you need to update to wine 1.7.8.
Comment 43 Alexandre Julliard 2014-01-10 14:46:49 UTC
Removing 1.6.x milestone from bugs included in 1.6.2.
Comment 44 Rosanne DiMesio 2014-02-23 14:01:13 UTC
*** Bug 35654 has been marked as a duplicate of this bug. ***
Comment 45 Rosanne DiMesio 2015-09-03 23:18:27 UTC
*** Bug 39202 has been marked as a duplicate of this bug. ***


Privacy Policy
If you have a privacy inquiry regarding this site, please write to [email protected]

Hosted By CodeWeavers