WineHQ Bugzilla – Bug 35028 – SPSS Legacy Viewer (SmartViewer 15) fails to install ("TempFolder" property reset by custom action)

Bugzilla

Last modified: 2014-01-03 13:10:07 UTC

SPSS Legacy Viewer (SmartViewer 15) fails to install ("TempFolder" property reset by custom action)

Bug 35028 - SPSS Legacy Viewer (SmartViewer 15) fails to install ("TempFolder" property reset by custom action)


Summary:	SPSS Legacy Viewer (SmartViewer 15) fails to install ("TempFolder" property r...

Status:	CLOSED FIXED

AppDB:	Show Apps affected by this bug
Product:	Wine
Classification:	Unclassified
Component:	msi
Version:	1.7.7
Hardware:	x86 Linux

Importance:	P2 normal
Target Milestone:	---
Assigned To:	Mr. Bugs

URL:	http://www.rhul.ac.uk/it/faq/itfaqs/s...
Keywords:	download, Installer

Depends on:
Blocks:
	Show dependency tree

Reported:	2013-12-01 11:54 UTC by Anastasius Focht
Modified:	2014-01-03 13:10 UTC (History)
CC List:	0 users

See Also:
Regression SHA1:
Fixed by SHA1:	fcb924c1441f573fc6eabb2afcb44716de373e1c
Distribution:	---
Staged patchset:

Attachments
Add an attachment (back traces, logs, proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Anastasius Focht 2013-12-01 11:54:20 UTC

Hello folks,

trace log reveals it fails in some custom action "SPSSCheckLockingCriteria":

--- snip ---
...
0028:trace:msi:ACTION_CustomAction Handling custom action L"SPSSCheckLockingCriteria" (41 L"NewBinary39" L"ifCustomLocking")
...
0028:trace:msi:msi_get_property returning L"C:\\Program Files\\SPSS Viewer\\" for property L"TempFolder"
0028:Call KERNEL32.GetTempFileNameW(0033f0d8 L"C:\\Program Files\\SPSS Viewer\\",7ed2921a L"msi",00000000,0033eed0) ret=7ecaf796
0028:Ret  KERNEL32.GetTempFileNameW() retval=00000000 ret=7ecaf796
0028:trace:msi:create_temp_binary unable to create temp file L"" (267)
...
0028:err:msi:ITERATE_Actions Execution halted, action L"SPSSCheckLockingCriteria" returned 1627 
...
--- snip ---

It seems the "TempFolder" msi property has been set to a folder that doesn't exist hence GetTempFileNameW() fails (unique = 0).

Earlier in trace log:

--- snip ---
...
0028:trace:msi:msi_get_property returning L"C:\\users\\focht\\Temp\\" for property L"TempFolder"
0028:Call KERNEL32.GetTempFileNameW(0033f278 L"C:\\users\\focht\\Temp\\",7ed2921a L"msi",00000000,0033f070) ret=7ecaf796
0028:Ret  KERNEL32.GetTempFileNameW() retval=00002998 ret=7ecaf796 
...
0028:trace:msi:msi_get_property returning L"C:\\users\\focht\\Temp\\" for property L"TempFolder"
...
0028:trace:msi:msi_set_property 0x14bca0 L"TempFolder" L"C:\\users\\focht\\Temp\\" -1
...
0028:trace:msi:msi_resolve_target_folder L"TempFolder" resolves to L"C:\\users\\focht\\Temp\\"
...
006c:trace:msi:msi_resolve_target_folder resolving L"TempFolder"
...
006c:trace:msi:msi_set_property 0x14bca0 L"TempFolder" L"C:\\Program Files\\SPSS Viewer\\" -1
...
006c:trace:msi:msi_resolve_target_folder L"TempFolder" resolves to L"C:\\Program Files\\SPSS Viewer\\" 
...
<first snippet>
--- snip ---

tid 0x6c which resets "TempFolder" property is a custom action thread:

--- snip ---
0028:trace:msi:HANDLE_CustomType1 Calling function L"SetTARGETDIR" from L"C:\\users\\focht\\Temp\\msi4d0a.tmp" 
...
0028:trace:msi:wait_thread_handle waiting for L"ConfigureMFC71.E775FF93_F66D_4D6B_B08B_051E8B4371D4" 
...
006c:trace:msi:ACTION_CallDllFunction calling L"SetTARGETDIR" 
...
006c:Call msi.MsiSetTargetPathA(00000004,0922a18c "TARGETDIR",09c4e79c "C:\\Program Files\\SPSS Viewer\\") ret=092216cb 
...
--- snip ---

This could be one of the bugs which targets Wine insufficiency of not having a separate custom action server.
Like bug 18070 which needs the CA server for COM/MTA isolation.

Regards

Comment 1 Anastasius Focht 2013-12-01 11:55:47 UTC

Hello folks,

filling fields...

$ sha1sum spsslegacyviewer.zip 
1b57e81fb25c31f4ea98a552d7fb237928900cae  spsslegacyviewer.zip

$ du -sh spsslegacyviewer.zip 
57M	spsslegacyviewer.zip

$ wine --version
wine-1.7.7-230-g2507330

Regards

Comment 2 Anastasius Focht 2014-01-03 12:33:48 UTC

Hello folks,

this is fixed by commit http://source.winehq.org/git/wine.git/commitdiff/fcb924c1441f573fc6eabb2afcb44716de373e1c

Thanks Hans.

The installer reports success now despite some scary looking messages like:

--- snip ---
...
err:module:import_dll Library libifcoremd.dll (which is needed by L"C:\\PROG~FBU\\SPSS~F51\\SPSS~F51\\SPSS~F51\\SPSSIOCV.dll") not found
err:module:import_dll Library libmmd.dll (which is needed by L"C:\\PROG~FBU\\SPSS~F51\\SPSS~F51\\SPSS~F51\\SPSSIOCV.dll") not found
err:module:import_dll Library SPSSIOCV.dll (which is needed by L"C:\\PROG~FBU\\SPSS~F51\\SPSS~F51\\SPSS~F51\\SPSSCMN.dll") not found
err:module:import_dll Library SPSSCMN.dll (which is needed by L"C:\\PROG~FBU\\SPSS~F51\\SPSS~F51\\SPSS~F51\\SPSSGRPH.dll") not found
...
--- snip ---

I had a quick look in the installer .msi with ORCA .. those libs should be actually put into system32.

This might be a new msi bug.

Regards

Comment 3 Alexandre Julliard 2014-01-03 13:10:07 UTC

Closing bugs fixed in 1.7.10.