WineHQ Bugzilla – Bug 35024 – FEAR Combat (SEC2) v1.1 community full installer doesn't display cd key/serial field (no PIDTemplate property provided)

Bugzilla

Last modified: 2021-07-25 16:26:57 UTC

FEAR Combat (SEC2) v1.1 community full installer doesn't display cd key/serial field (no PIDTemplate property provided)

Bug 35024 - FEAR Combat (SEC2) v1.1 community full installer doesn't display cd key/serial field (no PIDTemplate property provided)


Summary:	FEAR Combat (SEC2) v1.1 community full installer doesn't display cd key/seria...

Status:	CLOSED FIXED

AppDB:	Show Apps affected by this bug
Product:	Wine
Classification:	Unclassified
Component:	msi
Version:	1.7.7
Hardware:	x86 Linux

Importance:	P2 normal
Target Milestone:	---
Assigned To:	Mr. Bugs

URL:	https://web.archive.org/web/201403050...
Keywords:	download, Installer

Depends on:
Blocks:
	Show dependency tree

Reported:	2013-11-30 16:08 UTC by Anastasius Focht
Modified:	2021-07-25 16:26 UTC (History)
CC List:	0 users

See Also:
Regression SHA1:
Fixed by SHA1:	3271b982632e7730d6cee373f4c9a4af37012036
Distribution:	---
Staged patchset:

Attachments
Screenshot showing invisible serial input field highlighed using Winspector (377.15 KB, image/png) 2013-11-30 16:15 UTC, Anastasius Focht	Details
View All Add an attachment (back traces, logs, proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Anastasius Focht 2013-11-30 16:08:08 UTC

Hello folks,

reported in WineHQ forums: http://forum.winehq.org/viewtopic.php?f=8&t=20420

This is not a dupe of bug 20456 ("FEAR's installer will not let me enter the serial number due to wrong font").

The field is not displayed at all.

Regards

Comment 1 Anastasius Focht 2013-11-30 16:10:14 UTC

Hello folks,

filling fields...

$ sha1sum fear_combat_110_community_en_full.exe 
53e38d3d11620b22d46ff2596f62fe4a11461e1c  fear_combat_110_community_en_full.exe

$ du -sh fear_combat_110_community_en_full.exe 
1.4G	fear_combat_110_community_en_full.exe

$ wine --version
wine-1.7.7-230-g2507330

Regards

Comment 2 Anastasius Focht 2013-11-30 16:15:56 UTC

Created attachment 46684 [details]
Screenshot showing invisible serial input field highlighed using Winspector

Hello folks,

attached is a screenshot which shows the invisible field highlighted using Spy++ like 'Winspector' tool (http://appdb.winehq.org/objectManager.php?sClass=application&iId=9148).
Right click the static field -> 'highlight' -> red rectangle will start to flash, indicating the control position.

Regards

Comment 3 Anastasius Focht 2013-11-30 17:42:47 UTC

Hello folks,

it seems the msi based installer uses a masked edit field for serial number but doesn't provide a "PIDTemplate" property.

"Control" table dumped with "ORCA":

--- snip ---
Dialog_	Control	Type	X	Y	Width	Height	Attributes	Property	Text	Control_Next	Help
...
CDKeyDlg	Title	Text	11	9	220	18	196611		{\Title}New Dialog	GlobalProgress	
CDKeyDlg	Next	PushButton	368	372	56	17	3		[ButtonText_Next]	Cancel	
CDKeyDlg	Back	PushButton	312	372	56	17	3		[ButtonText_Back]	Title	
CDKeyDlg	Cancel	PushButton	436	372	56	17	3		[ButtonText_Cancel]	Back	
CDKeyDlg	Background	Bitmap	0	0	525	395	1048577		[Background]	Next	
CDKeyDlg	CDKeyEdit	MaskedEdit	177	125	220	18	3	PIDKEY	[PIDTemplate]	Intro	
CDKeyDlg	Intro	Text	177	101	280	14	196611		{\Intro}Enter your FEAR-Community.org cd-key:	Text_1	
CDKeyDlg	GlobalProgress	Bitmap	14	88	14	86	1048577		[Collecting]	CollectingLabel	
CDKeyDlg	CollectingLabel	Text	35	90	104	11	65539		{\Labels}Collecting information	PreparingLabel	
CDKeyDlg	PreparingLabel	Text	35	114	104	11	65539		{\Labels}Preparing installation	InstallingLabel	
CDKeyDlg	InstallingLabel	Text	35	138	104	11	65539		{\Labels}Installing	FinalizingLabel	
CDKeyDlg	FinalizingLabel	Text	35	162	104	11	65539		{\Labels}Finalizing installation	CDKeyEdit	
CDKeyDlg	Text_1	Text	177	163	197	11	65539	TEXT_1_PROP_1_1_1	Note: A free cd-key can be obtained by registering at	Hyperlink_1	
CDKeyDlg	Hyperlink_1	Hyperlink	374	161	111	11	65539	HYPERLINK_1_PROP_1	<a href="http://fear-community.org">http://fear-community.org</a>	Background	
--- snip ---

Control in question: "CDKeyEdit"

Type: MaskedEdit
Attributes: 3
Property: PIDKEY
Text: [PIDTemplate]

Relevant trace log:

--- snip ---
...
0024:trace:msi:msi_get_property property L"PIDTemplate" not found
0024:trace:msi:msiobj_release object 0x1aada8 destroyed
0024:trace:msi:msi_dialog_parse_groups masked control, template L""
0024:trace:msi:msi_dialog_parse_groups 0 characters in 0 groups
0024:trace:msi:msi_dialog_add_control L"Static", L"CDKeyEdit", 00000003, L"[PIDTemplate]", 1002000d
0024:trace:msi:MSI_DatabaseOpenViewW L"SELECT * FROM `EventMapping` WHERE `Dialog_` = 'CDKeyDlg' AND `Control_` = 'CDKeyEdit'" 0x33f27c 
...
0024:trace:msi:msi_get_property property L"PIDTemplate" not found
0024:trace:msi:msiobj_release object 0x213ba0 destroyed
0024:trace:win:WIN_CreateWindowEx L"" L"Static" ex=00000000 style=5002000d 236,167 293x24 parent=0x5006c menu=(nil) inst=(nil) params=(nil)
0024:trace:win:dump_window_styles style: WS_CHILD WS_VISIBLE WS_GROUP 0000000d
0024:trace:win:dump_window_styles exstyle:
0024:trace:win:WIN_SetWindowLong 0x7006e -12 0 W 
...
0024:trace:win:WIN_CreateWindowEx created window 0x7006e
0024:trace:msi:dialog_create_window Dialog L"CDKeyDlg" control L"[PIDTemplate]" hwnd 0x7006e
0024:trace:win:WIN_SetWindowLong 0x7006e 0 50043 W
0024:trace:win:RedrawWindow 0x7006e whole window flags: RDW_INVALIDATE RDW_ERASE RDW_ALLCHILDREN RDW_UPDATENOW 
...
0024:trace:msi:msi_get_property returning L"1111-2222-3333-4444" for property L"PIDKEY"
0024:trace:msi:msiobj_release object 0x1aacf0 destroyed
0024:trace:msi:MSI_ViewFetch 0x1a12f8 0x33f3d0
0024:trace:msi:msi_view_get_row 0x129708 0x1aaec8 6 0x33f3d0
0024:trace:msi:msi_dialog_text_control 0x1a2060 0x1aacf0 
--- snip ---

I passed 'PIDKEY=1111-2222-3333-4444' property to msi installer by command line for better indication.
During debugging I injected a non-empty PIDTemplate and the field was shown.
Sadly modifying .msi with ORCA is not possible with Wine.

Regards

Comment 4 Anastasius Focht 2013-12-02 15:03:55 UTC

Hello folks,

this is fixed by commit http://source.winehq.org/git/wine.git/commitdiff/3271b982632e7730d6cee373f4c9a4af37012036

Thanks Hans.

The cd key/serial number input field is now properly shown.
Though I don't have a valid serial to check with.

Regards

Comment 5 Alexandre Julliard 2013-12-06 13:44:37 UTC

Closing bugs fixed in 1.7.8.

Comment 6 Alexandre Julliard 2014-01-10 14:46:39 UTC

Removing 1.6.x milestone from bugs included in 1.6.2.

Comment 7 Anastasius Focht 2021-07-25 16:26:57 UTC

Hello folks,

adding stable download via Internet Archive for documentation.

https://web.archive.org/web/20131114234049/http://fear-community.org/downloads/

https://web.archive.org/web/20140305012707/http://download2.fear-combat.org/fear_combat_110_community_en_full.exe

$ sha1sum fear_combat_110_community_en_full.exe 
53e38d3d11620b22d46ff2596f62fe4a11461e1c  fear_combat_110_community_en_full.exe

$ du -sh fear_combat_110_community_en_full.exe 
1.4G	fear_combat_110_community_en_full.exe

Regards