WineHQ Bugzilla – Bug 35006 – Foxit Reader 6.xx crashes on opening Help->About

Bugzilla

Last modified: 2021-01-31 07:03:10 UTC

Foxit Reader 6.xx crashes on opening Help->About

Bug 35006 - Foxit Reader 6.xx crashes on opening Help->About


Summary:	Foxit Reader 6.xx crashes on opening Help->About

Status:	CLOSED FIXED

AppDB:	Show Apps affected by this bug
Product:	Wine
Classification:	Unclassified
Component:	gdiplus
Version:	1.7.7
Hardware:	x86 Linux

Importance:	P2 normal
Target Milestone:	---
Assigned To:	Mr. Bugs

URL:	https://web.archive.org/web/201312060...
Keywords:	download, patch, regression

Depends on:
Blocks:
	Show dependency tree

Reported:	2013-11-27 00:19 UTC by Béla Gyebrószki
Modified:	2021-01-31 07:03 UTC (History)
CC List:	1 user (show)

See Also:
Regression SHA1:	f5d807b7d7f284e2037397007c73e5d73f77138f
Fixed by SHA1:	51b873b3ca03074698ab027f503acd7c1940ad80
Distribution:	---
Staged patchset:

Attachments
winedbg backtrace (22.91 KB, text/plain) 2013-11-27 00:19 UTC, Béla Gyebrószki	Details
+gdiplus log (13.99 KB, text/plain) 2013-11-27 00:20 UTC, Béla Gyebrószki	Details
gdiplus: Avoid deleting clip region twice in GdipDeleteGraphics (733 bytes, text/plain) 2013-11-27 22:03 UTC, Dmitry Timoshkov	Details
test program (C source) (1.84 KB, text/plain) 2014-01-03 13:52 UTC, Esme Povirk	Details
View All Add an attachment (back traces, logs, proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Béla Gyebrószki 2013-11-27 00:19:41 UTC

Created attachment 46651 [details]
winedbg backtrace

Steps to reproduce the problem:
1. create a new wineprefix, perform 'winetricks mfc42'
2. install FoxitReader611.1031_enu_Setup.exe, you don't have to install Google Chrome when the installer asks for it.
3. start the application, when it is fully loaded click on <Help> -> <About Foxit Reader>...the application crashes.

This is a regression from Wine 1.7.7:
f5d807b7d7f284e2037397007c73e5d73f77138f is the first bad commit
commit f5d807b7d7f284e2037397007c73e5d73f77138f
Author: Dmitry Timoshkov <dmitry@baikal.ru>
Date:   Tue Nov 12 18:16:28 2013 +0900

    gdiplus: Get rid of no longer needed path and region fields.

:040000 040000 558b0ce1cfc436a7db217c9a03fab0f51d4d373f 99e0d47084a781c7f8a0763dced1692b25d104bb M	dlls

Reverting the patch on wine-1.7.7-69-geb446e8 fixes the crash. Native gdiplus.dll also works around the crash.

Fedora 19
wine-1.7.7-69-geb446e8

Comment 1 Béla Gyebrószki 2013-11-27 00:20:29 UTC

Created attachment 46652 [details]
+gdiplus log

Comment 2 Dmitry Timoshkov 2013-11-27 01:17:24 UTC

(In reply to comment #0)
> This is a regression from Wine 1.7.7:
> f5d807b7d7f284e2037397007c73e5d73f77138f is the first bad commit
> commit f5d807b7d7f284e2037397007c73e5d73f77138f
> Author: Dmitry Timoshkov <dmitry@baikal.ru>
> Date:   Tue Nov 12 18:16:28 2013 +0900
> 
>     gdiplus: Get rid of no longer needed path and region fields.

I'd expect this patch be really a NOP, did you try to revert it?

Comment 3 Ken Thomases 2013-11-27 01:26:28 UTC

(In reply to comment #2)

> I'd expect this patch be really a NOP, did you try to revert it?

He said he did in the original post: "Reverting the patch on wine-1.7.7-69-geb446e8 fixes the crash."

Comment 4 Dmitry Timoshkov 2013-11-27 01:39:01 UTC

(In reply to comment #3)
> > I'd expect this patch be really a NOP, did you try to revert it?
> 
> He said he did in the original post: "Reverting the patch on
> wine-1.7.7-69-geb446e8 fixes the crash."

Yes, I saw it, just wanted to double check.

Comment 5 Dmitry Timoshkov 2013-11-27 22:03:34 UTC

Created attachment 46658 [details]
gdiplus: Avoid deleting clip region twice in GdipDeleteGraphics

It's a bug in application, it calls GdipDeleteGraphics twice. I don't know how
it worked before, probably due to slightly different memory layout. Attached
patch should avoid the crash.

Comment 6 Béla Gyebrószki 2013-11-28 01:35:19 UTC

(In reply to comment #5)
> Created attachment 46658 [details]
> gdiplus: Avoid deleting clip region twice in GdipDeleteGraphics
> 
> It's a bug in application, it calls GdipDeleteGraphics twice. I don't know how
> it worked before, probably due to slightly different memory layout. Attached
> patch should avoid the crash.

The patch works here as well..

Comment 7 Esme Povirk 2013-12-09 14:31:10 UTC

We should probably test whether deleting a Graphics object twice reports failure on Windows, and detect that if so.

Comment 8 Esme Povirk 2013-12-09 14:40:58 UTC

Although probably such a test cannot be added to Wine because it would involve accessing freed memory.

Comment 9 Esme Povirk 2014-01-03 13:52:32 UTC

Created attachment 47091 [details]
test program (C source)

Testing on Windows, the second free gives a error of ObjectBusy.

Comment 10 Dmitry Timoshkov 2014-01-07 21:02:15 UTC

Should be fixed by 51b873b3ca03074698ab027f503acd7c1940ad80.

Thanks Vincent.

Comment 11 Alexandre Julliard 2014-01-17 13:58:39 UTC

Closing bugs fixed in 1.7.11.