WineHQ
Bug Tracking Database – Bug 34969

 Bugzilla

 

Last modified: 2021-07-16 03:05:19 UTC  

wininet: In Trackmania Nations Forever new online user registration fails

Bug 34969 - wininet: In Trackmania Nations Forever new online user registration fails
wininet: In Trackmania Nations Forever new online user registration fails
Status: CLOSED FIXED
AppDB: Show Apps affected by this bug
Product: Wine
Classification: Unclassified
Component: wininet
1.7.3
x86 Linux
: P2 normal
: ---
Assigned To: Mr. Bugs
https://web.archive.org/web/202107160...
: download, regression
Depends on:
Blocks:
  Show dependency tree
 
Reported: 2013-11-21 11:15 UTC by Bernhard Übelacker
Modified: 2021-07-16 03:05 UTC (History)
1 user (show)

See Also:
Regression SHA1: c0e1dda04cce1192d477a831ece4b9e2c22353e9
Fixed by SHA1: a448bbf880ee27eaea87230823e52cfadd956230
Distribution: ---
Staged patchset:


Attachments
Bad run with WINEDEBUG=+wininet (relevant part) (48.38 KB, text/plain)
2013-11-21 11:17 UTC, Bernhard Übelacker
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Bernhard Übelacker 2013-11-21 11:15:57 UTC
Registration of a new online user is not possible in the step when one has to select the country.

A list of countries/zones is downloaded from trackmaniaforever.com.

This fails for some reason and a message appears: "Nicht verbunden" (Not connected)
Normally a selection screen with some countries to select from should be shown.

Up to wine version 1.7.2 this works.
It fails since 1.7.3.
(Also 1.6.1 is showing this error, while 1.6 did not.)

----------------

A Bisection leads to this commit:
c0e1dda04cce1192d477a831ece4b9e2c22353e9 is the first bad commit
commit c0e1dda04cce1192d477a831ece4b9e2c22353e9
Author: Hans Leidekker <hans@codeweavers.com>
Date:   Wed Sep 18 13:40:24 2013 +0200

    wininet: Don't assume that end of chunk means end of stream.

:040000 040000 650f003b8e695edca729ee0314980f24520272b5 511be5b85319511d9c2db7f978d6010d9ca5bc17 M      dlls

------------------

When comparing a good and a failing run with WINEDEBUG=+wininet it shows that the last call
to InternetReadFile returns FALSE in the bad run and TRUE in the good one.

------------------

When changing in dlls/wininet/http.c line 2817 (as of wine-1.7.6-180-g48ae431)
like it was before the commit above, download is also possible and zone selection is shown.

-    if(!chunked_stream->chunk_size || chunked_stream->chunk_size == ~0u) {
+    if(chunked_stream->chunk_size == ~0u) {

------------------

In the test suite the return value for the chunked test is not checked, but returns there also
not FALSE.

------------------

Attached is the relevant part of a run with WINEDEBUG=+wininet when it is failing.
The game installer tmnationsforever_setup.exe could be freely downloaded.
(Error is also not visible with native wininet.dll.)
Comment 1 Bernhard Übelacker 2013-11-21 11:17:23 UTC
Created attachment 46597 [details]
Bad run with WINEDEBUG=+wininet (relevant part)
Comment 2 Hans Leidekker 2013-11-21 12:32:41 UTC
This patch should fix it: http://source.winehq.org/patches/data/100606
Comment 4 Bernhard Übelacker 2013-11-22 07:08:37 UTC
Error is not visible anymore after the patch above in wine-1.7.6-241-g57d7f74.

(Andrew Eikum found it already before the bug report?)
(Problem is also in 1.6.1.)
Comment 5 Hans Leidekker 2013-11-22 07:15:39 UTC
Fixed by a448bbf880ee27eaea87230823e52cfadd956230.
Comment 6 Alexandre Julliard 2013-11-22 12:50:39 UTC
Closing bugs fixed in 1.7.7.


Privacy Policy
If you have a privacy inquiry regarding this site, please write to [email protected]

Hosted By CodeWeavers