WineHQ Bugzilla – Bug 34908 – TERA Online patcher fails to start

Bugzilla

Last modified: 2013-11-22 12:51:16 UTC

TERA Online patcher fails to start

Bug 34908 - TERA Online patcher fails to start


Summary:	TERA Online patcher fails to start

Status:	CLOSED FIXED

AppDB:	Show Apps affected by this bug
Product:	Wine
Classification:	Unclassified
Component:	winhttp
Version:	1.7.6
Hardware:	x86-64 Linux

Importance:	P2 normal
Target Milestone:	---
Assigned To:	Mr. Bugs

URL:	http://patch.tera.enmasse-game.com/TE...
Keywords:	download, regression

Depends on:
Blocks:
	Show dependency tree

Reported:	2013-11-14 14:45 UTC by Steffen Schröter
Modified:	2013-11-22 12:51 UTC (History)
CC List:	2 users (show)

See Also:
Regression SHA1:	92426b5136355200bfbc9561fcd9601ac130c66a
Fixed by SHA1:	e894c897d52c3e5852498164e246b473e0c6a786
Distribution:	---
Staged patchset:

Attachments
debug output, patcher does not work. (36.87 KB, text/plain) 2013-11-14 14:45 UTC, Steffen Schröter	Details
debug output, patcher works. (252.61 KB, text/plain) 2013-11-14 14:46 UTC, Steffen Schröter	Details
patch (933 bytes, patch) 2013-11-15 02:25 UTC, Hans Leidekker	Details \| Diff
View All Add an attachment (back traces, logs, proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Steffen Schröter 2013-11-14 14:45:41 UTC

Created attachment 46525 [details]
debug output, patcher does not work.

Since wine 1.7.6 the patcher of TERA Online (NA version) no longer starts (it just exits without any error). This is caused by commit 92426b5136355200bfbc9561fcd9601ac130c66a. After reverting only this commit the patcher works again.

The game can be downloaded for free: http://patch.tera.enmasse-game.com/TERA-Setup.exe. This will install the patcher.

Comment 1 Steffen Schröter 2013-11-14 14:46:16 UTC

Created attachment 46526 [details]
debug output, patcher works.

Comment 2 Steffen Schröter 2013-11-14 14:49:55 UTC

I attached two log files with debug output (+relay,+winhttp) grepped for "winhttp" to reduce the size. One is with this commit (patcher not working) and the other one is with the problematic commit reverted (patcher working).

Comment 3 treeki 2013-11-14 17:06:34 UTC

Hi,

I can confirm this regression in some software I work on. I cannot provide a download link as it's unreleased proprietary software, but I've done some exhaustive debugging and I'm extremely confident that this is the cause. Our HTTP code works perfectly when WINE commit 92426b5136355200bfbc9561fcd9601ac130c66a is reverted, but fails almost instantly when that commit is applied.

In my case, WinHttpQueryDataAvailable is reporting that more data is available than there really is. When I try to call WinHttpReadData, passing this amount, it appears to succeed but the extra data copied into the buffer is actually garbage -- whatever is located after read_buf inside request_t -- and after a couple of reads, QueryDataAvailable sends a callback saying there's 0 bytes available.

There doesn't seem to be any reliable way to detect or work around this bug.

Comment 4 Hans Leidekker 2013-11-15 02:25:16 UTC

Created attachment 46531 [details]
patch

Does this patch help?

Comment 5 Steffen Schröter 2013-11-15 12:07:57 UTC

Yes with the patch applied it works.

Comment 6 Bruno Jesus 2013-11-15 15:41:39 UTC

Patch commited:
http://source.winehq.org/git/wine.git/commitdiff/e894c897d52c3e5852498164e246b473e0c6a786

Comment 7 Jacek Caban 2013-11-16 05:13:55 UTC

Fixed in Git.

Comment 8 Alexandre Julliard 2013-11-22 12:51:16 UTC

Closing bugs fixed in 1.7.7.