WineHQ Bugzilla – Bug 34804 – Installation of Windows Installer Cleanup utility fails due to wshom:WshShell3_ExpandEnvironmentStrings being a stub

Bugzilla

Last modified: 2021-12-12 05:30:30 UTC

Installation of Windows Installer Cleanup utility fails due to wshom:WshShell3_ExpandEnvironmentStrings being a stub

Bug 34804 - Installation of Windows Installer Cleanup utility fails due to wshom:WshShell3_ExpandEnvironmentStrings being a stub


Summary:	Installation of Windows Installer Cleanup utility fails due to wshom:WshShell...

Status:	CLOSED FIXED

AppDB:	Show Apps affected by this bug
Product:	Wine
Classification:	Unclassified
Component:	wshom.ocx
Version:	1.7.5
Hardware:	x86 Linux

Importance:	P2 normal
Target Milestone:	---
Assigned To:	Mr. Bugs

URL:	https://web.archive.org/web/201608210...
Keywords:	download, Installer

Depends on:
Blocks:
	Show dependency tree

Reported:	2013-10-26 09:01 UTC by Anastasius Focht
Modified:	2021-12-12 05:30 UTC (History)
CC List:	0 users

See Also:
Regression SHA1:
Fixed by SHA1:	71ecb55661a8cf14a0e19b94749f1d8957c9ab16
Distribution:	---
Staged patchset:

Attachments
patch (2.52 KB, patch) 2013-10-26 14:56 UTC, Nikolay Sivov	Details \| Diff
View All Add an attachment (back traces, logs, proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Anastasius Focht 2013-10-26 09:01:26 UTC

Hello folks,

as the summary says ...

While investigating .NET installer issues I tried to run the installer of "Windows Installer Cleanup utility" (MSICUU2.exe) mentioned in this blog:

http://blog.armgasys.com/?p=127

It fails:

--- snip ---
$ WINEDEBUG=+tid,+seh,+relay,+wshom wine ./msicuu2.exe >>log2.txt 2>&1
...
0026:trace:wshom:WshShell3_QueryInterface ({a6ef9860-c720-11d0-9337-00a0c90dcaa9}, 0x33f990)
0026:fixme:wshom:WshShell3_QueryInterface Unknown iface {a6ef9860-c720-11d0-9337-00a0c90dcaa9}
0026:trace:wshom:WshShell3_Invoke (1006 {00000000-0000-0000-0000-000000000000} 1033 3 0x33fa24 0x33fa70 0x33f970 0x33f96c)
...
0026:fixme:wshom:WshShell3_ExpandEnvironmentStrings (L"%ProgramFiles%" 0x33f000): stub
...
0026:trace:wshom:WshShell3_Release ()
--- snip ---

'winetricks -q wsh57' works around and the installer GUI is shown.

Source: http://source.winehq.org/git/wine.git/blob/5db4741d0b074ca0080adf36c3fdb440bf92f8d8:/dlls/wshom.ocx/shell.c#l740

--- snip ---
740 static HRESULT WINAPI WshShell3_ExpandEnvironmentStrings(IWshShell3 *iface, BSTR Src, BSTR* out_Dst)
741 {
742     FIXME("(%s %p): stub\n", debugstr_w(Src), out_Dst);
743     return E_NOTIMPL;
744 }
--- snip ---

The actual application 'msicuu.exe' later needs 'winetricks -q vb6run'.

Regards

Comment 1 Anastasius Focht 2013-10-26 09:02:32 UTC

Hello folks,

filling fields...

$ du -sh msicuu2.exe 
352K	msicuu2.exe
$ sha1sum msicuu2.exe 
23d3c4d0869769f424b1c0c54f18c50761ca2c14  msicuu2.exe

Regards

Comment 2 Nikolay Sivov 2013-10-26 14:56:10 UTC

Created attachment 46416 [details]
patch

Does this one work?

Comment 3 Nikolay Sivov 2013-10-27 02:43:03 UTC

Expansion works fine, but it don't see GUI anyway. With this patch wshom part exits cleanly but later on I get:

---
warn:vbscript:exec_script Failed 80020009
---

so probably wsh57 also gets you native vbscript, and next problem is about it. I'll dump a script to see what's that about.

Comment 4 Nikolay Sivov 2013-10-27 03:02:18 UTC

It turns out that next problem is about scrrun:

---
trace:scrrun:filesys_CopyFile 0x7e114e18 L"C:\\users\\nsivov\\Temp\\IXP000.TMP\\M*.*" L"C:\\Program Files" -1
trace:scrrun:copy_file copying L"C:\\users\\nsivov\\Temp\\IXP000.TMP\\msicuu.exe" to L"C:\\Program Files"
trace:scrrun:filesys_CopyFile ret 0x800a0046
trace:scrrun:filesys_Release 0x7e114e18
warn:vbscript:exec_script Failed 80020009
---

It fails with CTL_E_PERMISSIONDENIED, and you get native scrrun with wsh57 I think.

Comment 5 Nikolay Sivov 2013-10-28 17:38:49 UTC

ExpandEnvironmentStrings() method is implemented with 71ecb55661a8cf14a0e19b94749f1d8957c9ab16, please open another report for a next problem.

Comment 6 Anastasius Focht 2013-10-29 11:41:42 UTC

Hello folks,

fixed by commit http://source.winehq.org/git/wine.git/commitdiff/71ecb55661a8cf14a0e19b94749f1d8957c9ab16

Thanks Nikolay

Regards

Comment 7 Alexandre Julliard 2013-11-08 12:33:10 UTC

Closing bugs fixed in 1.7.6.

Comment 8 Alexandre Julliard 2014-01-10 14:46:36 UTC

Removing 1.6.x milestone from bugs included in 1.6.2.

Comment 9 Anastasius Focht 2021-12-12 05:30:30 UTC

Hello folks,

adding stable download link via Internet Archive for documentation.

https://web.archive.org/web/20160821044345/http://blog.armgasys.com/wp-content/downloads/msicuu2.exe

https://www.virustotal.com/gui/file/08565fe3a18e051f9f557c219a51844dbac4a6dee9076eb8ecfed2a3137a3fe8

$ sha1sum msicuu2.exe 
23d3c4d0869769f424b1c0c54f18c50761ca2c14  msicuu2.exe

$ du -sh msicuu2.exe 
352K	msicuu2.exe

Regards