WineHQ Bugzilla – Bug 34570 – Game crash because of improperly cloning MMIOINFO struct in MMIO_Open

Bugzilla

Last modified: 2013-11-15 13:40:16 UTC

Game crash because of improperly cloning MMIOINFO struct in MMIO_Open

Bug 34570 - Game crash because of improperly cloning MMIOINFO struct in MMIO_Open


Summary:	Game crash because of improperly cloning MMIOINFO struct in MMIO_Open

Status:	CLOSED FIXED

AppDB:	Show Apps affected by this bug
Product:	Wine
Classification:	Unclassified
Component:	winmm&mci
Version:	1.7.2
Hardware:	x86 Linux

Importance:	P2 normal
Target Milestone:	---
Assigned To:	Mr. Bugs

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree

Reported:	2013-09-22 02:13 UTC by jslu
Modified:	2013-11-15 13:40 UTC (History)
CC List:	0 users

See Also:
Regression SHA1:
Fixed by SHA1:	a0ed65f5937e6eb13f6b2b345d8d27fbd4616c32
Distribution:	---
Staged patchset:

Attachments
A quick fix (446 bytes, patch) 2013-09-22 02:13 UTC, jslu	Details \| Diff
View All Add an attachment (back traces, logs, proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description jslu 2013-09-22 02:13:38 UTC

Created attachment 46023 [details]
A quick fix

The game "Custom reido F" crashes on start. 

The problem is that the whole adwInfo[] array in MMIOINFO struct is used by the game, but wine only clones adwInfo[0] in MMIO_Open. A quick fix is attached.

What is more, I checked MSDN:
http://msdn.microsoft.com/en-us/library/windows/desktop/dd757322%28v=vs.85%29.aspx
and found that adwInfo[] array should have 4 elements instead of 3 in wine. This perhaps will cause problems in other programs. I am not sure which APIs are affected by this.

Comment 1 jslu 2013-09-22 04:31:05 UTC

The adwInfo[] array should have 3 elements. MSDN is wrong.

Comment 2 Dmitry Timoshkov 2013-09-23 19:42:45 UTC

Please send the patch to wine-patches: http://wiki.winehq.org/SubmittingPatches

Comment 3 jslu 2013-09-23 23:17:18 UTC

Thanks for reminding me. I have sent the patch to wine-patches.

Comment 4 Bruno Jesus 2013-09-25 14:26:03 UTC

Patch commited:
http://source.winehq.org/git/wine.git/?a=commit;h=a0ed65f5937e6eb13f6b2b345d8d27fbd4616c32

Comment 5 jslu 2013-09-25 19:33:19 UTC

Mark as fixed.

Comment 6 Alexandre Julliard 2013-09-27 13:41:30 UTC

Closing bugs fixed in 1.7.3.

Comment 7 Alexandre Julliard 2013-11-15 13:40:16 UTC

Removing 1.6.x milestone from bugs included in 1.6.1.