WineHQ Bugzilla – Bug 34496 – winhttp POST fails

Bugzilla

Last modified: 2013-11-15 13:40:14 UTC

winhttp POST fails

Bug 34496 - winhttp POST fails


Summary:	winhttp POST fails

Status:	CLOSED FIXED

AppDB:	Show Apps affected by this bug
Product:	Wine
Classification:	Unclassified
Component:	winhttp
Version:	1.7.1
Hardware:	x86 Linux

Importance:	P2 normal
Target Milestone:	---
Assigned To:	Mr. Bugs

URL:
Keywords:	download, patch, regression

Depends on:
Blocks:
	Show dependency tree

Reported:	2013-09-12 05:45 UTC by Ross Lagerwall
Modified:	2013-11-15 13:40 UTC (History)
CC List:	1 user (show)

See Also:
Regression SHA1:	bb3097f01e532583c8c78c9daf64ff29f8eb255c
Fixed by SHA1:	59b0374710ea735d71ceaa58fe2b311801160bc9
Distribution:	---
Staged patchset:

Attachments
Patch to fix the problem (1.11 KB, patch) 2013-09-14 04:59 UTC, Ross Lagerwall	Details \| Diff
View All Add an attachment (back traces, logs, proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Ross Lagerwall 2013-09-12 05:45:57 UTC

Since bb3097f01e532583c8c78c9daf64ff29f8eb255c, posting data with winhttp fails for me.

The test program from http://bugs.winehq.org/show_bug.cgi?id=29093 does not work anymore (no output shows and the request doesn't appear to complete).

This means that Numberwise (http://www.numberwise.com) does not work anymore.

commit bb3097f01e532583c8c78c9daf64ff29f8eb255c
Author: Hans Leidekker <hans@codeweavers.com>
Date:   Mon Mar 25 13:26:37 2013 +0100

    winhttp: Add a read-ahead buffer to allow WinHttpQueryDataAvailable to return the right values in chunked mode.
    
    This is a port of wininet commit 3d02c42b39c7346a97c41974418a6d01a29f9b81.

Thanks

Comment 1 Ross Lagerwall 2013-09-14 04:59:08 UTC

Created attachment 45948 [details]
Patch to fix the problem

Comment 2 Ross Lagerwall 2013-09-23 00:42:19 UTC

Ping.  Any chance of this being applied.  It seems like a fairly trivial fix for a regression...

Comment 3 Bruno Jesus 2013-09-23 07:29:41 UTC

Maybe this patch is related to it:
http://source.winehq.org/patches/data/99047

Comment 4 Ross Lagerwall 2013-09-23 09:47:44 UTC

Thanks for the headsup.  That does indeed seem to fix the problem since it reworks the query_data_available function where the bug was.  I'll close this when/if those patches hit master.

Comment 5 Bruno Jesus 2013-09-24 07:26:25 UTC

Patch commited:
http://source.winehq.org/git/wine.git/commitdiff/59b0374710ea735d71ceaa58fe2b311801160bc9

Comment 6 Alexandre Julliard 2013-09-27 13:41:21 UTC

Closing bugs fixed in 1.7.3.

Comment 7 Alexandre Julliard 2013-11-15 13:40:14 UTC

Removing 1.6.x milestone from bugs included in 1.6.1.