WineHQ Bugzilla – Bug 34472 – window titlebar names

Bugzilla

Last modified: 2014-01-10 14:46:20 UTC

window titlebar names

Bug 34472 - window titlebar names


Summary:	window titlebar names

Status:	CLOSED FIXED

AppDB:	Show Apps affected by this bug
Product:	Wine
Classification:	Unclassified
Component:	winemac.drv
Version:	1.7.1
Hardware:	x86-64 MacOS

Importance:	P2 trivial
Target Milestone:	---
Assigned To:	Mr. Bugs

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree

Reported:	2013-09-08 12:10 UTC by Rastafabi
Modified:	2014-01-10 14:46 UTC (History)
CC List:	1 user (show)

See Also:
Regression SHA1:
Fixed by SHA1:	771fcd894a62f53cb3862a9d97f28d2ce7c46a30
Distribution:	---
Staged patchset:

Attachments
Example image of the issue. (324.48 KB, image/png) 2013-09-08 12:10 UTC, Rastafabi	Details
Restore the window title. (837 bytes, patch) 2013-10-13 03:46 UTC, sevae	Details \| Diff
View All Add an attachment (back traces, logs, proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Rastafabi 2013-09-08 12:10:18 UTC

Created attachment 45899 [details]
Example image of the issue.

When ever I use the MacDriver while entering fullscreen the windows titlebar does not show the application/executable/file name anymore once I exit fullscreen. This happened to me for any fullscreen application I'm currently using. (AudioSurf, TrackMania United/Nations forever, Colin McRae Rally 2005, Beyond Good & Evil [GOG], etc…)
This happened to me ever since the introduction of the MacDriver. (1.5.?)

Comment 1 Ken Thomases 2013-09-08 14:10:14 UTC

Yeah, confirming. Cocoa seems to forget the window title when the window style is changed to no longer show a title bar. Then, when the style is changed back, it no longer has a title. The Mac driver will have to save the title separately and restore it.

Comment 2 sevae 2013-10-13 03:46:39 UTC

Created attachment 46282 [details]
Restore the window title.

Comment 3 Ken Thomases 2013-10-14 19:12:05 UTC

Curious.  I didn't expect it to be solvable so "locally".  I assumed that a window without a title bar simply couldn't have a title, so we would have to save it in an instance variable until the style changed back to titled.  Seems to work fine, though.

A few suggestions:

* The patch doesn't apply to current git.  The indenting is different.  (Perhaps you've re-indented your working copy because you hate the extra indenting that's in Wine?)

* I think it's best to copy the original title.  Your approach seems to be working but, given that Cocoa is losing the window's title, it may release the string it gave us.  Of course, if we copy it, we need to release it.  I suggest just [[... copy] autorelease] around what you've got.

* Submit it to wine-patches, since patches won't be picked up from the bug tracker.


If you're not interested in pursuing it, let me know and I can tweak and submit it.  Thanks.

Comment 4 Ken Thomases 2013-10-17 14:17:54 UTC

Fixed by http://source.winehq.org/git/wine.git/?a=commit;h=771fcd894a62f53cb3862a9d97f28d2ce7c46a30

Comment 5 Alexandre Julliard 2013-10-25 12:54:12 UTC

Closing bugs fixed in 1.7.5.

Comment 6 Alexandre Julliard 2014-01-10 14:46:20 UTC

Removing 1.6.x milestone from bugs included in 1.6.2.