WineHQ Bugzilla – Bug 34387 – TreeSize Free: help window won't open

Bugzilla

Last modified: 2014-01-10 14:46:43 UTC

TreeSize Free: help window won't open

Bug 34387 - TreeSize Free: help window won't open


Summary:	TreeSize Free: help window won't open

Status:	CLOSED FIXED

AppDB:	Show Apps affected by this bug
Product:	Wine
Classification:	Unclassified
Component:	hhctrl.ocx
Version:	1.5.15
Hardware:	x86 Linux

Importance:	P2 minor
Target Milestone:	---
Assigned To:	Erich E. Hoover

URL:	http://www.jam-software.com/freeware/
Keywords:	download, regression

Depends on:
Blocks:
	Show dependency tree

Reported:	2013-08-29 19:43 UTC by Béla Gyebrószki
Modified:	2014-01-10 14:46 UTC (History)
CC List:	1 user (show)

See Also:
Regression SHA1:	d1c363424d9ed028d44658bf3ca50a6eca2c7528
Fixed by SHA1:	87b1115db1aeb39d09fa5cdf349b1c0d6fea7d9f
Distribution:	---
Staged patchset:

Attachments
terminal output (3.46 KB, text/plain) 2013-08-29 19:43 UTC, Béla Gyebrószki	Details
View All Add an attachment (back traces, logs, proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Béla Gyebrószki 2013-08-29 19:43:28 UTC

Created attachment 45778 [details]
terminal output

When you press <F1> in the application nothing happens, the content of the help window is not opened. This is a regression from Wine 1.5.15:

d1c363424d9ed028d44658bf3ca50a6eca2c7528 is the first bad commit
commit d1c363424d9ed028d44658bf3ca50a6eca2c7528
Author: Erich Hoover <ehoover@mines.edu>
Date:   Wed Oct 3 09:19:53 2012 -0600

    hhctrl.ocx: Recognize the embedded window name for finding existing windows.

:040000 040000 eced520901d3ddbc85f9d7bcb77cd8c7af5592a0 58094979fecd6b5be47e9a356f750540393c470f M	dlls

wine-1.7.0-346-g1bf936c

TreeSizeFreeSetup.exe
md5sum: 7668b845a29e5529d50f27da78f3c288

Comment 1 Erich E. Hoover 2013-08-30 13:10:20 UTC

I'll take a look this weekend :)

Comment 2 Erich E. Hoover 2013-09-03 11:26:59 UTC

This appears to actually be a problem with HH_HELP_CONTEXT, it tries to find the TOC entry corresponding to id 0 and (when it fails to find one) it destroys the window.  Immediately after that a call is made that is successful (loading up a document), which is why it would have worked before (the original window gets destroyed but a new one is made that works).  So, I suspect that we need to have HH_HELP_CONTEXT not destroy the window when it fails to load an entry.

Comment 3 Erich E. Hoover 2013-11-07 14:19:33 UTC

This bug should be fixed by commit 87b1115db1aeb39d09fa5cdf349b1c0d6fea7d9f, sorry it took me so long to get around to this.

Comment 4 Béla Gyebrószki 2013-11-07 20:21:29 UTC

Fixed indeed, thank you.

Comment 5 Alexandre Julliard 2013-11-08 12:33:21 UTC

Closing bugs fixed in 1.7.6.

Comment 6 Alexandre Julliard 2014-01-10 14:46:43 UTC

Removing 1.6.x milestone from bugs included in 1.6.2.