WineHQ Bugzilla – Bug 34245 – WMI query "select * from win32_Directory" via WMI crashes

Bugzilla

Last modified: 2013-11-15 13:40:25 UTC

WMI query "select * from win32_Directory" via WMI crashes

Bug 34245 - WMI query "select * from win32_Directory" via WMI crashes


Summary:	WMI query "select * from win32_Directory" via WMI crashes

Status:	CLOSED FIXED

AppDB:	Show Apps affected by this bug
Product:	Wine
Classification:	Unclassified
Component:	wmi&wbemprox
Version:	1.7.0
Hardware:	x86 Linux

Importance:	P2 normal
Target Milestone:	---
Assigned To:	Mr. Bugs

URL:
Keywords:	patch

Depends on:
Blocks:
	Show dependency tree

Reported:	2013-08-10 06:59 UTC by lijing
Modified:	2013-11-15 13:40 UTC (History)
CC List:	0 users

See Also:
Regression SHA1:
Fixed by SHA1:	7da04aab6d0166005beb776f2135707fc57d716e
Distribution:	---
Staged patchset:

Attachments
All crash output from terminal (8.63 KB, text/plain) 2013-08-10 06:59 UTC, lijing	Details
patch (787 bytes, patch) 2013-08-10 07:47 UTC, Hans Leidekker	Details \| Diff
View All Add an attachment (back traces, logs, proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description lijing 2013-08-10 06:59:47 UTC

Created attachment 45570 [details]
All crash output from terminal

I wrote a simple program make a query of "select * from Win32_Directory" to WMI, and it crashes every time. But it works well on XP.
  And I find that it's caused by the funtion of seed_dirs(), in dlls/wbemprox/builtin.c at line 1086, without checking if "const struct expr *cond" is NULL. So when it's NULL code "cond->u.expr.left" would lead to the crash.
  I found it on version 1.6 at first, and then downloaded v1.7 to install and the problem still exists.

Comment 1 Hans Leidekker 2013-08-10 07:47:44 UTC

Created attachment 45571 [details]
patch

Thanks, this patch should help.

Comment 2 lijing 2013-08-10 21:39:23 UTC

Thanks. It really works.

Comment 3 Bruno Jesus 2013-08-10 21:41:49 UTC

(In reply to comment #2)
> Thanks. It really works.

Thanks for testing. Bugs are marked as fixed when the patch is commited.

Comment 4 lijing 2013-08-10 21:45:24 UTC

(In reply to comment #3)
> (In reply to comment #2)
> > Thanks. It really works.
> 
> Thanks for testing. Bugs are marked as fixed when the patch is commited.
 Fine. Ana appreciate your work. ^_^

Comment 5 Hans Leidekker 2013-08-30 14:08:01 UTC

Fixed by 7da04aab6d0166005beb776f2135707fc57d716e.

Comment 6 Alexandre Julliard 2013-09-13 13:20:47 UTC

Closing bugs fixed in 1.7.2.

Comment 7 Alexandre Julliard 2013-11-15 13:40:25 UTC

Removing 1.6.x milestone from bugs included in 1.6.1.