WineHQ Bugzilla – Bug 34190 – number.c could not compile due to "dtoa" naming conflict in Cygwin

Bugzilla

Last modified: 2013-11-15 13:39:54 UTC

number.c could not compile due to "dtoa" naming conflict in Cygwin

Bug 34190 - number.c could not compile due to "dtoa" naming conflict in Cygwin


Summary:	number.c could not compile due to "dtoa" naming conflict in Cygwin

Status:	CLOSED FIXED

AppDB:	Show Apps affected by this bug
Product:	Wine
Classification:	Unclassified
Component:	build-env
Version:	1.6
Hardware:	x86-64 Windows

Importance:	P2 normal
Target Milestone:	---
Assigned To:	Mr. Bugs

URL:
Keywords:	patch, source

Depends on:
Blocks:
	Show dependency tree

Reported:	2013-08-01 21:56 UTC by Jasper Danielson
Modified:	2013-11-15 13:39 UTC (History)
CC List:	1 user (show)

See Also:
Regression SHA1:
Fixed by SHA1:	2e752a115ac814fc252af592d01c816b34e96cb0
Distribution:	---
Staged patchset:

Attachments
Add an attachment (back traces, logs, proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Jasper Danielson 2013-08-01 21:56:07 UTC

dlls/jscript/number.c could not compile on Cygwin (on Windows 7) due to a naming conflict of name "dtoa". Apparently the name "dtoa" was already used in wine/port.h

I was able to fix this issue and compile Wine properly by renaming all instances of "dtoa" and "DTOA" to "dtoaa" and "DTOAA", respectively, in the number.c file.

Comment 1 Ken Sharp 2013-08-03 10:56:29 UTC

Confirming.

Comment 2 Ken Sharp 2013-08-03 10:59:52 UTC

..except it's not defined in Wine's port.h it's inherited and defined in Cygwin's stdlib.h

http://forum.winehq.org/viewtopic.php?f=2&t=19501

Comment 3 Ken Sharp 2013-08-05 07:11:11 UTC

http://www.winehq.org/pipermail/wine-patches/2013-August/125701.html
http://source.winehq.org/patches/data/97774

Thanks Piotr :)

Comment 4 Austin English 2013-08-15 13:31:45 UTC

http://source.winehq.org/git/wine.git/commitdiff/2e752a115ac814fc252af592d01c816b34e96cb0

please retest

Comment 5 Jasper Danielson 2013-08-15 13:47:30 UTC

The number.c file now compiles with no problems, thank you.

Comment 6 Alexandre Julliard 2013-08-30 13:05:20 UTC

Closing bugs fixed in 1.7.1.

Comment 7 Alexandre Julliard 2013-11-15 13:39:54 UTC

Removing 1.6.x milestone from bugs included in 1.6.1.