WineHQ Bugzilla – Bug 34162 – CGDirectPaletteRef has been deprecated so winemac.drv can't be compiled in Mavericks.

Bugzilla

Last modified: 2013-11-15 13:39:39 UTC

CGDirectPaletteRef has been deprecated so winemac.drv can't be compiled in Mavericks.

Bug 34162 - CGDirectPaletteRef has been deprecated so winemac.drv can't be compiled in Mavericks.


Summary:	CGDirectPaletteRef has been deprecated so winemac.drv can't be compiled in Ma...

Status:	CLOSED FIXED

AppDB:	Show Apps affected by this bug
Product:	Wine
Classification:	Unclassified
Component:	winemac.drv
Version:	1.6
Hardware:	x86-64 MacOS

Importance:	P2 critical
Target Milestone:	---
Assigned To:	Mr. Bugs

URL:
Keywords:	patch

Depends on:
Blocks:
	Show dependency tree

Reported:	2013-07-29 23:46 UTC by Parahexen
Modified:	2013-11-15 13:39 UTC (History)
CC List:	2 users (show)

See Also:
Regression SHA1:
Fixed by SHA1:	4b24fce4e2390fbcc0e6ba8fc607595c3d05df02
Distribution:	---
Staged patchset:

Attachments
/System/Library/Frameworks/CoreGraphics.framework/Versions/A/Headers/CGDirectDisplay.h (deleted) 2013-08-08 16:21 UTC, Parahexen	Details
Avoid using display palette API (2.58 KB, patch) 2013-08-09 16:40 UTC, Ken Thomases	Details \| Diff
Show Obsolete (1) View All Add an attachment (back traces, logs, proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Parahexen 2013-07-29 23:46:51 UTC

gdi.c:144:5: error: use of undeclared identifier 'CGDirectPaletteRef'
    CGDirectPaletteRef palette;
    ^
gdi.c:190:5: error: use of undeclared identifier 'palette'
    palette = CGPaletteCreateWithDisplay(mainDisplay);
    ^
gdi.c:191:9: error: use of undeclared identifier 'palette'
    if (palette)
        ^
gdi.c:193:52: error: use of undeclared identifier 'palette'
        palette_size = CGPaletteGetNumberOfSamples(palette);
                                                   ^
gdi.c:194:26: error: use of undeclared identifier 'palette'
        CGPaletteRelease(palette);
                         ^
5 errors generated.
make[1]: *** [gdi.o] Error 1
make: *** [dlls/winemac.drv] Error 2
make: *** Waiting for unfinished jobs....

Comment 1 Ken Thomases 2013-08-08 16:07:00 UTC

Curious that it doesn't complain about the functions being undeclared.  Presumably the functions use some type to declare their parameter and return types.  I'll have to investigate.

It may also be that the right solution is to simply remove that code, since we don't properly deal with palette display modes, anyway.

Comment 2 Parahexen 2013-08-08 16:21:44 UTC

Created attachment 45553 [details]
/System/Library/Frameworks/CoreGraphics.framework/Versions/A/Headers/CGDirectDisplay.h

/usr/local/bin/gcc-4.2 -m32 -c -I. -I. -I../../include -I../../include  -D__WINESRC__  -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wempty-body -Wstrict-prototypes -Wwrite-strings -Wpointer-arith -fno-omit-frame-pointer -I/opt/X11/include -I/usr/include/libxml2 -Os -w -pipe -march=core2 -msse4 -mmacosx-version-min=10.9 -arch i386 -m32  -o main.o main.c
/usr/local/bin/gcc-4.2 -m32 -c -I. -I. -I../../include -I../../include  -D__WINESRC__  -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wempty-body -Wstrict-prototypes -Wwrite-strings -Wpointer-arith -fno-omit-frame-pointer -I/opt/X11/include -I/usr/include/libxml2 -Os -w -pipe -march=core2 -msse4 -mmacosx-version-min=10.9 -arch i386 -m32  -o clipping.o clipping.c
gdi.c:144:5: error: use of undeclared identifier 'CGDirectPaletteRef'
    CGDirectPaletteRef palette;
    ^
clang -m32 -c -I. -I. -I../../include -I../../include  -D__WINESRC__  -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wempty-body -Wstrict-prototypes -Wwrite-strings -Wpointer-arith -fno-omit-frame-pointer -I/opt/X11/include -I/usr/include/libxml2 -Os -w -pipe -march=core2 -msse4 -mmacosx-version-min=10.9 -arch i386 -m32  -o image.o image.c
gdi.c:190:5: error: use of undeclared identifier 'palette'
    palette = CGPaletteCreateWithDisplay(mainDisplay);
    ^
gdi.c:191:9: error: use of undeclared identifier 'palette'
    if (palette)
        ^
gdi.c:193:52: error: use of undeclared identifier 'palette'
        palette_size = CGPaletteGetNumberOfSamples(palette);
                                                   ^
gdi.c:194:26: error: use of undeclared identifier 'palette'
        CGPaletteRelease(palette);
                         ^
5 errors generated.
make[1]: *** [gdi.o] Error 1
make[1]: *** Waiting for unfinished jobs....

Comment 3 Parahexen 2013-08-08 16:24:13 UTC

additional info are shown on:

https://github.com/mxcl/homebrew/issues/21552
http://sourceforge.net/mailarchive/message.php?msg_id=31200911
http://ftp.cc.uoc.gr/mirrors/macports/release/ports/devel/libsdl/files/no-CGDirectPaletteRef.patch

ref to old file against the attachment,
https://github.com/mpc-hc/mpc-hc/blob/master/include/qt/CGDirectDisplay.h
line 59: typedef struct _CGDirectPaletteRef*     CGDirectPaletteRef;

Comment 4 Ken Thomases 2013-08-08 16:41:53 UTC

You can't attach Apple SDK files, especially from NDA'ed prerelease software, here.  Please delete that.

Comment 5 Austin English 2013-08-08 16:55:15 UTC

The content of attachment 45553 [details] has been deleted by
    Austin English <austinenglish@gmail.com>
who provided the following reason:

Copyrighted / nda

The token used to delete this attachment was generated at 2013-08-08 16:54:52 CDT.

Comment 6 Austin English 2013-08-08 16:55:35 UTC

(In reply to comment #4)
> You can't attach Apple SDK files, especially from NDA'ed prerelease software,
> here.  Please delete that.

Done

Comment 7 Ken Thomases 2013-08-09 16:40:20 UTC

Created attachment 45562 [details]
Avoid using display palette API

Here's a patch which should fix the problem.

Comment 8 Parahexen 2013-08-09 18:39:51 UTC

it works, thanks a lot.

Comment 9 Bruno Jesus 2013-08-09 19:16:04 UTC

(In reply to comment #8)
> it works, thanks a lot.

Bugs are marked as fixed when the patch is commited in git.

Comment 10 Bruno Jesus 2013-08-15 13:27:41 UTC

Patch commited:
http://source.winehq.org/git/wine.git/?a=commit;h=4b24fce4e2390fbcc0e6ba8fc607595c3d05df02

Comment 11 Alexandre Julliard 2013-08-30 13:05:05 UTC

Closing bugs fixed in 1.7.1.

Comment 12 Alexandre Julliard 2013-11-15 13:39:39 UTC

Removing 1.6.x milestone from bugs included in 1.6.1.