WineHQ Bugzilla – Bug 34142 – Nullsoft installer appearance is broken

Bugzilla

Last modified: 2013-11-15 13:39:34 UTC

Nullsoft installer appearance is broken

Bug 34142 - Nullsoft installer appearance is broken


Summary:	Nullsoft installer appearance is broken

Status:	CLOSED FIXED

AppDB:	Show Apps affected by this bug
Product:	Wine
Classification:	Unclassified
Component:	comctl32
Version:	1.6
Hardware:	x86 Linux

Importance:	P2 normal
Target Milestone:	---
Assigned To:	Mr. Bugs

URL:	http://download.nullsoft.com/winamp/c...
Keywords:	download, regression

Depends on:
Blocks:
	Show dependency tree

Reported:	2013-07-26 18:45 UTC by Artem S. Tashkinov
Modified:	2013-11-15 13:39 UTC (History)
CC List:	3 users (show)

See Also:
Regression SHA1:	9933f5e44639c5a3ca05c6ebe84032d5884573d1
Fixed by SHA1:	0ba24895f667db5b0cf397151f04518c50697007
Distribution:	---
Staged patchset:

Attachments
WinAMP 5.64 installer appearance (42.68 KB, image/png) 2013-07-26 18:45 UTC, Artem S. Tashkinov	Details
View All Add an attachment (back traces, logs, proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Artem S. Tashkinov 2013-07-26 18:45:36 UTC

Created attachment 45408 [details]
WinAMP 5.64 installer appearance

When you try to select/deselect components very strange things happen.

Comment 1 Frédéric Delanoy 2013-07-29 07:19:23 UTC

Please specify the last working version and perform a regression test (since you said it was a regression)

cf. http://wiki.winehq.org/RegressionTesting for info

Comment 2 Artem S. Tashkinov 2013-07-29 08:29:57 UTC

I've never installed this version of WinAMP so there's a chance it's not a regression but instead a new version of Nullsoft installer.

I'm currently unable to perform a regression test.

Comment 3 Béla Gyebrószki 2013-08-11 10:05:48 UTC

I can reproduce the problem in Wine 1.7.0.
This is a regression from 1.5.16:

9933f5e44639c5a3ca05c6ebe84032d5884573d1 is the first bad commit
commit 9933f5e44639c5a3ca05c6ebe84032d5884573d1
Author: Daniel Jelinski <djelinski1@gmail.com>
Date:   Thu Sep 27 21:06:48 2012 +0200

    comctl32: Do not send TVN_ITEMEXPANDING when expanding item with no children.

:040000 040000 41fc0d208e1ef86b7399bba32566c298e1984b3d e5a03648b0dbc4589961a6e4d66ef7a19780275b M	dlls

Native comctl32 is a workaround.

Comment 4 Bruno Jesus 2013-08-16 14:48:57 UTC

Patch commited:
http://source.winehq.org/git/wine.git/?a=commit;h=0ba24895f667db5b0cf397151f04518c50697007

Comment 5 Frédéric Delanoy 2013-08-16 15:29:27 UTC

Works with wine-1.7.0-73-ge3e1284

Comment 6 Alexandre Julliard 2013-08-30 13:04:59 UTC

Closing bugs fixed in 1.7.1.

Comment 7 Alexandre Julliard 2013-11-15 13:39:34 UTC

Removing 1.6.x milestone from bugs included in 1.6.1.