WineHQ Bugzilla – Bug 34034 – Locale settings broke shader program generator.

Bugzilla

Last modified: 2014-01-10 14:46:28 UTC

Locale settings broke shader program generator.

Bug 34034 - Locale settings broke shader program generator.


Summary:	Locale settings broke shader program generator.

Status:	CLOSED FIXED

AppDB:	Show Apps affected by this bug
Product:	Wine
Classification:	Unclassified
Component:	d3d
Version:	1.6-rc4
Hardware:	x86 Linux

Importance:	P2 normal
Target Milestone:	---
Assigned To:	Mr. Bugs

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree

Reported:	2013-07-13 05:53 UTC by Konrad Rzepecki
Modified:	2014-01-10 14:46 UTC (History)
CC List:	1 user (show)

See Also:
Regression SHA1:
Fixed by SHA1:	b73464a41337992c612e14035375c0da70d7eb36
Distribution:	---
Staged patchset:

Attachments
Add an attachment (back traces, logs, proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Konrad Rzepecki 2013-07-13 05:53:20 UTC

I've encountered today shader program compilation problems. The error is in following line:
PARAM yv12_coef = {0,666667, 0,166667, 0,833333, 0,333333};

This program was generated by wine itself: in arb_program_shader.c by code:
shader_addline(buffer, "PARAM yv12_coef = {%f, %f, %f, %f};\n", 2.0f / 3.0f, 1.0f / 6.0f, (2.0f / 3.0f) + (1.0f / 6.0f), 1.0f / 3.0f);

The problem is that in polish locale (and others probably to), decimal separator is a comma not a dot.

The shader_(v)addline should use "C" locale for program generations (best) or this line above should have %f replaced by counted values.

Comment 1 Ken Sharp 2013-07-13 17:27:38 UTC

What is the application?
http://www.winehq.org/docs/wineusr-guide/bug-reporting

Comment 2 Konrad Rzepecki 2013-07-14 12:05:48 UTC

GTA III SA from steam, but IT DOESN'T MATTER. I show exactly point where it's, and why it's a bug.

Comment 3 Henri Verbeet 2013-07-15 02:51:20 UTC

We should probably move shader_glsl_ftoa() to the common code and use it in arb_program_shader.c as well. Ideally we wouldn't need to use the ARB_program code for blitting when GLSL is used though.

Comment 4 Henri Verbeet 2013-11-21 12:01:21 UTC

I believe this should be fixed by commit b73464a41337992c612e14035375c0da70d7eb36. Please reopen if that's not the case.

Comment 5 Alexandre Julliard 2013-11-22 12:51:12 UTC

Closing bugs fixed in 1.7.7.

Comment 6 Alexandre Julliard 2014-01-10 14:46:28 UTC

Removing 1.6.x milestone from bugs included in 1.6.2.