WineHQ Bugzilla – Bug 34013 – Altium Designer 10 and its installer crash in InternetQueryOptionW

Bugzilla

Last modified: 2013-11-15 13:40:37 UTC

Altium Designer 10 and its installer crash in InternetQueryOptionW

Bug 34013 - Altium Designer 10 and its installer crash in InternetQueryOptionW


Summary:	Altium Designer 10 and its installer crash in InternetQueryOptionW

Status:	CLOSED FIXED

AppDB:	Show Apps affected by this bug
Product:	Wine
Classification:	Unclassified
Component:	wininet
Version:	1.6-rc4
Hardware:	x86 Linux

Importance:	P2 normal
Target Milestone:	---
Assigned To:	Mr. Bugs

URL:	http://altium.com
Keywords:	Installer, patch, regression

Depends on:
Blocks:
	Show dependency tree

Reported:	2013-07-12 00:29 UTC by Dan Kegel
Modified:	2013-11-15 13:40 UTC (History)
CC List:	0 users

See Also:
Regression SHA1:	bedf296a27d5689beb693637407829b0bd6d8a1c
Fixed by SHA1:	0c9321eb0f45ca3cd32da116b74c205e7b2127da
Distribution:	---
Staged patchset:

Attachments
half-assed patch to show what a fix might look like (837 bytes, patch) 2013-07-12 00:31 UTC, Dan Kegel	Details \| Diff
View All Add an attachment (back traces, logs, proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Dan Kegel 2013-07-12 00:29:35 UTC

After doing 'winetricks vd=1024x768' to work around bug 34012,
continued with Altium Designer install.  Next problem was
it refused to accept my username and password.

+relay,+seh,+wininet showed that it was crashing in InternetQueryOptionW()
somehow.  The installer caught the crash, so there was no backtrace, but it
did give the address in the gui and said it was a read from NULL.
Passing that address to winedbg's disasm pointed to str_to_buffer().
The option it was retrieving was INTERNET_OPTION_PROXY_USERNAME; 
evidently req->session->appInfo->proxyUsername was null.

This may be a regression introduced by the recent commit
bedf296a27d5689beb693637407829b0bd6d8a1c

The attached patch gets past this problem and on to the next.

Comment 1 Dan Kegel 2013-07-12 00:31:24 UTC

Created attachment 45197 [details]
half-assed patch to show what a fix might look like

Comment 2 Dan Kegel 2013-07-14 08:12:55 UTC

Also prevents installed app from signing in;
the half-assed patch is good enough there, too.

Comment 3 Dan Kegel 2013-07-31 16:42:05 UTC

Should be fixed by
http://www.winehq.org/pipermail/wine-cvs/2013-July/096448.html
I'll test when I get a chance.

Comment 4 Dan Kegel 2013-07-31 21:21:19 UTC

Fixed.

Comment 5 Alexandre Julliard 2013-08-02 13:19:02 UTC

Closing bugs fixed in 1.7.0.

Comment 6 Alexandre Julliard 2013-11-15 13:40:37 UTC

Removing 1.6.x milestone from bugs included in 1.6.1.