WineHQ Bugzilla – Bug 33963 – WINE Wordpad crashes when selecting text from line end to line start

Bugzilla

Last modified: 2014-01-10 14:46:21 UTC

WINE Wordpad crashes when selecting text from line end to line start

Bug 33963 - WINE Wordpad crashes when selecting text from line end to line start


Summary:	WINE Wordpad crashes when selecting text from line end to line start

Status:	CLOSED FIXED

AppDB:	Show Apps affected by this bug
Product:	Wine
Classification:	Unclassified
Component:	richedit
Version:	1.6-rc4
Hardware:	x86-64 Linux

Importance:	P2 normal
Target Milestone:	---
Assigned To:	Mr. Bugs

URL:
Keywords:	download, patch, source

Depends on:
Blocks:
	Show dependency tree

Reported:	2013-07-05 12:23 UTC by Elias Vanderstuyft
Modified:	2014-01-10 14:46 UTC (History)
CC List:	4 users (show)

See Also:
Regression SHA1:
Fixed by SHA1:	b0f177b61913b9fac1cf8952582d77576705bad1
Distribution:	---
Staged patchset:

Attachments
Patch: Fixed wordpad crashing (906 bytes, patch) 2013-07-05 12:45 UTC, Qian Hong	Details \| Diff
View All Add an attachment (back traces, logs, proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Elias Vanderstuyft 2013-07-05 12:23:50 UTC

Steps to reproduce:
1. Compile the latest wine 1.6-rc4.
2. Run 'wine wordpad'.
3. Write one character, e.g. ' ' (space).
4. Select that character, by selecting from the line end (so immediately after the space) to the line start (before the space).

Then, it crashes and starts the debugger:
wine: Unhandled page fault on read access to 0x0000000c at address 0x7ac351f7 (thread 0009), starting debugger...

This was tested on Fedora 12 (32-bit wine) and on Fedora 18 (64-bit wine), both on 64bit linux (intel core i5).

Comment 1 Elias Vanderstuyft 2013-07-05 12:37:45 UTC

I just tested with wine-1.5.19, wine-1.5.18 and wine-1.3.22 (compiled 32bit wine) on Fedora 12 (64-bit),
and it does not crash on those.
So it is probably a regression.

I also noted that on the 'crashy' wordpad version, if you type a '\n' (newline) character in an empty document, and then make a selection from line 1 to line 2, the selected newline character appears to be much larger (looks like a tabulator) than on the earlier 'non-crashy' wordpad versions.

Comment 2 Qian Hong 2013-07-05 12:44:42 UTC

Confirming, I would say it is a richedit bug, you can try winetricks -q riched20.

Thanks for reporting :)

Comment 3 Qian Hong 2013-07-05 12:45:38 UTC

Created attachment 45115 [details]
Patch: Fixed wordpad crashing

It would be great if you have chance to test this patch :)

Comment 4 Elias Vanderstuyft 2013-07-06 13:10:11 UTC

(In reply to comment #3)
> Created attachment 45115 [details]
> Patch: Fixed wordpad crashing
> 
> It would be great if you have chance to test this patch :)

Nice, yes, that patch fixed it!

Comment 5 Nikolay Sivov 2013-07-06 13:49:21 UTC

Not fixed yet, patch is not in git.

Comment 6 Bruno Jesus 2013-07-06 16:29:51 UTC

Confirming then and adding keyword.

Comment 7 Qian Hong 2013-12-10 20:54:42 UTC

Fixed in git, thanks Huw Davies!

commit b0f177b61913b9fac1cf8952582d77576705bad1
Author: Huw Davies <huw@codeweavers.com>
Date:   Tue Dec 10 11:19:08 2013 +0000

    riched20: Ensure the cursors are correctly ordered in the case of a zero (logical) length selection bridging two runs.

Comment 8 Alexandre Julliard 2013-12-20 12:42:56 UTC

Closing bugs fixed in 1.7.9.

Comment 9 Alexandre Julliard 2014-01-10 14:46:21 UTC

Removing 1.6.x milestone from bugs included in 1.6.2.