WineHQ
Bug Tracking Database – Bug 33895

 Bugzilla

 

Last modified: 2013-12-20 12:43:45 UTC  

Tomb Raider 2013 mouse does not work with the changes made to the winemac.drv in the version 1.5.30

Bug 33895 - Tomb Raider 2013 mouse does not work with the changes made to the winemac.drv in the version 1.5.30
Tomb Raider 2013 mouse does not work with the changes made to the winemac.drv...
Status: CLOSED FIXED
AppDB: Show Apps affected by this bug
Product: Wine
Classification: Unclassified
Component: winemac.drv
1.5.30
x86-64 MacOS
: P2 normal
: ---
Assigned To: Mr. Bugs
: patch, regression
Depends on:
Blocks:
  Show dependency tree
 
Reported: 2013-06-26 13:36 UTC by Exzo
Modified: 2013-12-20 12:43 UTC (History)
3 users (show)

See Also:
Regression SHA1: 3e3d982185c62020b7478f433486ade19378ed6e
Fixed by SHA1: 77f0a63b4fce90e4a35393eb16468f11a922ea3a
Distribution: ---
Staged patchset:


Attachments
upload by Felix Hädicke (5.25 KB, patch)
2013-06-26 14:10 UTC, Exzo
Details | Diff
patch 2 (3.33 KB, patch)
2013-06-26 16:48 UTC, Exzo
Details | Diff
revert for Prefer absolute mouse moves unless cursor is pinned by clipping or desktop edges. (5.05 KB, patch)
2013-06-27 16:16 UTC, Exzo
Details | Diff
Don't discard mouse-move events until catch up to SetCursorPos time (948 bytes, patch)
2013-07-10 11:30 UTC, Ken Thomases
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Exzo 2013-06-26 13:36:39 UTC
Before the version 1.5.30 To play Tomb Raider 2013 was consisting of applying the small one patch and the game was working perfectly. But with the changes made to the winemac.drv in the version 1.5.30 now the mouse does not work when I use the mac driver in Tomb Raider 2013. My temporary solution is to compile a recent version but using the winemac.drv folder from the version 1.5.29 that way the mouse works perfectly.
Comment 1 Bruno Jesus 2013-06-26 13:56:21 UTC
What small patch are you talking about? There have been a lot of changes since to the mac driver since wine 1.5.30, please retry in wine 1.6-rc3.
Comment 2 Exzo 2013-06-26 14:10:29 UTC
Created attachment 44992 [details]
upload by Felix Hädicke
Comment 3 Exzo 2013-06-26 14:13:48 UTC
The patch I'm talking about is the one above. As for the version, I've tried all from 1.5.30, 1.5.31, 1.6-rc1,2,3 and no mouse solves the problem in winemac.drv
Comment 4 Bruno Jesus 2013-06-26 14:26:17 UTC
Please run a regression test:
http://wiki.winehq.org/RegressionTesting
Comment 5 Ken Thomases 2013-06-26 15:27:00 UTC
Have you tried just using Wine with no extra patches? It's possible that the changes I made to the Mac driver improved compatibility with the game without the need to disable SetCursorPos() (which is what that patch does, mostly).
Comment 6 Exzo 2013-06-26 16:48:54 UTC
Created attachment 44994 [details]
patch 2

I cleaned the patch up to where one could but without the sync2 the game does not work. But in spite of the cleanliness the mouse still does not work. Estava pretty sure it was not the patch because when i use the winemac.drv from 1.5.29 in the version 1.6-rc3 the mouse works fine
Comment 7 Exzo 2013-06-26 17:02:49 UTC
It is funny because with the new patch now happened the same thing happens with mac driver happened with X11. the mouse has stopped working
Comment 8 Exzo 2013-06-26 18:27:37 UTC
When I say that the mouse does not work what I mean is that when I try to give a complete turn it does only to one side and the other side it does so only half.
Comment 9 Ken Thomases 2013-06-26 18:59:26 UTC
What happens if you set MouseWarpOverride=disable as per <http://wiki.winehq.org/UsefulRegistryKeys>?
Comment 10 Exzo 2013-06-26 19:48:56 UTC
I just did the test with a recently compiled 1.6-rc3 engine with the sync2 patch only, using MouseWarpOverride=disable and the mouse still the same.
Comment 11 Ken Thomases 2013-06-26 20:16:42 UTC
If I understand your description of the problem, when you move the mouse continually in one direction, the game character stops turning at some point.  Is that right?  If so, then try MouseWarpOverride=force instead.
Comment 12 Exzo 2013-06-26 21:00:18 UTC
Using MouseWarpOverride=force the mouse still same.

Yes, when I move the mouse against-clockwise, the camera turns around the character without any problem, could be doing it all day. But when I move the mouse in pro-clockwise gives only half of a turn, the game character stops turning. But it only happens from version 1.5.30 onwards.
Comment 13 Ken Thomases 2013-06-26 22:24:11 UTC
OK, thanks for clarifying the symptom.  That's a weird symptom I haven't heard of before.  Please perform a regression test as suggested by Bruno in comment 4.
Comment 14 Exzo 2013-06-27 16:16:11 UTC
Created attachment 45001 [details]
revert for Prefer absolute mouse moves unless cursor is pinned by clipping or desktop edges.

I finally found the error. I carry a good time doing revert to the motor until I found the problem. It's all because of this patch.

http://source.winehq.org/git/wine.git/commitdiff/3e3d982185c62020b7478f433486ade19378ed6e

Also I leave a patch for the 1.6-rc3 where I did a revert to that patch and the game now works better than ever.
Comment 15 Ken Thomases 2013-07-10 11:30:00 UTC
Created attachment 45181 [details]
Don't discard mouse-move events until catch up to SetCursorPos time

Instead of reverting that commit, could you try applying the attached patch and see if that helps?
Comment 16 Exzo 2013-07-10 18:08:06 UTC
(In reply to comment #15)
> Created attachment 45181 [details]
> Don't discard mouse-move events until catch up to SetCursorPos time
> 
> Instead of reverting that commit, could you try applying the attached patch and
> see if that helps?

Thanks for the patch, but unfortunately does not work, still the same problem with the patch.
Comment 17 Ken Thomases 2013-07-11 07:47:36 UTC
OK, thanks for testing.
Comment 18 Ken Thomases 2013-12-16 19:52:53 UTC
There's a slim chance that <http://source.winehq.org/patches/data/101087> might help with this.
Comment 19 Exzo 2013-12-16 20:52:19 UTC
Man, thanks for this patch finally the game works perfectly. you are awesome
Comment 20 Ken Thomases 2013-12-16 22:15:45 UTC
Oh, good!  I'm glad that patch fixes the problem.  Thanks for testing!
Comment 21 Ken Thomases 2013-12-17 17:46:24 UTC
The fix has been committed: http://source.winehq.org/git/wine.git/?a=commit;h=77f0a63b4fce90e4a35393eb16468f11a922ea3a
Comment 22 Exzo 2013-12-17 18:09:33 UTC
Thanks for your hard work
Comment 23 Alexandre Julliard 2013-12-20 12:43:45 UTC
Closing bugs fixed in 1.7.9.


Privacy Policy
If you have a privacy inquiry regarding this site, please write to [email protected]

Hosted By CodeWeavers