WineHQ Bugzilla – Bug 33892 – IRecordInfo::RecordCopy() is broken

Bugzilla

Last modified: 2014-02-07 13:06:48 UTC

IRecordInfo::RecordCopy() is broken

Bug 33892 - IRecordInfo::RecordCopy() is broken


Summary:	IRecordInfo::RecordCopy() is broken

Status:	CLOSED FIXED

AppDB:	Show Apps affected by this bug
Product:	Wine
Classification:	Unclassified
Component:	oleaut32
Version:	1.6-rc3
Hardware:	x86-64 Linux

Importance:	P2 normal
Target Milestone:	---
Assigned To:	Mr. Bugs

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree

Reported:	2013-06-26 07:50 UTC by Rosen Diankov
Modified:	2014-02-07 13:06 UTC (History)
CC List:	1 user (show)

See Also:
Regression SHA1:
Fixed by SHA1:	60252ea65bbdf991938d919cd4c734809fb899bf
Distribution:	---
Staged patchset:

Attachments
Add an attachment (back traces, logs, proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Rosen Diankov 2013-06-26 07:50:51 UTC

the following function in oleaut32/recinfo.c

static HRESULT WINAPI IRecordInfoImpl_RecordCopy(IRecordInfo *iface, PVOID pvExisting, PVOID pvNew)

needs to copy stuff from pvExisting to pvNew, however it was doing the opposite!
The fix is simple, just do:

memcpy(pvNew, pvExisting, This->size);

Comment 1 Austin English 2013-06-26 13:15:45 UTC

Please send a patch. See http://wiki.winehq.org/SubmittingPatches for more info.

Comment 2 Alistair Leslie-Hughes 2013-09-08 05:34:22 UTC

Can you please resend your patch to the mailing list?

Comment 3 Rosen Diankov 2013-09-08 05:44:22 UTC

it's right here:

http://www.winehq.org/pipermail/wine-patches/2013-June/125059.html

Comment 4 Nikolay Sivov 2013-09-08 06:02:44 UTC

(In reply to comment #3)
> it's right here:
> 
> http://www.winehq.org/pipermail/wine-patches/2013-June/125059.html

Please resend it in git diff format, and add test case. If you don't have time for this please say so, this way your find will be less likely lost.

Comment 5 Nikolay Sivov 2014-01-14 03:31:32 UTC

Proposed patch is broken too, not that horribly, but still not what we need. I'm working on a proper fix.

Comment 6 Nikolay Sivov 2014-02-04 22:19:10 UTC

This is improved with 60252ea65bbdf991938d919cd4c734809fb899bf.

Comment 7 Alexandre Julliard 2014-02-07 13:06:48 UTC

Closing bugs fixed in 1.7.12.