WineHQ Bugzilla – Bug 33794 – Arabic Entry Box Has Big Errors .

Bugzilla

Last modified: 2013-11-15 13:40:29 UTC

Arabic Entry Box Has Big Errors .

Bug 33794 - Arabic Entry Box Has Big Errors .


Summary:	Arabic Entry Box Has Big Errors .

Status:	CLOSED FIXED

AppDB:	Show Apps affected by this bug
Product:	Wine
Classification:	Unclassified
Component:	usp10
Version:	1.5.31
Hardware:	x86 Linux

Importance:	P2 major
Target Milestone:	---
Assigned To:	Mr. Bugs

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree

Reported:	2013-06-13 07:27 UTC by Mosaab Alzoubi
Modified:	2013-11-15 13:40 UTC (History)
CC List:	2 users (show)

See Also:
Regression SHA1:
Fixed by SHA1:	3f4ef58b0fdb771ffacb64812c32aa625892a16f
Distribution:	---
Staged patchset:

Attachments
Screen shot of the bug . (667.62 KB, image/png) 2013-06-13 07:31 UTC, Mosaab Alzoubi	Details
New information ! (653.83 KB, image/png) 2013-06-14 15:50 UTC, Mosaab Alzoubi	Details
That's so better . (62.50 KB, image/png) 2013-09-12 01:09 UTC, Mosaab Alzoubi	Details
View All Add an attachment (back traces, logs, proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Mosaab Alzoubi 2013-06-13 07:27:55 UTC

When run wine at Arabic session the entry box has many problems as ::

1 - First it shown empty even it isn't empty .
2 - When try to write it shown reversed .
3 - Shaping false of Arabic letters .
4 - Spaces between letters are not organized .

When run wine at English session the entry box has a problem is ::

1 - Couldn't write in Arabic , show x11 drv keyboard error !

When run wine at Arabic session and Microsoft usp10.dll ::

1 - The entries shown at first time
2 - Arabic letters also don't organized !

Comment 1 Mosaab Alzoubi 2013-06-13 07:31:18 UTC

Created attachment 44785 [details]
Screen shot of the bug .

At name entry box I write : 

مصعب الزعبي 

At organization entry box I write :

مشروع ألماسه

Comment 2 Aric Stewart 2013-06-14 12:18:40 UTC

I have just started looking here but it is not a uniscribe issue. As the problem persists with native uniscribe as well as our builtin.

Comment 3 Mosaab Alzoubi 2013-06-14 15:39:10 UTC

When use native usp10 the default value (non Arabic) edit box text shown .

In wine usp10 don't shown !

So I think the usp10 has a work !

Comment 4 Mosaab Alzoubi 2013-06-14 15:50:06 UTC

Created attachment 44803 [details]
New information !

This is Firefox 21 setup tool :

Some wrongs : 

1 - At first line ( title ) (Mozilla Firefox) must align to left , it's shown right ! Also at second line .

2 - All next lines have a many spaces at first !!!

Comment 5 Aric Stewart 2013-06-14 20:53:09 UTC

(In reply to comment #3)
> When use native usp10 the default value (non Arabic) edit box text shown .
> 
> In wine usp10 don't shown !
> 
> So I think the usp10 has a work !

Sorry I don't quite understand.  Does using the native usp10 solve this problem for you?

Comment 6 Mosaab Alzoubi 2013-06-15 05:41:29 UTC

No it doesn't solve .

But it change one thing :


The default text ( which written in edit box at dialog start ) 

In native usp10 >>> It's shown
In wine usp10 >>> dosent shown 


!!!


All other problems shared ^_^

Comment 7 Aric Stewart 2013-06-19 07:12:24 UTC

I have found that this appears to be an issue with ExtTextOut when lpDX is specified.

Uniscribe (both native and builtin) give positive values for lpDx and when a DC has LAYOUT_RTL specified this cause ExtTextOut to really seriously miss-position the characters. 

Unfortunately I do not have time to do much more investigation here. Hopefully someone else familiar with ExtTextOut or LAYOUT_RTL can pick this up.

Comment 8 Mosaab Alzoubi 2013-06-19 07:40:23 UTC

Thank You Aric for your description .

-----------

Till anybody fix it , please confirm the bug .

Comment 9 Mosaab Alzoubi 2013-06-30 20:32:38 UTC

Thank you Aric .
I try your patch here http://source.winehq.org/patches/data/96984

Some points :

* At graphic section in winecfg , lately the values in ( virtual desktop size ) and ( dpi box ) shown .

* At entry boxes the default values shown again but having terrible spaces .

* At entry boxes Arabic letters contacts again , also terrible spaces .

Comment 10 Aric Stewart 2013-07-02 08:07:07 UTC

Chatting with Alexandre he tells me:

"the whole coordinate mapping in ExtTextOut needs to be redone it should be moved to the drivers, and work in device coords ... it won't happen during code freeze "

Comment 11 Mosaab Alzoubi 2013-07-02 16:12:22 UTC

I respect the decision , I still think solving more importance than freezing .Especially before stable version .

Thank For Your Attention .

Comment 12 Mosaab Alzoubi 2013-08-18 23:03:56 UTC

This patch solve about 50% of the bug . 

http://source.winehq.org/patches/data/96984

Please apply it .

Comment 13 Aric Stewart 2013-09-11 20:35:24 UTC

This should be resolved for non-truetype fonts. 

Commit: 4a300d2423d18abe915ad070b9611e72749dec4d
Author: Aric Stewart <aric@codeweavers.com>
Date:   Wed Sep 11 07:46:53 2013 -0500

gdi32: GetCharWidth32A/W return positive widths for all layouts and various DC transforms.

So you examples with winecfg will now be working.

Truetype fonts will still be broken until the ABC values patches is committed.

Comment 14 Mosaab Alzoubi 2013-09-12 01:09:09 UTC

Created attachment 45922 [details]
That's so better .

I built wine 1.7.1 wich patched by two new patches written by Aric .

http://source.winehq.org/patches/data/98724 (commited)
http://source.winehq.org/patches/data/98721 (still)

They solved this problem.

Thank You Very Much

Comment 15 Aric Stewart 2013-09-13 06:28:01 UTC

Ok this issue should now be fully resolved with this last commit.

commit 3f4ef58b0fdb771ffacb64812c32aa625892a16f
Author: Aric Stewart <aric@codeweavers.com>
Date:   Thu Sep 12 13:01:56 2013 -0500

    gdi32: ABC value signs remain the same despite any changes in layout direction or viewport.

Comment 16 Mosaab Alzoubi 2013-09-13 09:24:22 UTC

Thank You Very Very Much >

^_^

Comment 17 Bruno Jesus 2013-09-13 09:28:11 UTC

(In reply to comment #16)
> Thank You Very Very Much >
> 
> ^_^

Resolving fixed, using the second patch as Fixed SHA1.

Comment 18 Alexandre Julliard 2013-09-13 13:19:47 UTC

Closing bugs fixed in 1.7.2.

Comment 19 Alexandre Julliard 2013-11-15 13:40:29 UTC

Removing 1.6.x milestone from bugs included in 1.6.1.