WineHQ Bugzilla – Bug 32182 – GetResolvedNeutrals always returns input

Bugzilla

Last modified: 2014-01-17 13:58:57 UTC

GetResolvedNeutrals always returns input

Bug 32182 - GetResolvedNeutrals always returns input


Summary:	GetResolvedNeutrals always returns input

Status:	CLOSED FIXED

AppDB:	Show Apps affected by this bug
Product:	Wine
Classification:	Unclassified
Component:	usp10
Version:	1.5.17
Hardware:	x86-64 Linux

Importance:	P2 normal
Target Milestone:	---
Assigned To:	Mr. Bugs

URL:	http://source.winehq.org/git/wine.git...
Keywords:	source

Depends on:
Blocks:
	Show dependency tree

Reported:	2012-11-09 13:58 UTC by André Z.
Modified:	2014-01-17 13:58 UTC (History)
CC List:	2 users (show)

See Also:
Regression SHA1:
Fixed by SHA1:	de5dc96f85449ed3a9d58957e9401ea37bbf7613
Distribution:	---
Staged patchset:

Attachments
Add an attachment (back traces, logs, proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description André Z. 2012-11-09 13:58:34 UTC

coverity (CID 731561) spotted:
http://source.winehq.org/git/wine.git/blob/1262f07609e6722a841f511445f145d941848800:/dlls/usp10/bidi.c#l562

action is masked to 0x0f and compared to (1<<8), that won't ever happen.

The code comes from:

commit 032543e54dec387ae0089fe9e5dd0cc0fbc2d253
Author: Maarten Lankhorst <m.b.lankhorst@gmail.com>
Date:   Sat Sep 15 15:16:38 2007 +0200

    gdi: Implement neutrals resolving in BiDi.

Comment 1 André Z. 2013-06-30 07:56:17 UTC

Still in 1.6-rc4

Comment 2 Nikolay Sivov 2014-01-06 12:54:47 UTC

Looks like this code is gone thanks to http://source.winehq.org/git/wine.git/commit/de5dc96f85449ed3a9d58957e9401ea37bbf7613. I think it could be closed.

Comment 3 André Z. 2014-01-06 13:25:58 UTC

marking fixed

Comment 4 Alexandre Julliard 2014-01-17 13:58:57 UTC

Closing bugs fixed in 1.7.11.