WineHQ Bugzilla – Bug 31773 – Torchlight 2 shadows are rendered incorrectly on some areas

Bugzilla

Last modified: 2013-11-25 20:55:20 UTC

Torchlight 2 shadows are rendered incorrectly on some areas

Bug 31773 - Torchlight 2 shadows are rendered incorrectly on some areas


Summary:	Torchlight 2 shadows are rendered incorrectly on some areas

Status:	CLOSED FIXED

AppDB:	Show Apps affected by this bug
Product:	Wine
Classification:	Unclassified
Component:	d3d
Version:	1.5.13
Hardware:	x86-64 Linux

Importance:	P2 normal
Target Milestone:	---
Assigned To:	Mr. Bugs

URL:
Keywords:	patch

Depends on:
Blocks:
	Show dependency tree

Reported:	2012-09-24 03:35 UTC by Lauri Niskanen
Modified:	2013-11-25 20:55 UTC (History)
CC List:	9 users (show)

See Also:
Regression SHA1:
Fixed by SHA1:	e2cf98eb76b9c8451b5f9d25b0c9c07f9fdc4e04
Distribution:	---
Staged patchset:

Attachments
Screenshot about the bug (868.20 KB, image/jpeg) 2012-09-24 03:38 UTC, Lauri Niskanen	Details
Screenshot about the bug (637.75 KB, image/jpeg) 2012-09-24 03:38 UTC, Lauri Niskanen	Details
log +d3d,+d3d9,+d3dx9 (226.23 KB, application/x-bzip) 2012-10-15 19:30 UTC, Xavier Vachon	Details
Patch (3.25 KB, patch) 2013-07-05 15:56 UTC, Matteo Bruni	Details \| Diff
View All Add an attachment (back traces, logs, proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Lauri Niskanen 2012-09-24 03:35:43 UTC

Torchlight 2 shadows are renderer incorrectly on some areas. As a workaround disabling shadows works fine everywhere. On certain areas the shadows at very high setting are working well, but on other areas they look really bad.

There's a screenshot about the bug attached.

This bug has been reported to occur at least as early version as 1.5.0, but I tested this with 1.5.13. I was using NVIDIA binary drivers.

Comment 1 Lauri Niskanen 2012-09-24 03:38:22 UTC

Created attachment 41805 [details]
Screenshot about the bug

Comment 2 Lauri Niskanen 2012-09-24 03:38:44 UTC

Created attachment 41806 [details]
Screenshot about the bug

Comment 3 Lauri Niskanen 2012-09-24 03:44:17 UTC

Here's a short list of areas that are working just fine and areas that are bugged.

Working nicely:
- Zeryphesh
- The Ossean Wastes

Bugged shadows:
- Estherian Enclave
- The Temple Steppes
- The Frosted Hills

Comment 4 TestSubject 2012-09-27 09:49:49 UTC

I also get this in the Torchlight 2 demo. The shadows actually obscure a lot of the terrain. For instance, grassy areas get covered in blackness with shadows enabled.

Comment 5 Bruno Jesus 2012-09-27 09:52:44 UTC

Where did you download the demo? It will be easier for others to reproduce if they can test too.

Comment 6 joaopa 2012-09-27 11:00:54 UTC

A console output with d3dx and d3d9 channels enabled could help too.

Comment 7 TestSubject 2012-09-27 23:01:14 UTC

(In reply to comment #5)
> Where did you download the demo? It will be easier for others to reproduce if
> they can test too.

The demo is on Steam.

Comment 8 Matheus Maran 2012-09-29 07:52:52 UTC

(In reply to comment #7)
> (In reply to comment #5)
> > Where did you download the demo? It will be easier for others to reproduce if
> > they can test too.
> 
> The demo is on Steam.

It is also available at the official site of the game - http://www.torchlight2game.com

Comment 9 Xavier Vachon 2012-10-15 19:30:53 UTC

Created attachment 42147 [details]
log +d3d,+d3d9,+d3dx9

Per comment #6, here is a +d3d,+d3d9,+d3dx9 log tailed to 100000 lines (the log the game produced is about 1 GB, I'm not sure if this caught the issue..). I switched the shadow detail from off to very high, technically the faulty code should be exposed during that switch.

In the meantime, the workaround is to turn shadow detail to off. The game is very playable without them.

Comment 10 joaopa 2013-05-09 13:00:52 UTC

Is it possible to have a console output with d3dx and d3d9 channels enabled only?

Comment 11 K1773R 2013-07-04 07:21:14 UTC

(In reply to comment #10)
> Is it possible to have a console output with d3dx and d3d9 channels enabled
> only?
+d3d

Comment 12 Matteo Bruni 2013-07-05 15:56:02 UTC

Created attachment 45117 [details]
Patch

I had a look at this: it's a fog issue, actually the same as bug 27733. I'm attaching a patch that fixes the bug for me.

Notice that the fix only affects the GLSL vertex replacement pipeline, so you won't get the new behavior if you aren't using it (because of UseGLSL = disabled or a very old GPU, mostly).

I think this patch may be a bit too risky for Wine 1.6 so I'll probably wait for the release before submitting it.

Comment 13 Jerome Leclanche 2013-07-19 16:50:12 UTC

Confirming.

Are you resending, Matteo?

Comment 14 Matteo Bruni 2013-07-19 17:03:47 UTC

(In reply to comment #13)
> Confirming.
> 
> Are you resending, Matteo?

Yes, I plan to send the patch in the next few days. Ping me if I forget for any reason...

Comment 15 Jerome Leclanche 2013-08-02 15:47:17 UTC

(In reply to comment #14)
Ping ;)

Comment 16 Matteo Bruni 2013-08-03 09:51:22 UTC

(In reply to comment #15)
> (In reply to comment #14)
> Ping ;)

Err, thanks. Actually I sent the patch already (committed as e2cf98eb76b9c8451b5f9d25b0c9c07f9fdc4e04) but I forgot to comment here. It would be best if someone can doublecheck that this is fixed in Wine 1.7.0.

Comment 17 Jerome Leclanche 2013-08-18 20:20:15 UTC

Confirming fixed

Comment 18 Alexandre Julliard 2013-08-30 13:05:00 UTC

Closing bugs fixed in 1.7.1.

Comment 19 Alexandre Julliard 2013-11-15 13:39:36 UTC

Removing 1.6.x milestone from bugs included in 1.6.1.

Comment 20 Kevin Meyer 2013-11-24 14:40:28 UTC

Is this really fixed?


I just played around with Torchlight 2 and as far as I can tell, any option other than off is still horribly broken.
While previously there were blending artefacts from the shadows/lighting, now there simply isn't any shadows or lighting to speak off.
It's just the same dull uniform shade applied to all world geometry.

http://i.imgur.com/kT0Vdl3.jpg basically all areas look like this with some being brighter

Wine: 1.7.7 (8814727ac9f09eb372d9ca9617dc4ced9872ffa6)
Driver: Nvidia 331.20

Comment 21 TestSubject 2013-11-24 15:03:14 UTC

Kevin Meyer, it really is fixed. You need to have GLSL shaders enabled in regedit. The shadows won't work properly without that being on, and you need wine 1.7.1 at least.

Comment 22 Kevin Meyer 2013-11-24 21:28:19 UTC

But I meet both those requirements, Wine 1.7.7 + 100% default Direct3D settings (read: useGLSL enabled) w/ NO native d3d9 overrides.

And there iareNO lighting or shadows anywhere, it's not even glitchy like it used to be, it's just  completely absent. I can't state this any more clearly than the above screenshot shows.

Comment 23 Matteo Bruni 2013-11-25 12:36:50 UTC

(In reply to comment #20)
> Wine: 1.7.7 (8814727ac9f09eb372d9ca9617dc4ced9872ffa6)
> Driver: Nvidia 331.20

There is a bug in Nvidia 331.xx drivers which might be related. Does it make any difference if you downgrade to 325.xx?

Comment 24 Kevin Meyer 2013-11-25 20:55:20 UTC

That's going to be difficult with Arch...
I'll let you know what happens if I manage a successful downgrade, but if it's working for others that is probably the case.