WineHQ Bugzilla – Bug 29846 – HTML-Kit 292 can't show any plugin previews except the default

Bugzilla

Last modified: 2014-03-07 14:12:59 UTC

HTML-Kit 292 can't show any plugin previews except the default

Bug 29846 - HTML-Kit 292 can't show any plugin previews except the default


Summary:	HTML-Kit 292 can't show any plugin previews except the default

Status:	CLOSED FIXED

AppDB:	Show Apps affected by this bug
Product:	Wine
Classification:	Unclassified
Component:	mshtml
Version:	1.4-rc2
Hardware:	x86-64 Linux

Importance:	P2 normal
Target Milestone:	---
Assigned To:	Mr. Bugs

URL:	http://www.htmlkit.com/download/#down...
Keywords:	download, regression

Depends on:
Blocks:
	Show dependency tree

Reported:	2012-02-09 08:17 UTC by A Wine user
Modified:	2014-03-07 14:12 UTC (History)
CC List:	1 user (show)

See Also:
Regression SHA1:	e0f6b95d44f8208d2dce75278eb88e6eb57fe744
Fixed by SHA1:	595fb40efcfe1d49747ef63e823f9e6171e2d193
Distribution:	---
Staged patchset:

Attachments
Terminal output (2.71 KB, text/plain) 2012-02-09 08:17 UTC, A Wine user	Details
+urlmon log (75.73 KB, text/plain) 2012-02-09 08:28 UTC, A Wine user	Details
View All Add an attachment (back traces, logs, proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description A Wine user 2012-02-09 08:17:37 UTC

Created attachment 38764 [details]
Terminal output

HTML-Kit provides a list of installed plugins (several are included with the default installation) within the program, where a preview of each one can be viewed. Since 1.3.34, this preview stopped updating and is stuck showing information about the plugin that was selected by default. Regression testing indicated:

e0f6b95d44f8208d2dce75278eb88e6eb57fe744 is the first bad commit
commit e0f6b95d44f8208d2dce75278eb88e6eb57fe744
Author: Jacek Caban <jacek@codeweavers.com>
Date:   Fri Nov 25 15:58:37 2011 +0100

    urlmon: Properly compare file URIs.

:040000 040000 647344d6aae542df3f6a5c0ce5f529850bd06a7e b7c3fb79d07aa36cc159c08690c12604f50f43b2 M    dlls

Reverting the patch restored the behavior of 1.3.33. Note that there was an earlier regression between 1.3.32 and 1.3.33 (not yet bisected) which caused this preview to be successfully updated only once.

To reproduce, go to help -> installed plugins and click on some plugin like "download batch actions." Nothing happens.

Comment 1 Jacek Caban 2012-02-09 08:26:08 UTC

Please attach urlmon debuh channel output.

Comment 2 A Wine user 2012-02-09 08:28:23 UTC

Created attachment 38765 [details]
+urlmon log

Comment 3 Jacek Caban 2012-02-09 09:01:13 UTC

That patch revealed a problem in mshtml that's not loading the page correctly (assuming that only hash part has changed).

Comment 4 A Wine user 2013-05-25 01:53:03 UTC

Still in 1.5.31.

Comment 5 Jacek Caban 2014-03-06 10:46:02 UTC

Fixed in Git.

Comment 6 Alexandre Julliard 2014-03-07 14:12:59 UTC

Closing bugs fixed in 1.7.14.