WineHQ Bugzilla – Bug 28939 – Notepad2: page fault when saving or opening files

Bugzilla

Last modified: 2014-02-07 13:07:07 UTC

Notepad2: page fault when saving or opening files

Bug 28939 - Notepad2: page fault when saving or opening files


Summary:	Notepad2: page fault when saving or opening files

Status:	CLOSED FIXED

AppDB:	Show Apps affected by this bug
Product:	Wine
Classification:	Unclassified
Component:	-unknown
Version:	1.3.31
Hardware:	x86 Linux

Importance:	P2 normal
Target Milestone:	---
Assigned To:	Mr. Bugs

URL:	http://www.flos-freeware.ch/notepad2....
Keywords:	download, source

Depends on:
Blocks:
	Show dependency tree

Reported:	2011-10-30 05:05 UTC by Anthony Hanes
Modified:	2014-02-07 13:07 UTC (History)
CC List:	2 users (show)

See Also:
Regression SHA1:
Fixed by SHA1:
Distribution:	---
Staged patchset:

Attachments
console output of testing typing some html code and trying to save it. (6.28 KB, text/plain) 2011-10-30 05:05 UTC, Anthony Hanes	Details
console output of trying to open some small html file. (6.49 KB, text/plain) 2011-10-30 05:08 UTC, Anthony Hanes	Details
WINEDEBUG=+shlwapi wine Notepad2.exe Notepad2.ini (589 bytes, text/plain) 2011-11-07 05:21 UTC, Anthony Hanes	Details
+shell trace (77.06 KB, application/x-bzip2) 2011-11-07 13:14 UTC, Austin English	Details
Show Obsolete (1) View All Add an attachment (back traces, logs, proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Anthony Hanes 2011-10-30 05:05:15 UTC

Created attachment 37198 [details]
console output of testing typing some html code and trying to save it.

* Saving a file via GUI: app crashes after selecting the destination file name/
  path. file contents are saved, however (in my test case - don't rely on it).
* Opening a file via GUI: app crashes after selecting source file name/path.
* Opening a file via CLI: app crasheson startup when passing a filename as
  single first parameter on command line. (on windows: opens that file)

I'll attach the error logs. I first thought it had to do with the message

> fixme:commdlg:GetFileName95 Flags 0x02000000 not yet implemented

but seems that is no problem since it appears every time I open the file select
window, but when I cancel that instead of opening or saving the file, the app
won't crash.

I'm missing the keywords field in the bug report form, so I've added them in the
subject and will try to add "download source" after submitting.

Comment 1 Anthony Hanes 2011-10-30 05:08:10 UTC

Created attachment 37199 [details]
console output of trying to open some small html file.

Comment 2 Anthony Hanes 2011-10-30 08:03:06 UTC

Workaround for people who can make do with an old version:
The Wayback Machine still has version 4.0.23 around. To get it, visit
http://web.archive.org/web/20091206072228/http://flos-freeware.ch/notepad2.html
and follow the download link from there.

Comment 3 Austin English 2011-10-30 17:31:26 UTC

=>0 0x68707977 PathIsUNCW+0x27() in shlwapi (0x0033c16c)
  1 0x6870a30c PathAppendW+0x4b() in shlwapi (0x0033c1bc)

Try native shlwapi.

Comment 4 Anthony Hanes 2011-11-01 18:17:15 UTC

works, thank you. :) i'll recheck this bug to help with further testing if
someone wants to try and modify wine's shlwapi.

Extended howto using proprietary Windows DLL:
* copy %windir%\system32\shlwapi.dll from WinXP Pro SP 3 to same path where Notepad2.exe is.
* run wincfg and add a dll override: if you drop down the combo box first and type "shl", it's already there. click the add button and winecfg puts in some default values.
* works. :)

Comment 5 Austin English 2011-11-01 18:27:00 UTC

Please attach a +shlwapi trace (with debugging symbols installed). You'll need to use wine's builtin dll for this.

Comment 6 Anthony Hanes 2011-11-07 05:21:38 UTC

Created attachment 37350 [details]
WINEDEBUG=+shlwapi wine Notepad2.exe Notepad2.ini

hello Austin, I hope I understood your request right, then here it is. :)

Comment 7 Austin English 2011-11-07 13:13:31 UTC

Backtrace:
=>0 0x7eaec379 PathIsUNCW+0x29(lpszPath="") [/home/austin/wine-git/dlls/shlwapi/path.c:2203] in shlwapi (0x0033ec18)
  1 0x7eaed68c PathAppendW+0x4b(lpszPath="C:\users\austin\My Documents", lpszAppend="") [/home/austin/wine-git/dlls/shlwapi/path.c:105] in shlwapi (0x0033ec68)
  2 0x0045c862 in notepad2 (+0x5c861) (0x0033f094)
  3 0x0045ca36 in notepad2 (+0x5ca35) (0x0033f2c0)
  4 0x00463292 in notepad2 (+0x63291) (0x0033f90c)
  5 0x0046391a in notepad2 (+0x63919) (0x00494a20)
  6 0x0068005c (0x003a005a)
  7 0x00000000 (0x00000000)
0x7eaec379 PathIsUNCW+0x29 [/home/austin/wine-git/dlls/shlwapi/path.c:2203] in shlwapi: cmpw    $92,0x0(%esi)
2203      if (lpszPath && (lpszPath[0]=='\\') && (lpszPath[1]=='\\'))


The debug channel should've been shell (my mistake). I'll attach that log. Confimring in 1.3.32.

c91154f83dbab37747ce354c69b59599e9990129  /home/austin/notepad2_4.2.25_x86.zip

Comment 8 Austin English 2011-11-07 13:14:12 UTC

Created attachment 37357 [details]
+shell trace

Comment 9 Bruno Jesus 2013-02-23 18:17:56 UTC

I'm not able to reproduce this issue in wine 1.5.24, can anyone else retest?

Comment 10 Frédéric Delanoy 2014-01-31 03:53:37 UTC

Works as well for me in 1.7.11.

Marking fixed.

Comment 11 Alexandre Julliard 2014-02-07 13:07:07 UTC

Closing bugs fixed in 1.7.12.