Also this is the source code:
#include <windows.h>
#include <stdio.h>
#include <cstdlib>
#include <iostream>
#include <fstream>
#include <wchar.h>
using namespace std;

int main()
{
    unsigned int prueba;
    fstream resultado;
    WCHAR* testptr;
    resultado.open("result.txt",ios::out);
    prueba = ImmGetDescriptionW(NULL,testptr,255);
    resultado << "Address: " << testptr << endl;
    resultado << "Character length: " << prueba << endl;
    resultado.close();
}

(In reply to comment #1)
> 
> int main()
> {
>     unsigned int prueba;
>     fstream resultado;
>     WCHAR* testptr;
>     resultado.open("result.txt",ios::out);
>     prueba = ImmGetDescriptionW(NULL,testptr,255);
>     resultado << "Address: " << testptr << endl;
>     resultado << "Character length: " << prueba << endl;
>     resultado.close();
> }

testptr is uninitialized so results are unreliable. Please add a test like ImmGetDescriptionW/A(NULL, NULL, 1) to imm32/tests.

What Wine version by the way?

(In reply to comment #3)
> What Wine version by the way?

Forgot to tell it is 1.3.28, added to the description.

if(!hKL && !lpszDescription) 
{
	lpszDescription = (WCHAR*)HeapAlloc(HeapCreate( 0, 0, 255 ),HEAP_ZERO_MEMORY,255);
}
Those are the lines that fixed it for me, but I don't know to make a patch and I know more implementation is needed for the function to be correct.

Created attachment 36456 [details]
Avoid null pointer copy

What application depends on this? Is it available for download?

Please, test the attached patch. It makes your test not crash.

(In reply to comment #6)
> Created an attachment (id=36456) [details]
> Avoid null pointer copy
> 
> What application depends on this? Is it available for download?
> 
> Please, test the attached patch. It makes your test not crash.

(In reply to comment #6)
> Created an attachment (id=36456) [details]
> Avoid null pointer copy
> 
> What application depends on this? Is it available for download?
> 
> Please, test the attached patch. It makes your test not crash.

It is ok, however, it would be better if it returns an address, on windows it returns an address, and about the application is not exactly an application, just an attempt to implement that function completely since Phantasy Star Online calls that function.

Can you provide the source code for the original .exe you posted? Your example code does not work for me, even fixing the ptr. Return value is always zero. Tested in Visual C++ 6.

Does the game work with the patch I attached previously?

lpszDescription may be null and in such cases it's not filled. If uBufLen is zero the returned value is the required size for lpszDescription.

The caller must pass a valid pointer to the function, ImmGetDescription should not allocate memory as far as I can see and even if it did there is no way to return it to the user judging by it's parameters.

This issue has been fixed.

(In reply to comment #9)
> This issue has been fixed.

The test program from comment #0 fails here in wine-1.4-rc5-45-g74ddf01.

Bruno's patch works around it.

Oh sorry I posted in the wrong bug hahaha

Windows 7 and XP must crash if a valid IMM description is to be returned and lpszDescription is NULL. The main problem here is that wine is not filtering the NULL (read as "not valid") hkl parameter. If the hkl is invalid ImmGetDescription should return zero and in some cases set error to invalid handle.

(In reply to comment #12)
Tests committed.

Created attachment 40573 [details]
Patch to fix the issue in wine 1.5.6

The attached patch will fix the problem but as I could not test it fully in windows I'm not submitting it yet. None of the machines in testbot returns valid IMEs to test (tests are skipped).

(In reply to comment #14)
> Created attachment 40573 [details]
> Patch to fix the issue in wine 1.5.6
> 
> The attached patch will fix the problem but as I could not test it fully in
> windows I'm not submitting it yet. None of the machines in testbot returns
> valid IMEs to test (tests are skipped).

Ok I am testing on Japanese windows XP.

ret = ImmGetDescriptionW(hkl, NULL, 100);  -> Causes and exception
ret = ImmGetDescriptionA(hkl, NULL, 100); -> Causes an exception

 
As for Vista and Windows 7, ImmGetDescription is broken there. It just does not function.

http://blogs.msdn.com/b/michkap/archive/2008/12/04/9173920.aspx

I can try installing a custom old style IME and see but the above windows XP behavior seems to imply to me that crashing in the case of HKL, NULL, 100 is correct.


Back to windows XP;

    ret = ImmGetDescriptionW(NULL, NULL, 100);
    ok(!ret, "ImmGetDescriptionW failed, expected 0 received %d.\n", ret);

That works without issue.


that that implys that your 
+  if (!hKL) return 0;

is correct, but that
+  if (!lpszDescription) return 0;

is incorrect.

If there is any other testing I can do please ask.

(In reply to comment #15)
> If there is any other testing I can do please ask.

Thank you very much for testing, I gave that patch to Qian Hong since I can't test and he is currently working in Imm stuff. I hope he will find your results useful.

Fixed by 8b933495fb4b9a874b9f1f3560847739520ba384, thanks Aric.

Closing bugs fixed in 1.7.3.

Removing 1.6.x milestone from bugs included in 1.6.1.