WineHQ Bugzilla – Bug 25771 – getElementsByName not implemented- causes problems for some applications navigating internet.

Bugzilla

Last modified: 2014-02-20 12:37:12 UTC

getElementsByName not implemented- causes problems for some applications navigating internet.

Bug 25771 - getElementsByName not implemented- causes problems for some applications navigating internet.


Summary:	getElementsByName not implemented- causes problems for some applications navi...

Status:	CLOSED FIXED

AppDB:	Show Apps affected by this bug
Product:	Wine
Classification:	Unclassified
Component:	mshtml
Version:	1.3.11
Hardware:	x86-64 Linux

Importance:	P2 normal
Target Milestone:	---
Assigned To:	Mr. Bugs

URL:
Keywords:	download

Depends on:
Blocks:
	Show dependency tree

Reported:	2011-01-14 04:42 UTC by Charlie
Modified:	2014-02-20 12:37 UTC (History)
CC List:	4 users (show)

See Also:
Regression SHA1:
Fixed by SHA1:	f3a2cb7bbd1ad25b078fdc9b4404dee0f0de33ad
Distribution:	---
Staged patchset:

Attachments
Terminal output from around the time of problem (7.07 KB, text/plain) 2011-01-14 09:30 UTC, Charlie	Details
Patch 1/2: Fix typo (738 bytes, patch) 2011-01-14 10:00 UTC, Juan Lang	Details \| Diff
Patch 2/2: Add stub for SIO_SET_COMPATIBILITY_MODE (781 bytes, patch) 2011-01-14 10:01 UTC, Juan Lang	Details \| Diff
getElementsByName (1.22 KB, patch) 2012-01-04 12:55 UTC, ocean04	Details \| Diff
patch for wine-1.5.23 (1.28 KB, patch) 2013-02-03 10:47 UTC, ocean04	Details \| Diff
Show Obsolete (2) View All Add an attachment (back traces, logs, proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Charlie 2011-01-14 04:42:22 UTC

MCC Pilotlog has been working OK in general for me with wine 1.3.11 under Ubuntu 10.10 x64.

However, one of the features of the application is that it can log into a company crew information system and retrieve flight information into the log. I have tested this on a windows VM, and it works fine.

However, under Wine, we get error 445 and then a crash. I am a bit surprised, as I thought that the IE-mimicking facilities in Wine would be able to cope.

I've contacted the MCC developers about the issue, and they cannot throw too much light on the subject, but suggest that this is a code chink that may be causing the problem:

-----------------------------
For Each HTMLi In WebBr.Document.getElementsByName("Id")
HTMLi.Value = TxtLoginName
Next

For Each HTMLi In WebBr.Document.getElementsByName("Pass")
HTMLi.Value = TxtPassword
Next

For Each HTMLi In WebBr.Document.getElementsByName("B1")
HTMLi.Click
Exit For
Next
------------------------------

Terminal output attached. This application has to be run with wine set as win 7.

To reproduce:
Follow installation steps on AppDB entry. (http://appdb.winehq.org/objectManager.php?sClass=version&iId=22277)
Run the application
Choose 'Settings', then 'Interfaces - Airline PDA'
Choose 'Air Astana' from drop-down menu.
Close this window
Choose 'Airline Interface'
Double-click 'Air Astana' on the left-hand side of the pop-up to show the in-app browser display.
Type 2x4 digit numbers in the login window. (I can't give you my real login, sorry! The error exists without valid credentials.)
Click 'Start'

I have selected mshtml as the component with the issue, but I am not completely sure.

Comment 1 Juan Lang 2011-01-14 09:28:37 UTC

Terminal output?

Comment 2 Charlie 2011-01-14 09:30:25 UTC

Created attachment 32840 [details]
Terminal output from around the time of problem

Comment 3 Charlie 2011-01-14 09:31:23 UTC

Apologies- I tried to attach, but clearly failed!

If you need more, please ask.

Charlie

Comment 4 Juan Lang 2011-01-14 10:00:57 UTC

Created attachment 32843 [details]
Patch 1/2: Fix typo

Comment 5 Juan Lang 2011-01-14 10:01:47 UTC

Created attachment 32844 [details]
Patch 2/2: Add stub for SIO_SET_COMPATIBILITY_MODE

Do these two patches help?

Comment 6 Juan Lang 2011-01-14 13:09:28 UTC

Comment on attachment 32843 [details]
Patch 1/2: Fix typo

This patch was committed.  What happens when patch 2 is applied on top of latest git?

Comment 7 Charlie 2011-01-14 13:14:08 UTC

(In reply to comment #6)
> (From update of attachment 32843 [details])
> This patch was committed.  What happens when patch 2 is applied on top of
> latest git?

I'm struggling with compiling Wine from source just at the second (seems to be a problem arising from using 64-bit distro).  I will be with you as soon as I can.  In the meantime, I cried for help in the IRC channel, but none has come yet!

Comment 8 Charlie 2011-01-14 14:53:59 UTC

(In reply to comment #6)
> (From update of attachment 32843 [details])
> This patch was committed.  What happens when patch 2 is applied on top of
> latest git?

OK, patched and compiled from git.  Seems that there's no change to the outcome.

Comment 9 Juan Lang 2011-01-14 15:44:34 UTC

Ok, thanks for testing.

Comment 10 Charlie 2011-07-09 15:40:01 UTC

Installing ie7 with winetricks works around this issue.

Comment 11 Charlie 2011-07-10 10:52:43 UTC

Apparently, this is caused by:
getElementsByName
not being implemented.

Also, the above-mentioned installation of ie7 works, only up until a reboot!

Comment 12 Dan Kegel 2011-07-26 11:48:50 UTC

Please don't change originally reported version.

Comment 13 ocean04 2011-10-23 04:17:46 UTC

getElementsByName is unimplemented 1.3.31

fixme:mshtml:HTMLDocument3_getElementsByName.. this can be changed to NEW

Comment 14 ocean04 2012-01-04 12:55:43 UTC

Created attachment 38263 [details]
getElementsByName

You can try this patch

Comment 15 ocean04 2012-04-07 08:40:41 UTC

This is more important now, because jscript also uses it (wine 1.5.1)

I believe attached patch is fine (but without tests)

Easy to try, enter some numbers to fields:

wine iexplore http://netikka.net/dev/elementsbyname.html

Can this be marked as new, please?

Comment 16 Vitaliy Margolen 2012-04-07 09:54:23 UTC

Confirming per comment 15.

Comment 17 ocean04 2012-09-13 03:38:53 UTC

still unimplemented wine-1.5.12-246-g92ad0a4

Comment 18 ocean04 2013-02-03 10:47:42 UTC

Created attachment 43436 [details]
patch for wine-1.5.23

Still in wine-1.5.23
Attached working patch for wine-1.5.23

Comment 19 ocean04 2013-08-30 05:13:57 UTC

Still unimplemented, wine-1.7.0-346-g1bf936c

Comment 20 ocean04 2013-11-19 08:41:49 UTC

Should be fixed by f3a2cb7bbd1ad25b078fdc9b4404dee0f0de33ad

Comment 21 Bruno Jesus 2014-02-11 16:51:26 UTC

(In reply to comment #20)
> Should be fixed by f3a2cb7bbd1ad25b078fdc9b4404dee0f0de33ad

Resolving fixed, tested with comment 15 site.

Comment 22 Alexandre Julliard 2014-02-20 12:37:12 UTC

Closing bugs fixed in 1.7.13.