WineHQ Bugzilla – Bug 23529 – Add support for lcms2

Bugzilla

Last modified: 2014-01-10 14:46:53 UTC

Add support for lcms2

Bug 23529 - Add support for lcms2


Summary:	Add support for lcms2

Status:	CLOSED FIXED

AppDB:	Show Apps affected by this bug
Product:	Wine
Classification:	Unclassified
Component:	build-env
Version:	1.2-rc6
Hardware:	x86 Linux

Importance:	P2 enhancement
Target Milestone:	---
Assigned To:	Mr. Bugs

URL:
Keywords:	download, patch

Depends on:
Blocks:
	Show dependency tree

Reported:	2010-07-05 12:06 UTC by Sergei Steshenko
Modified:	2014-01-10 14:46 UTC (History)
CC List:	4 users (show)

See Also:
Regression SHA1:
Fixed by SHA1:	d40c91262b91f72c44151a1481a77acfe71ba044
Distribution:	---
Staged patchset:

Attachments
initial support (2.41 KB, patch) 2011-10-17 20:46 UTC, Austin English	Details \| Diff
View All Add an attachment (back traces, logs, proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Sergei Steshenko 2010-07-05 12:06:13 UTC

While running 'configure' I see these lines in its screen output:

    154 checking lcms.h usability... no
    155 checking lcms.h presence... no
    156 checking for lcms.h... no
    157 checking lcms/lcms.h usability... no
    158 checking lcms/lcms.h presence... no
    159 checking for lcms/lcms.h... no
.

According to http://sourceforge.net/projects/lcms/files/ at the moment the latest tarball is lcms2-2.0a.tar.gz and its header files (when installed) are:

"
sergei@amdam2:~/junk> ls -ltr /mnt/sdb8/sergei/AFSWD_debug/install/lcms-2.0/include/
total 117
-rw-r--r-- 1 qemu users 24622 2010-07-05 03:59 lcms2_plugin.h
-rw-r--r-- 1 qemu users 91214 2010-07-05 03:59 lcms2.h
sergei@amdam2:~/junk> 
".

I.e. configure should check for version 2.0 or later and check existence of 'lcms2.h' rather than 'lcms.h' file.

Comment 1 Hans Leidekker 2010-07-06 02:21:25 UTC

Which distributions include lcms2?

Comment 2 Andrew Nguyen 2010-07-06 02:38:59 UTC

(In reply to comment #1)
> Which distributions include lcms2?

As far as I could tell, no distribution carries lcms2 in a primary package repository, although Fedora seems to have it in updates-candidate and Gentoo carries an ebuild marked as testing.

Comment 3 Dmitry Timoshkov 2010-07-06 02:43:38 UTC

Then this is not a bug at all, at the most just an enhancement request.

Comment 4 Sergei Steshenko 2010-07-06 03:21:34 UTC

(In reply to comment #1)
> Which distributions include lcms2?

I have no idea and I don't care. I build and install everything I need in the directories I want, which are not system directories. From time to time I upgrade packages versions.

So, less than a month ago I discovered the new lcms version and upgraded.

Comment 5 Sergei Steshenko 2010-07-06 03:23:41 UTC

(In reply to comment #3)
> Then this is not a bug at all, at the most just an enhancement request.

Maybe.

But then I see a chicken-egg problem. A distro can't start supporting 'lcms2' because 'wine' doesn't support it and 'wine' won't support 'lcms2' because no distro includes it.

Comment 6 Dmitry Timoshkov 2010-07-06 03:32:45 UTC

(In reply to comment #5)
> But then I see a chicken-egg problem. A distro can't start supporting 'lcms2'
> because 'wine' doesn't support it and 'wine' won't support 'lcms2' because no
> distro includes it.

Not really. Distributions don't care what version of packages Wine supports.
Besides, there are many other projects that use lcms.

Comment 7 Hans Leidekker 2010-07-06 03:35:18 UTC

> But then I see a chicken-egg problem. A distro can't start supporting 'lcms2'
> because 'wine' doesn't support it and 'wine' won't support 'lcms2' because no
> distro includes it.

lcms2 can be installed alongside lcms1 exactly for this reason.

Comment 8 Sergei Steshenko 2010-07-06 03:55:48 UTC

(In reply to comment #7)
> > But then I see a chicken-egg problem. A distro can't start supporting 'lcms2'
> > because 'wine' doesn't support it and 'wine' won't support 'lcms2' because no
> > distro includes it.
> 
> lcms2 can be installed alongside lcms1 exactly for this reason.

I know. And my environment can cope with it. Other packages which use 'lcms' silently accepted 'lcms2', so other than for 'wine' I have no need to keep both versions.

Probably in half year the issue will become relevant for 'wine'.

Comment 9 Austin English 2011-10-17 20:46:32 UTC

Created attachment 36970 [details]
initial support

Work in progress, but not sure when I'll pick it up, so leaving here for now in case someone else wants to finish it.

Comment 10 Scott Ritchie 2012-01-20 20:53:42 UTC

It seems this is no longer a mere enhancement request and needs some escalation in priority - liblcms1 is deprecated upstream, not receiving fixes, and is being slated for removal from distributions.  See, for instance, https://bugs.launchpad.net/ubuntu/+source/lcms/+bug/885324

Comment 11 Hans Leidekker 2012-01-21 04:56:14 UTC

(In reply to comment #10)
> It seems this is no longer a mere enhancement request and needs some escalation
> in priority - liblcms1 is deprecated upstream, not receiving fixes, and is
> being slated for removal from distributions.  See, for instance,
> https://bugs.launchpad.net/ubuntu/+source/lcms/+bug/885324

When will liblcms1 be removed from which distributions? How about 32-bit
versions of liblcms2 for current 64-bit distros? I doubt we want to support
both version 1 and version 2 of liblcms in Wine.

Comment 12 Scott Ritchie 2012-01-21 16:38:15 UTC

On Ubuntu, we'd like to migrate everything away from liblcms1 by 12.04, which means this would need to be done in the 1.4 timetable.

At a distro level, supporting 32-on-64 lcms2 is just as easy as lcms1.  On Ubuntu 12.04, for instance, it's already multiarched and you can just apt-get install liblcms2-2:i386.  So I'd expect it to be quite available.

Comment 13 Hans Leidekker 2012-01-22 02:18:54 UTC

(In reply to comment #12)
> On Ubuntu, we'd like to migrate everything away from liblcms1 by 12.04, which
> means this would need to be done in the 1.4 timetable.
> 
> At a distro level, supporting 32-on-64 lcms2 is just as easy as lcms1.  On
> Ubuntu 12.04, for instance, it's already multiarched and you can just apt-get
> install liblcms2-2:i386.  So I'd expect it to be quite available.

Sure, but I asked about *current* distro versions. Without a reasonable
transition period Wine is forced to support both versions of liblcms.

Comment 14 Scott Ritchie 2012-01-22 10:29:06 UTC

Fair enough, but without supporting both versions for a bit we will _never_ be able to migrate and will end up using a deprecated unsupported library forever.

To answer your question as far as Ubuntu goes, 11.10, 11.04, 10.10, and 10.04 rely on ia32-libs, so in order to support them I'll have to update the ia32-libs in the PPA to include liblcms2 (this isn't hard).

Comment 15 Detlef Riekenberg 2013-05-08 09:59:00 UTC

I send a patch to add support for lcms2 with a fallback to lcms v1:
http://source.winehq.org/patches/data/96110

As info for distribution support for lcms2:
Ubuntu 11.10 has liblcms2-2 as a "main" package (section libs). 

-- 
By by ... Detlef

Comment 16 Detlef Riekenberg 2013-05-10 15:39:08 UTC

(In reply to comment #15)
> I send a patch to add support for lcms2 with a fallback to lcms v1:
> http://source.winehq.org/patches/data/96110

BUG: The patch was still using the includes for lcms v1
     To fix compilation while using lcms2.h,
     add a #include <icc34.h> after the #include <lcms2.h>
     (icc34.h comes with the liblcms v1 dev package)

I prepare a better patch in the near future.

-- 
By by .. Detlef

Comment 17 Hans Leidekker 2013-07-30 02:34:54 UTC

Fixed by d40c91262b91f72c44151a1481a77acfe71ba044.

Comment 18 Alexandre Julliard 2013-08-02 13:19:14 UTC

Closing bugs fixed in 1.7.0.

Comment 19 Scott Ritchie 2013-12-17 16:00:17 UTC

Nominating for 1.6.2 so I can put it into Ubuntu 14.04 LTS and Wine won't be the only package still using old lcms.

Comment 20 Alexandre Julliard 2014-01-10 14:46:53 UTC

Removing 1.6.x milestone from bugs included in 1.6.2.