WineHQ Bugzilla – Bug 22575 – Major decline in Starcraft's 2d graphics performance

Bugzilla

Last modified: 2010-05-28 12:51:51 CDT

Major decline in Starcraft's 2d graphics performance

Bug 22575 - Major decline in Starcraft's 2d graphics performance


Summary:	Major decline in Starcraft's 2d graphics performance

Status:	CLOSED FIXED

AppDB:	Show Apps affected by this bug
Product:	Wine
Classification:	Unclassified
Component:	directx-d3d
Version:	1.1.43
Hardware:	x86-64 Linux

Importance:	P2 normal
Target Milestone:	---
Assigned To:	Mr. Bugs

URL:
Keywords:	regression

Depends on:
Blocks:
	Show dependency tree

Reported:	2010-05-04 01:39 CDT by David
Modified:	2010-05-28 12:51 CDT (History)
CC List:	1 user (show)

See Also:
Regression SHA1:
Fixed by SHA1:
Distribution:	---
Staged patchset:

Attachments
Regression Test Results (386 bytes, text/plain) 2010-05-04 01:39 CDT, David	Details
View All Add an attachment (back traces, logs, proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description David 2010-05-04 01:39:42 CDT

Created attachment 27700 [details]
Regression Test Results

Updating wine to 1.1.43 causes a major decline in Starcraft's 2d graphics performance, when running with DirectDrawRenderer="opengl" set in regedit.

The graphics are now drawn so slowly that it's immediately obvious when navigating the menu screens. The game is unplayable as a result.

I performed a regression test which told me that "e7a71e15b56d709c4623a472b0dc44ae6b336e08 is the first bad commit", which had the description "wined3d: Turn blit_shader color_fixup_supported into blit_supported." The full result is attached.

I'm running on debian x86-64 with a Radeon HD4870 using the fglrx driver if that makes any odds.

Comment 1 Dmitry Timoshkov 2010-05-04 09:34:58 CDT

e7a71e15b56d709c4623a472b0dc44ae6b336e08 is the first bad commit
commit e7a71e15b56d709c4623a472b0dc44ae6b336e08
Author: Roderick Colenbrander <thunderbird2k@gmail.com>
Date:   Tue Apr 6 22:20:42 2010 +0200

    wined3d: Turn blit_shader color_fixup_supported into blit_supported.

Comment 2 Roderick Colenbrander 2010-05-04 14:22:47 CDT

I'm aware of the issue but haven't had time to fix it yet. It is basically the blit_supported call in d3dfmt_get_conv which is the problem. If you shortcut that call (e.g. by setting the blit_supported=1) it should work fine.

Comment 3 David 2010-05-22 10:43:19 CDT

As far as I can tell, this bug seems to have been fixed as of 1.2-rc1. Cheers!

Comment 4 Roderick Colenbrander 2010-05-22 11:06:37 CDT

As far as I'm aware it isn't fixed.

Comment 5 Roderick Colenbrander 2010-05-26 10:07:32 CDT

The bug isn't fixed and will be fixed tomorrow. Perhaps some other change helped but the 8-bit conversion is now done in software (on modern CPUs that should work fine in general).

Comment 6 Roderick Colenbrander 2010-05-27 11:35:41 CDT

Should be fixed now by ba09e7a2a1ddd8bc9675043c8e0e3d56dd460bcf

Comment 7 Alexandre Julliard 2010-05-28 12:51:51 CDT

Closing bugs fixed in 1.2-rc2.