WineHQ Bugzilla – Bug 22440 – Total Commander: The panels showing Brief are not resized vertically when the application window is resized vertically

Bugzilla

Last modified: 2018-09-14 14:21:47 CDT

Total Commander: The panels showing Brief are not resized vertically when the application window is resized vertically

Bug 22440 - Total Commander: The panels showing Brief are not resized vertically when the application window is resized vertically


Summary:	Total Commander: The panels showing Brief are not resized vertically when the...

Status:	CLOSED FIXED

AppDB:	Show Apps affected by this bug
Product:	Wine
Classification:	Unclassified
Component:	comctl32
Version:	1.1.42
Hardware:	x86-64 Linux

Importance:	P2 trivial
Target Milestone:	---
Assigned To:	Mr. Bugs

URL:	http://www.ghisler.com/amazons3.php
Keywords:

Depends on:
Blocks:
	Show dependency tree

Reported:	2010-04-20 16:58 CDT by Alex Balut
Modified:	2018-09-14 14:21 CDT (History)
CC List:	2 users (show)

See Also:
Regression SHA1:
Fixed by SHA1:	bb116577a3d28e9063102fb6484e6947913002ad
Distribution:	---
Staged patchset:

Attachments
Screenshot - Brief panel not resized when window is resized vertically (53.48 KB, image/png) 2010-04-20 16:58 CDT, Alex Balut	Details
Update the size in SetColumnWidth unconditionally (1.00 KB, patch) 2018-08-20 10:53 CDT, Gabriel Ivăncescu	Details \| Diff
View All Add an attachment (back traces, logs, proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Alex Balut 2010-04-20 16:58:28 CDT

Created attachment 27481 [details]
Screenshot - Brief panel not resized when window is resized vertically

- Press Ctrl F1, notice the panel is in "Brief" mode (and has a horizontal scrollbar instead of a vertical one).
- Resize the window vertically, make it smaller (or larger - see screenshot), notice the Brief panel is not resized.

Total Commander 7.50a

Comment 1 Wylda 2010-04-22 04:57:21 CDT

Confirming, all the following versions have reported issue:
 * 0.9.49, 1.1.25, 1.1.43

Comment 2 Vitaliy Margolen 2010-04-22 08:43:06 CDT

Confirming per comment 1.

Comment 3 Austin English 2012-03-19 14:52:49 CDT

This is your friendly reminder that there has been no bug activity for 650 days. Is this still an issue in current (1.4 or newer) wine?

Comment 4 Alex Balut 2012-03-20 03:19:01 CDT

Still a bug in wine-1.4

Comment 5 Alex Balut 2013-08-06 06:17:17 CDT

Still a bug in wine-1.6 with Total Commander 7.56a. (Works fine in Total Commander 8.01)

Comment 6 Austin English 2014-11-16 23:18:45 CST

This is your friendly reminder that there has been no bug activity for 1 year. Is this still an issue in current (1.7.31 or newer) wine? If so, please attach the terminal output in 1.7.31 (see http://wiki.winehq.org/FAQ#get_log).

Comment 7 Wylda 2016-08-14 11:54:58 CDT

Still present in wine-1.9.16-161-gd6d0d96.

Comment 8 Gabriel Ivăncescu 2018-08-20 10:53:00 CDT

Created attachment 62101 [details]
Update the size in SetColumnWidth unconditionally

Total Commander's Brief View is a multi-column listbox, and I found quite a few bugs with such listboxes, my guess is nobody tested them that extensively.

In this case, when the listbox receives a WM_WINDOWPOSCHANGED message and calls DefWindowProc on it, which then ends up sending a WM_SIZE to the window, Total Commander swallows that up and won't pass the WM_SIZE to the listbox. However, it does pass a LB_SETCOLUMNWIDTH, even when the column width did not change at all. So this patch unconditionally updates the size itself (not just the page) when that message is received.

It fixes it for me, and I tried a lot of weird resizing on it that would totally crap out before. I also sent it to the mailing list.

Comment 9 Nikolay Sivov 2018-09-07 23:15:52 CDT

This is fixed with https://source.winehq.org/git/wine.git/?a=commit;h=bb116577a3d28e9063102fb6484e6947913002ad.

Comment 10 Alexandre Julliard 2018-09-14 14:21:47 CDT

Closing bugs fixed in 3.16.