WineHQ
Bug Tracking Database – Bug 22315

 Bugzilla

 

Last modified: 2015-11-15 12:18:07 CST  

Notification tray icons using solid rather than transparent background colors

Bug 22315 - Notification tray icons using solid rather than transparent background colors
Notification tray icons using solid rather than transparent background colors
Status: CLOSED FIXED
AppDB: Show Apps affected by this bug
Product: Wine
Classification: Unclassified
Component: winex11.drv
1.1.42
x86 Linux
: P2 trivial
: ---
Assigned To: Mr. Bugs
https://bugs.launchpad.net/ubuntu/+so...
: download, integration
: 21597 23191 24991 (view as bug list)
Depends on:
Blocks:
  Show dependency tree
 
Reported: 2010-04-09 02:11 CDT by Scott Ritchie
Modified: 2015-11-15 12:18 CST (History)
19 users (show)

See Also:
Regression SHA1:
Fixed by SHA1: e03b8e1a1d1a553dbfcb20dcfccf92d4c17eade6
Distribution: ---
Staged patchset:


Attachments
A screengrab of the issue (6.31 KB, image/png)
2011-08-04 16:43 CDT, hamboy95
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Scott Ritchie 2010-04-09 02:11:15 CDT
From a large bug report on launchpad affecting many apps: https://bugs.launchpad.net/ubuntu/+source/banshee/+bug/403135?comments=all

Essentially, tray icons are being drawn with non-transparent backgrounds.  This is usually from setting their (not always correct) color to bg_color rather than just transparent.

http://launchpadlibrarian.net/41246531/screen.png  is a screenshot showing Spotify (and a few other, non-Wine apps) using the wrong background in the system tray.
Comment 1 Austin English 2010-04-09 11:02:50 CDT
Dupe of bug 21597?
Comment 2 Vitaliy Margolen 2010-04-10 12:21:13 CDT
Wine & X doesn't support transparent colors. How do you suggest Wine use transparent color?
Comment 3 Roderick Colenbrander 2010-04-13 03:22:12 CDT
We do support transparency in some cases when XRender is around when you use 32-bit DIBSections and using a concept patch I submitted yesterday we also allow it for 32-bit DDBs.

I think the main issue is that systray bar we draw uses a 24-bit X visual (so it has no alpha). If it were 32-bit and an icon with transparency was drawn into it (this would depend on the app!) it might work. Right now we use win32 calls to create the window and I don't think we want 32-bit windows, so if this is the issue I'm not sure if we can fix it at all.
Comment 4 Roderick Colenbrander 2010-04-18 17:04:25 CDT
Apparently this works using SetLayeredWindowAttributes on Windows and we seem to offer support for this in Wine. sync_window_opacity in winex11.drv explicitly has such code for the systray. That's perhaps a place to look.
Comment 5 Damjan Jovanovic 2010-04-19 03:43:39 CDT
The latest version of the systemtray spec (http://standards.freedesktop.org/systemtray-spec/systemtray-spec-latest.html) documents how to do transparent icons: you have to use the ParentRelative window background.
Comment 6 Alexandre Julliard 2010-04-19 04:08:18 CDT
No, ParentRelative doesn't help (it's what we do already). We need the window to use an ARGB visual.
Comment 7 Austin English 2010-04-19 11:42:52 CDT
Does this also affect the system tray / alt-tabbing, which have no icons?
Comment 8 Scott Ritchie 2010-04-21 17:07:49 CDT
*** Bug 21597 has been marked as a duplicate of this bug. ***
Comment 9 setack 2010-05-26 11:07:23 CDT
Any plan to fix this? Is there any workarround? They really look terrible...
Comment 10 aelilea 2010-05-28 05:01:09 CDT
Still present in 1.2rc1. Since the Lucid Lynx default theme now has a dark panel, this will be affecting many people.
Comment 11 aelilea 2010-05-28 10:10:54 CDT
Possibly related: When the panel is set to auto-hide, the Wine taskbar icons completely disappear from the panel when it is displayed (leaving only a background-coloured patch). Tooltips for these icons are no longer displayed either, while left- and right-click still work.
Comment 12 Ken Sharp 2010-06-11 16:32:08 CDT
(In reply to comment #11)

That might be bug 22487.
Comment 13 Ken Sharp 2010-06-11 21:10:21 CDT
But then again it might be a different bug.
Comment 14 Andy Piper 2010-06-12 17:56:34 CDT
Agreed this is frustrating and damages the look and integration of the desktop. With the recent steps forward in wine now recognising font smoothing set in FontConfig it would be nice to smooth out a few more of these rough edges to make the fit even better.
Comment 15 Austin English 2010-06-15 10:50:25 CDT
*** Bug 23191 has been marked as a duplicate of this bug. ***
Comment 16 hamboy95 2011-08-04 16:43:21 CDT
Created attachment 35808 [details]
A screengrab of the issue

I can confirm this is an issue on Arch Linux running KDE 4.7.
Comment 17 Caleb Hearon 2012-07-29 12:20:58 CDT
+1

It's really nice that Wine can integrate like this, and having the icons look perfect would make a big difference.

I swear this worked in a previous version...
Comment 18 Daniel Jelinski 2012-09-13 16:08:15 CDT
transparent background works for me (kubuntu 11.10). Fixed?
Comment 19 Alexandre Julliard 2012-09-13 16:18:50 CDT
Not yet, cf. comment 6.
Comment 20 Alexandre Julliard 2012-10-02 14:12:36 CDT
Fixed by e03b8e1a1d1a553dbfcb20dcfccf92d4c17eade6.
Comment 21 Alexandre Julliard 2012-10-12 13:35:38 CDT
Closing bugs fixed in 1.5.15.
Comment 22 Anastasius Focht 2015-11-15 12:18:07 CST
*** Bug 24991 has been marked as a duplicate of this bug. ***


Hosted By CodeWeavers