WineHQ
Bug Tracking Database – Bug 14367

 Bugzilla

 

Last modified: 2015-03-06 13:30:36 UTC  

revise stack-frame relay code never to touch other side of stack pointer

Bug 14367 - revise stack-frame relay code never to touch other side of stack pointer
revise stack-frame relay code never to touch other side of stack pointer
Status: CLOSED FIXED
AppDB: Show Apps affected by this bug
Product: Wine
Classification: Unclassified
Component: -unknown
1.0.0
x86 Linux
: P2 enhancement
: ---
Assigned To: Mr. Bugs
: download, patch
Depends on:
Blocks:
  Show dependency tree
 
Reported: 2008-07-08 17:34 UTC by John Reiser
Modified: 2015-03-06 13:30 UTC (History)
1 user (show)

See Also:
Regression SHA1:
Fixed by SHA1: 44fbc018eda12bdee5c2c1e2e40dbdc6a81b27fd
Distribution: ---
Staged patchset:


Attachments
always avoid memory on wrong side of stack pointer (3.37 KB, patch)
2008-07-08 17:34 UTC, John Reiser
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description John Reiser 2008-07-08 17:34:36 UTC
Created attachment 14664 [details]
always avoid memory on wrong side of stack pointer

The code which relays stack frames from one calling sequence to another can be written never to touch memory that lies on the undefined side of the current stack pointer.  Even though in normal cases there may be no danger in referencing below the stack pointer (because of precautions with alternate signal stack, etc.), it is more robust to avoid this.  Debuggers (both code and human) and other tools may be unaware of the special precautions, or may find it impossible to comply.
Patch is attached, and will be sent to wine-patches@winehq.org.
Comment 1 Austin English 2009-01-05 17:13:12 UTC
Is this still an issue in current (1.1.12 or newer) wine? Would you mind resubmitting the patch and asking for comments?
Comment 2 Austin English 2009-07-16 18:11:19 UTC
Probably still present.
Comment 3 Austin English 2010-05-19 19:51:14 UTC
Probably still present.
Comment 4 Austin English 2012-03-19 19:02:48 UTC
Still present.
Comment 5 Sebastian Lackner 2015-02-13 00:54:21 UTC
Still present in 1.7.36.

The original patch doesn't apply anymore, but this cleaned up and improved version should do basically the same:

https://github.com/wine-compholio/wine-staging/tree/master/patches/winebuild-Restore_Context
Comment 6 Sebastian Lackner 2015-02-24 17:48:26 UTC
Patch was submitted to the mailing list:
http://source.winehq.org/patches/data/109332
Comment 7 Sebastian Lackner 2015-02-27 14:37:11 UTC
Patch was accepted, should be fixed with:
http://source.winehq.org/git/wine.git/patch/44fbc018eda12bdee5c2c1e2e40dbdc6a81b27fd
Comment 8 Austin English 2015-02-27 17:59:29 UTC
(In reply to Sebastian Lackner from comment #7)
> Patch was accepted, should be fixed with:
> http://source.winehq.org/git/wine.git/patch/
> 44fbc018eda12bdee5c2c1e2e40dbdc6a81b27fd

Fixed.
Comment 9 Alexandre Julliard 2015-03-06 13:30:36 UTC
Closing bugs fixed in 1.7.38.


Privacy Policy
If you have a privacy inquiry regarding this site, please write to privacy@winehq.org

Hosted By CodeWeavers