Created attachment 14245 [details]
max payne 2: mirror reflection bug (something visible)

notice that now something else than black is visible in the mirror, it could be the reflection but it's kinda static and doesn't change when the player moves.

with static I mean that the image which is displayed inside the mirror isn't changed, it just moves around as the viewing position changes

Created attachment 14246 [details]
max payne 2: mirror reflection bug (two images)

after changing the viewing angle even more you can see that there are TWO images displayed inside the mirror, both are overlapping somehow

The bottom one also "extends" further to the bottom, I still have to create a screenshot to illustrate this

Don't have the problem with ati mobility radeon hd 2600 and ati-drivers 8.501

However Jan has the same performance issues with mirrors like me.

Disabling mirrors completly in the options menu gives us both a huge performance boost, especially in front of the warehouse (it's raining and the entire floor is reflecting the environment).

Summary (for my Geforce FX 5900 system):

abbrev.:
PPE (post processing effects)
ORM (offscreen rendering mode)

Mirrors=ON, PPE=OFF, ORM=backbuffer:
"kinda" works, performance bad

Mirrors=ON, PPE=MEDIUM, ORM=backbuffer:
"kinda" works, performance bad

Mirrors=ON, PPE=HIGH, ORM=backbuffer:
As described in the original bugreport -> this doesn't work at all

Mirrors=ON, PPE=OFF; ORM=fbo:
Works from all angles, performance again bad

Mirrors=ON, PPE=MEDIUM, ORM=fbo:
Works from all angles, perf bad

Mirrors=ON, PPE=HIGH, ORM=fbo:
Not working at all, when mirror object is in screen repeated fixme messages appear:
fixme:d3d:transform_texture Non-power2 texture being used with generated texture coords

What means:
"kinda" works: mirror not working correctly from ALL angles
When then viewing angle is very steep not all the scene is mirrored, some parts are simply black (attaching a screenshot to demonstrate that).

Created attachment 14362 [details]
mirror effect is partially working (black area)

this is Mirrors=ON, PPE=OFF, ORM=backbuffer

Additional info:

fixme:d3d:transform_texture Non-power2 texture being used with generated
texture coords

This also appears in high-mode when ORM is set to backbuffer, not only if ORM is set to fbo.

Forgot: Note that the fixme message only appears when a mirror object comes into view. Message emission stops when mirror is out of the viewport.

fixme:d3d:transform_texture Non-power2 texture being used with generated
texture coords

This message doesn't appear anymore with the "critical" settings and wine-0.9.56, so also a regression (or maybe the fixme message was inserted somewhere between wine-0.9.56 and wine-1.0.0 ?)

Update:

The mirror issues with ORM=backbuffer (mirror not working from all angles, black bars are visible inside the mirror) is directly tied to bug #14686.

As soon as an ingame resolution with a POT component is selected the black bars disappears and the mirrors work/look like they should.

Seems like that the scene image displayed in the mirror is suffering from the same cropping issue.

Greets,
Tobias

Status with wine git master:

ORM=fbo, PPE=medium: Mirrors work, performance bad
ORM=fbo, PPE=high: Mirrors NOT working (either black image, or not updated correctly)

res=800x800, ORM=backbuffer, PPE=medium: Mirrors work but have black bars "inside", performance bad
res=800x800, ORM=backbuffer, PPE=high: not working (see fbo, and previous reports)

res=1024x768, ORM=backbuffer, PPE=medium: Mirrors work, performance bad
res=1024x768, ORM=backbuffer, PPE=high: not working (see fbo, and previous reports)

So this issue still is there, nothing really changed.

Reconfirming with wine-1.1.13

Reconfirming with wine-1.1.20

Still getting these FIXMEs
fixme:d3d:transform_texture Non-power2 texture being used with generated texture coords

with ORM=fbo, ingame mirrors enabled and PPE=high.

For me graphics works perfect - mirrors are OK, other glitches related to pixel shader skins are gone also. Maybe this bug is card/driver related?

Tested with wine-1.2-rc5, GeForce 9100M with beta drivers 256.25

Still having issues with mirrors: The level geometry is displayed fine, but the character is missing - hmm...

Tested with wine-1.3.1

I don't have such problem - mirrors work perfectly here. Tested under:
 * nVidia GT240 v195.36.31
 * wine-1.3.2-39-g7f30ae6
 * Max Payne 2 v1.01 and Max Payne 2 Demo
 * resolution 1920x1200x32

I don't have such problem either- mirrors work perfectly wine 1.3.10 ,ati catalyst 10.12

Still experiencing this issue:
wine-1.3.10
Intel Corporation Arrandale Integrated Graphics Controller
mesa git master + libdrm git master + xf86-video-intel master
xorg-server-1.9.2.902

Engine config preset is 'High'.

I noticed that disabling the usage of 'Pixel Shader Skins' solves the issue. When this option is enabled the mirrors don't work properly (only a 'stripe' portion of Max is rendered in the mirror and some blueish artifacts appear on the Max's 'skin').

I noticed that the 'blueish artifacts on skin' issue also appears in FEAR. There the player model is affected.

Anyway, disabling GLSL support in wine also fixes the problem, so I guess it's a problem with the GLSL shader code that wine generates.

Created attachment 32783 [details]
FEAR sprite errors

I know this bug is about MP2, but this seems to be related:
I get these sprite rendering errors in FEAR (muzzle flash and other effects are also affected), which also go away when disabling GLSL. Not so visible in this screenshot is the blueish halo-like effect which happens on the player model. This is more apparent when you see the game in motion.

ATI and Nvidia users report that the bug does not appear. It is only for MESA driver users.
So-> driver bug.


This bug could be closed as INVALID

(In reply to comment #21)
> ATI and Nvidia users report that the bug does not appear. It is only for MESA
> driver users.
> So-> driver bug.
It doesn't work like that.

I cannot reproduce the bug.
Mirrors reflect perfectly for me.

Wine 1.5.5, NVIDIA 295.53 official drivers, Ubuntu 12.04.

The game crashes for me using an intel board, can anyone with nvidia/ati retest in wine 1.6-rc3? Otherwise I'll close this as fixed according to comment 23.

(In reply to comment #24)
> The game crashes for me using an intel board, can anyone with nvidia/ati retest
> in wine 1.6-rc3? Otherwise I'll close this as fixed according to comment 23.

The game and the mirrors work absolutely perfect.
You can close this bug!

I can confirm the issue in wine 1.6-rc5 with intel drivers and mesa 9.1.4. The mirror looks like comment 2 attachment.

(In reply to comment #26)
> I can confirm the issue in wine 1.6-rc5 with intel drivers and mesa 9.1.4. The
> mirror looks like comment 2 attachment.

Oh well, i forgot to mention that i use the latest nvidia proprietary drivers and wine 1.6-rc5.

Played a demo with max settings, any issues with mirrors are absent. (for me perhaps) Wine 1.7.1 and Nvidia 325.15

Still for me in wine 1.7.2.

works for me in 1.7.6

tested with nouveau (mesa 9.2.1) and nvidia 319.32

(In reply to comment #30)
> works for me in 1.7.6
> 
> tested with nouveau (mesa 9.2.1) and nvidia 319.32

Yes, works for me too in wine 1.7.7. Resolving fixed as tested by 2 different people.

Closing bugs fixed in 1.7.8.

AFAIK This bug would normally only be reproducible on hardware that lacks good NPOW texture support. IIRC the graphics driver must either be lacking GL_ARB_texture_non_power_of_two and GL_ARB_texture_rectangle features, or Wine must be hacked to pretend both these features are not present.

Because some of the recent reports come from people with new hardware, and the new cards probably all support these extensions, I suspect most simply didn't hit the codepath that doesn't work.

Bruno Jesus, what's the output of glxinfo  | egrep -oi 'GL_ARB_texture_rectangle|GL_ARB_texture_non_power_of_two' ?

Created attachment 47077 [details]
full glxinfo output

(In reply to comment #33)
> Bruno Jesus, what's the output of glxinfo  | egrep -oi
> 'GL_ARB_texture_rectangle|GL_ARB_texture_non_power_of_two' ?

$ glxinfo  | egrep -oi 'GL_ARB_texture_rectangle|GL_ARB_texture_non_power_of_two'
GL_ARB_texture_non_power_of_two
GL_ARB_texture_rectangle