WineHQ Bugzilla – Bug 26074 – shell32/brsfolder tests show some valgrind warnings

Bugzilla

Last modified: 2011-10-21 13:49:01 CDT

shell32/brsfolder tests show some valgrind warnings

Bug 26074 - shell32/brsfolder tests show some valgrind warnings

Summary:

shell32/brsfolder tests show some valgrind warnings

Status:	CLOSED FIXED

AppDB:	Show Apps affected by this bug
Product:	Wine
Classification:	Unclassified
Component:	shell32
Version:	1.3.13
Platform:	x86 Linux

Importance:	P2 minor
Target Milestone:	---
Assigned To:	Mr. Bugs

URL:
Keywords:	download, source, testcase

Depends on:
Blocks:
	Show dependency tree

Reported:	2011-02-11 18:28 CST by Austin English
Modified:	2011-10-21 13:49 CDT (History)
CC List:	2 users (show)

See Also:
Regression SHA1:
Fixed by SHA1:	bfad4fa9673e533c5357f7a3b21532d3806ed564

Attachments
valgrind log of "make test" in shell32 (306.41 KB, text/plain) 2011-10-15 16:03 CDT, Dan Kegel	Details
View All Add an attachment (back traces, logs, proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Austin English 2011-02-11 18:28:48 CST

Conditional jump or move depends on uninitialised value(s)
    at  wine_utf8_mbstowcs (utf8.c:317)
    by  MultiByteToWideChar (locale.c:1912)
    by  test_click_make_new_folder_button (brsfolder.c:201)
    by  func_brsfolder (brsfolder.c:252)
    by  run_test (test.h:556)
    by  main (test.h:624)
  Uninitialised value was created by a stack allocation
    at  test_click_make_new_folder_button (brsfolder.c:149)

...

 Use of uninitialised value of size 4
    at  decode_utf8_char (utf8.c:163)
    by  wine_utf8_mbstowcs (utf8.c:322)
    by  MultiByteToWideChar (locale.c:1912)
    by  test_click_make_new_folder_button (brsfolder.c:201)
    by  func_brsfolder (brsfolder.c:252)
    by  run_test (test.h:556)
    by  main (test.h:624)
  Uninitialised value was created by a stack allocation
    at  test_click_make_new_folder_button (brsfolder.c:149)

...

 Use of uninitialised value of size 4
    at  mbstowcs_sbcs (mbtowc.c:95)
    by  wine_cp_mbstowcs (mbtowc.c:269)
    by  MultiByteToWideChar (locale.c:1920)
    by  SHBrowseForFolderA (brsfolder.c:922)
    by  test_click_make_new_folder_button (brsfolder.c:209)
    by  func_brsfolder (brsfolder.c:252)
    by  run_test (test.h:556)
    by  main (test.h:624)
  Uninitialised value was created by a stack allocation
    at  test_click_make_new_folder_button (brsfolder.c:149)

Comment 1 Nikolay Sivov 2011-02-11 18:41:03 CST

I sent a patch for that some weeks ago, I need to try again I guess.

http://www.winehq.org/pipermail/wine-patches/2011-January/098343.html

Comment 2 Dan Kegel 2011-10-15 16:02:56 CDT

Still happening.  Could you try again?  I'll attach a current log.

Comment 3 Dan Kegel 2011-10-15 16:03:23 CDT

Created attachment 36924 [details]
valgrind log of "make test" in shell32

Comment 4 Piotr Caban 2011-10-18 15:57:14 CDT

Please retest with newest wine. Should be fixed by shell
bfad4fa9673e533c5357f7a3b21532d3806ed564 and
0655a6e56340c438c8de14d1e43978042a62894d.

Comment 5 Austin English 2011-10-19 13:32:27 CDT

(In reply to comment #4)
> Please retest with newest wine. Should be fixed by shell
> bfad4fa9673e533c5357f7a3b21532d3806ed564 and
> 0655a6e56340c438c8de14d1e43978042a62894d.

Yep.

Comment 6 Alexandre Julliard 2011-10-21 13:49:01 CDT

Closing bugs fixed in 1.3.31.