WineHQ
Bug Tracking Database – Bug 14406

 Bugzilla

 

Last modified: 2010-05-07 13:29:13 CDT  

Goldwave loaded mp3 file is corrupted

Bug 14406 - Goldwave loaded mp3 file is corrupted
: Goldwave loaded mp3 file is corrupted
Status: CLOSED FIXED
AppDB: Show Apps affected by this bug
Product: Wine
Classification: Unclassified
Component: -unknown
: unspecified
: x86 Linux
: P2 normal
: ---
Assigned To: Mr. Bugs
:
:
:
:
  Show dependency tree
 
Reported: 2008-07-10 13:53 CDT by billstei
Modified: 2010-05-07 13:29 CDT (History)
5 users (show)

See Also:
Regression SHA1:
Fixed by SHA1:


Attachments
Corrupted mp3 example image (20.35 KB, image/png)
2008-07-10 13:53 CDT, billstei
Details

Note You need to log in before you can comment on or make changes to this bug.
Description billstei 2008-07-10 13:53:02 CDT
Created attachment 14718 [details]
Corrupted mp3 example image

The program GoldWave version 5.25 from here: http://www.goldwave.com

When loading mp3 files (especially when large >20 meg) corrupts them and the
following message occurs on standard out:

fixme:mpeg3:MPEG3_StreamSize misses the block header overhead

Please see the attached image of an example mp3 audio clip as loaded into
GoldWave compared to the same clip which was loaded into Audacity audio editor
and exported to wav, and that wav then loaded into GoldWave.  The mp3 is
corrupted in 3 places (within the first second of time -- actual number of
corruptions is hundreds/thousands of occurences) in the example as compared to
the wav file.  These distortions are very audible so when testing they can be
easily located simply by listening and then zooming in to the affected area
(turning down the volume to amplifier and speakers is advised).
Comment 1 Eberhard Mattes 2008-08-14 16:59:54 CDT
mp3DirectCut also causes this error message to be displayed when trying to play
sound.
Comment 2 Eberhard Mattes 2008-08-14 17:00:32 CDT

    
Comment 3 billstei 2009-01-08 16:25:44 CST
Tested git Wine 1.1.12-312 and I cannot find any corruptions, including in very
large files (>100 Meg), however the fixme message as noted in comment #1
remains.  Recommend closing the bug as fixed.
Comment 4 Austin English 2009-01-08 16:47:28 CST
Fixed then.
Comment 5 Alexandre Julliard 2009-01-16 10:38:59 CST
Closing bugs fixed in 1.1.13.
Comment 6 Juan Lang 2009-02-04 10:59:44 CST
Reported broken again.
Comment 7 Juan Lang 2009-02-04 11:00:23 CST
*** Bug 17247 has been marked as a duplicate of this bug. ***
Comment 8 maxdub432 2009-03-11 16:40:35 CDT
With GoldWave 5.14 in wine 1.0.1 I found the problem only manifests in 1/10 of
the files I open and there isn't really a correlation between the file sizes
and the corruption (a ~200mb file worked fine, an ~11mb file corrupted, a
~10.5mb file was fine, etc.)

I fixed the problem in its entirety by replacing winemp3.acm with l3codecp.acm
(updating system.ini, etc.) but I have no idea how this affects the operation
of programs besides GoldWave
Comment 9 Jim 2009-03-14 07:45:24 CDT
Thank You maxdub432....problem solved!

Simple...I edited system.ini, changed the entry for winemp3.acm to
l3codeca.acm, everything seems to be just fine.  Many, many thanks, as this is
a very useful program, since it has a vectorscope display, and other
things...now if i can get the DX modules part working.....

FYI--I'm running a Dell p4, 2.86Ghz, 1 GB ram, Ubuntu 8.10, Wine 1.1.17

This place ROCKS!!!
Comment 10 Saulius K. 2009-03-14 13:21:19 CDT
Looks like AppDB needs another component added, one like "winemp3".

And then it seems Wine is using source comming from the year 1997:

| $ head -n 5 wine/dlls/winemp3.acm/layer3.c
| /*
|  * Mpeg Layer-3 audio decoder
|  * --------------------------
|  * copyright (c) 1995,1996,1997 by Michael Hipp.

While on stable Debian (now Lenny) we have a bit more fresh version:

| $ head -n 5 mpg123-1.4.3/src/libmpg123/layer3.c
| /*
|         leyer3.c: the layer 3 decoder
| 
|         copyright 1995-2008 by the mpg123 project - free software under the
terms of the LGPL 2.1
|         see COPYING and AUTHORS files in distribution or http://mpg123.org

And it seems a porting person was Erich Pouech:

| $ git-blame dlls/winemp3.acm/layer3.c | head
| b706b23a dlls/msacm/winemp3/layer3.c (Eric Pouech        2002-06-04 17:53:46
+0000    1) /*
| b706b23a dlls/msacm/winemp3/layer3.c (Eric Pouech        2002-06-04 17:53:46
+0000    2)  * Mpeg Layer-3 audio decoder
| b706b23a dlls/msacm/winemp3/layer3.c (Eric Pouech        2002-06-04 17:53:46
+0000    3)  * --------------------------
| b706b23a dlls/msacm/winemp3/layer3.c (Eric Pouech        2002-06-04 17:53:46
+0000    4)  * copyright (c) 1995,1996,1997 by Michael Hipp.
| b706b23a dlls/msacm/winemp3/layer3.c (Eric Pouech        2002-06-04 17:53:46
+0000    5)  * All rights reserved. See also 'README'
| b706b23a dlls/msacm/winemp3/layer3.c (Eric Pouech        2002-06-04 17:53:46
+0000    6)  * This file has been copied from mpglib.
| b706b23a dlls/msacm/winemp3/layer3.c (Eric Pouech        2002-06-04 17:53:46
+0000    7)  *
| b706b23a dlls/msacm/winemp3/layer3.c (Eric Pouech        2002-06-04 17:53:46
+0000    8)  * This library is free software; you can redistribute it and/or
| b706b23a dlls/msacm/winemp3/layer3.c (Eric Pouech        2002-06-04 17:53:46
+0000    9)  * modify it under the terms of the GNU Lesser General Public
| b706b23a dlls/msacm/winemp3/layer3.c (Eric Pouech        2002-06-04 17:53:46
+0000   10)  * License as published by the Free Software Foundation; either

billstei, you would probably like to assign this bug to Eric : ).  His contacts
could be found in the wiki:


[*] http://wiki.winehq.org/WhosWho#line-114
Comment 11 billstei 2009-03-27 11:46:46 CDT
Tested Wine git 1.1.17-246, which includes this commit:

http://source.winehq.org/git/wine.git/?a=commit;h=21186d5a69a4d1f787edfe92ad26d4a7a964651a

Did a before/after 1.1.17-246 test on an mp3 file, and this file showed 4
corrupted sections in 8 seconds, all of which were gone in 1.1.17-246, but one
new corruption is now present.  Needless to say the fixme messages are no
longer there, but I would have to say this bug remains (or there is a new one
in the new code).
Comment 12 Conrad Bebbington 2009-04-03 07:14:04 CDT
*** Bug 15026 has been marked as a duplicate of this bug. ***
Comment 13 Conrad Bebbington 2009-04-05 14:12:48 CDT
Just thought I'd point out that Bug 15026 (which I have marked as a dup)
appears to be the same problem but affecting Ableton Live.
Comment 14 billstei 2009-04-06 19:49:07 CDT
No change from comment #11 above and Wine git 1.1.18-199
Comment 15 Jim 2009-05-18 04:13:27 CDT
Goldwave is working fine for me, using wine 1.1.21, but I had to re-edit the
system.ini file as described before to make the errors go away after an
update...Hope this helps.
Comment 16 billstei 2009-10-05 10:18:02 CDT
Testing Goldwave 5.52 with Wine 1.1.30 (Scott Richie build) in Ubuntu Jaunty
9.04, I am not able to load mp3 files (not even as corrupted), Goldwave
reporting "Cannot determine format of file:" in a dialog window to manually
specify the format (which does not include mp3).  Console output shows this
(typical):

fixme:amstream:IAMMultiMediaStreamImpl_AddMediaStream
(0x1bc2e8/0x1bc2e8)->((nil),{a35ff56b-9fda-11d0-8fdf-00c04fd9189d},0,0x32f2a0)
partial stub!
err:amstream:IMediaStreamImpl_QueryInterface
(0x1b59a0)->({f7537560-a3be-11d0-8212-00c04fc32c45},0x32f288),not found
fixme:amstream:IAMMultiMediaStreamImpl_SetState (0x1bc2e8/0x1bc2e8)->() stub!
Comment 17 matthias.ptz 2009-12-16 16:57:36 CST
I've got the same problem here.
The online manual for GoldWave says that MP3 can only be opened if an actual
Windows Media Player is installed. I tried WMP 7.1 (because all other WMPs
require a check of the validity of windows (and I doubt Wine would pass this)),
but the installer told me, I already have an actual version of WMP.
Comment 18 billstei 2010-04-21 20:53:22 CDT
Tested Wine 1.1.43 and Goldwave 5.55, and I have not been able to find any
distortions, including a test file that I have kept specifically for this
purpose.  I verified that "msacm.winemp3=winemp3.acm" is in system.ini.  Also
the error message "fixme:mpeg3:MPEG3_StreamSize misses the block header
overhead" is no longer present in the console.  I would say this bug is fixed.
Comment 19 Jeff Zaroyko 2010-04-21 21:43:38 CDT
Reported fixed.
Comment 20 Alexandre Julliard 2010-05-07 13:29:13 CDT
Closing bugs fixed in 1.1.44.


Hosted By CodeWeavers